GKaszewski/archlens
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Extract shared logic from run() and run_watch() #13

New Issue
Open
opened 2026-07-25 11:17:45 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:17:45 +00:00
Owner
Copy Link

Severity: Medium

crates/presentation/src/lib.rs lines 64-92 (run()) and lines 346-373 (the run_once closure inside run_watch()) are nearly identical: load config, build graph, create renderer, parse rules, execute GenerateDiagram, write output, report violations.

This is copy-paste code. Extract a shared function.

**Severity: Medium** `crates/presentation/src/lib.rs` lines 64-92 (`run()`) and lines 346-373 (the `run_once` closure inside `run_watch()`) are nearly identical: load config, build graph, create renderer, parse rules, execute `GenerateDiagram`, write output, report violations. This is copy-paste code. Extract a shared function.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Correctness bugs — diagrams wrong or useless without this
 P2
Output richness — diagrams correct but missing signal
 P3
Unique value — enforcement, new languages
 P4
Nice to have — new renderers, DX, performance
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/archlens#13
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?