GKaszewski/archlens
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Use ValueEnum for --level and --format CLI args #14

New Issue
Open
opened 2026-07-25 11:17:50 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:17:50 +00:00
Owner
Copy Link

Severity: Medium

crates/presentation/src/lib.rs lines 289-295: any unrecognized --level value silently defaults to Module via the _ arm. A user typing --level typ (a typo) gets no feedback.

--level and --format are String in the CLI struct (crates/presentation/src/cli.rs lines 17-21) when they should be enums with clap::ValueEnum derive. Clap would then validate and provide shell completions for free.

**Severity: Medium** `crates/presentation/src/lib.rs` lines 289-295: any unrecognized `--level` value silently defaults to `Module` via the `_` arm. A user typing `--level typ` (a typo) gets no feedback. `--level` and `--format` are `String` in the CLI struct (`crates/presentation/src/cli.rs` lines 17-21) when they should be enums with `clap::ValueEnum` derive. Clap would then validate and provide shell completions for free.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Correctness bugs — diagrams wrong or useless without this
 P2
Output richness — diagrams correct but missing signal
 P3
Unique value — enforcement, new languages
 P4
Nice to have — new renderers, DX, performance
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/archlens#14
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?