GKaszewski/archlens
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Remove or wire up unused OutputWriter port #15

New Issue
Open
opened 2026-07-25 11:17:53 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:17:53 +00:00
Owner
Copy Link

Severity: Medium

crates/domain/src/ports/output_writer.rs and crates/adapters/file-writer/, crates/adapters/stdout-writer/ exist as full adapter implementations, but the presentation layer in lib.rs does all I/O directly via std::fs::write and print! (lines 103-117).

The OutputWriter abstraction is dead code — it exists but is never wired up. Either use it or remove it.

**Severity: Medium** `crates/domain/src/ports/output_writer.rs` and `crates/adapters/file-writer/`, `crates/adapters/stdout-writer/` exist as full adapter implementations, but the presentation layer in `lib.rs` does all I/O directly via `std::fs::write` and `print!` (lines 103-117). The `OutputWriter` abstraction is dead code — it exists but is never wired up. Either use it or remove it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Correctness bugs — diagrams wrong or useless without this
 P2
Output richness — diagrams correct but missing signal
 P3
Unique value — enforcement, new languages
 P4
Nice to have — new renderers, DX, performance
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/archlens#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?