v0.5.0 — codebase refinement, flexible API, architecture cleanup
Error handling:
thiserror enum (NotFound/BadRequest/Unauthorized/Forbidden/Internal)
eliminates 41 boilerplate .map_err() calls
signature failures return 401, not 500
Named types:
Keypair, LocalObject (with to/cc/bto/bcc addressing), Addressing
Readability:
descriptive names everywhere, small functions, breathing room
noisy comments removed, intent-explicit error handling (no let _ =)
types.rs per module separating data from behavior
File organization:
handlers/ module (actor, featured, followers, inbox, nodeinfo, outbox, webfinger)
actors/ split (mod.rs + person.rs + types.rs)
service/ split (builder, broadcast, collections, delivery, fetch, follow, lookup, types)
tests next to modules
Repository traits:
FollowRepository → 5 sub-traits (FollowerWriter/Reader, FollowingWriter/Reader, FollowMigration)
ActorRepository → 3 sub-traits (KeypairRepository, RemoteActorCache, AnnounceRepository)
BlocklistRepository → 2 sub-traits (DomainBlocklist, ActorBlocklist)
supertraits with blanket impls — existing consumers unchanged
FollowMigration has default no-op
delete dead get_following_outbox_url
Testing:
mock_repo! macro generates mock builders from compact specs
MockFollowRepo, MockActorRepo, MockBlocklistRepo, MockActivityRepo,
MockUserRepo, MockContentReader, MockObjectHandler, MockEventPublisher
all hand-written test stubs replaced
Flexibility:
UrlScheme trait — configurable URL patterns (DefaultUrlScheme = /users/{uuid})
on_unknown_activity hook for custom AP extensions
broadcast_raw_to_followers for arbitrary activity JSON
broadcast_create/broadcast_update (renamed from Note-centric names)
internal modules locked to pub(crate), clean public re-exports
actor_handler, followers_handler, following_handler re-exported for custom routers
Security:
SSRF: block IPv6-mapped private IPv4, TEST-NET, benchmarking, reserved ranges
verify_attributed_to rejects missing/array attributedTo
remove .expect() from outbox handler
Architecture:
handlers/followers.rs delegates to serialize_ordered_collection (no more UrlScheme bypass)
extract dispatch_sends, prepare_addressed_broadcast (eliminate duplication)
DbActor::object_id(), RemoteActor::from/from_ap_person/placeholder
send_activity unifies prepare+dispatch, deterministic_activity_id helper
pass-through wrappers grouped in lookup.rs
This commit is contained in:
@@ -52,9 +52,9 @@ impl Activity for DeleteActivity {
|
||||
_ => String::new(),
|
||||
};
|
||||
if !object_domain.is_empty() && actor_domain != object_domain {
|
||||
return Err(Error::bad_request(anyhow::anyhow!(
|
||||
"Delete actor domain does not match object domain"
|
||||
)));
|
||||
return Err(Error::bad_request(
|
||||
"Delete actor domain does not match object domain",
|
||||
));
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
@@ -78,17 +78,13 @@ impl Activity for DeleteActivity {
|
||||
return Ok(());
|
||||
};
|
||||
if object_url == *self.actor.inner() {
|
||||
data.object_handler
|
||||
.on_actor_removed(&actor_url)
|
||||
.await
|
||||
.map_err(|e| Error::from(anyhow::anyhow!(e)))?;
|
||||
data.object_handler.on_actor_removed(&actor_url).await?;
|
||||
tracing::info!(actor = %actor_url, "received Delete(actor) — remote account deleted");
|
||||
return Ok(());
|
||||
}
|
||||
data.object_handler
|
||||
.on_delete(&object_url, &actor_url)
|
||||
.await
|
||||
.map_err(|e| Error::from(anyhow::anyhow!(e)))?;
|
||||
.await?;
|
||||
tracing::info!(object = %object_url, "received Delete(note)");
|
||||
Ok(())
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user