v0.5.0 — codebase refinement, flexible API, architecture cleanup
Error handling:
thiserror enum (NotFound/BadRequest/Unauthorized/Forbidden/Internal)
eliminates 41 boilerplate .map_err() calls
signature failures return 401, not 500
Named types:
Keypair, LocalObject (with to/cc/bto/bcc addressing), Addressing
Readability:
descriptive names everywhere, small functions, breathing room
noisy comments removed, intent-explicit error handling (no let _ =)
types.rs per module separating data from behavior
File organization:
handlers/ module (actor, featured, followers, inbox, nodeinfo, outbox, webfinger)
actors/ split (mod.rs + person.rs + types.rs)
service/ split (builder, broadcast, collections, delivery, fetch, follow, lookup, types)
tests next to modules
Repository traits:
FollowRepository → 5 sub-traits (FollowerWriter/Reader, FollowingWriter/Reader, FollowMigration)
ActorRepository → 3 sub-traits (KeypairRepository, RemoteActorCache, AnnounceRepository)
BlocklistRepository → 2 sub-traits (DomainBlocklist, ActorBlocklist)
supertraits with blanket impls — existing consumers unchanged
FollowMigration has default no-op
delete dead get_following_outbox_url
Testing:
mock_repo! macro generates mock builders from compact specs
MockFollowRepo, MockActorRepo, MockBlocklistRepo, MockActivityRepo,
MockUserRepo, MockContentReader, MockObjectHandler, MockEventPublisher
all hand-written test stubs replaced
Flexibility:
UrlScheme trait — configurable URL patterns (DefaultUrlScheme = /users/{uuid})
on_unknown_activity hook for custom AP extensions
broadcast_raw_to_followers for arbitrary activity JSON
broadcast_create/broadcast_update (renamed from Note-centric names)
internal modules locked to pub(crate), clean public re-exports
actor_handler, followers_handler, following_handler re-exported for custom routers
Security:
SSRF: block IPv6-mapped private IPv4, TEST-NET, benchmarking, reserved ranges
verify_attributed_to rejects missing/array attributedTo
remove .expect() from outbox handler
Architecture:
handlers/followers.rs delegates to serialize_ordered_collection (no more UrlScheme bypass)
extract dispatch_sends, prepare_addressed_broadcast (eliminate duplication)
DbActor::object_id(), RemoteActor::from/from_ap_person/placeholder
send_activity unifies prepare+dispatch, deterministic_activity_id helper
pass-through wrappers grouped in lookup.rs
This commit is contained in:
40
src/lib.rs
40
src/lib.rs
@@ -1,33 +1,35 @@
|
||||
pub mod activities;
|
||||
pub mod actor_handler;
|
||||
pub mod actors;
|
||||
pub mod content;
|
||||
pub mod data;
|
||||
pub mod error;
|
||||
pub mod featured_handler;
|
||||
pub mod federation;
|
||||
pub mod followers_handler;
|
||||
pub mod inbox;
|
||||
pub mod nodeinfo;
|
||||
pub mod outbox;
|
||||
pub(crate) mod activities;
|
||||
pub(crate) mod actors;
|
||||
pub(crate) mod content;
|
||||
pub(crate) mod data;
|
||||
pub(crate) mod error;
|
||||
pub(crate) mod federation;
|
||||
pub(crate) mod handlers;
|
||||
pub mod repository;
|
||||
pub(crate) mod security;
|
||||
pub mod service;
|
||||
/// Mock builders for testing. Not behind `#[cfg(test)]` so downstream crates
|
||||
/// can use them in their own test suites.
|
||||
pub mod testing;
|
||||
pub(crate) mod url_scheme;
|
||||
pub(crate) mod urls;
|
||||
pub mod user;
|
||||
pub mod webfinger;
|
||||
pub(crate) mod user;
|
||||
|
||||
pub use activitypub_federation::kinds::object::NoteType;
|
||||
pub use content::{ApContentReader, ApObjectHandler};
|
||||
pub use content::{ApContentReader, ApObjectHandler, LocalObject};
|
||||
pub use data::{EventPublisher, FederationData, FederationEvent};
|
||||
pub use error::Error;
|
||||
pub use federation::ApFederationConfig;
|
||||
pub use handlers::actor::actor_handler;
|
||||
pub use handlers::followers::{followers_handler, following_handler};
|
||||
pub use repository::{
|
||||
ActivityRepository, ActorRepository, BlockedDomain, BlocklistRepository, FollowRepository,
|
||||
Follower, FollowerStatus, FollowingStatus, RemoteActor,
|
||||
ActivityRepository, ActorBlocklist, ActorRepository, AnnounceRepository, BlockedDomain,
|
||||
BlocklistRepository, DomainBlocklist, FollowMigration, FollowRepository, Follower,
|
||||
FollowerReader, FollowerStatus, FollowerWriter, FollowingReader, FollowingStatus,
|
||||
FollowingWriter, Keypair, KeypairRepository, RemoteActor, RemoteActorCache,
|
||||
};
|
||||
pub use service::ActivityPubService;
|
||||
pub use urls::AS_PUBLIC;
|
||||
pub use url_scheme::{DefaultUrlScheme, UrlScheme};
|
||||
pub use urls::{AP_CONTENT_TYPE, AP_CONTEXT, AS_PUBLIC, INBOX_BODY_LIMIT};
|
||||
pub use user::{
|
||||
ApActorType, ApProfileField, ApUser, ApUserRepository, ApVisibility, LookedUpActor,
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user