Validate base_url in builder instead of expect() on every use #16

New Issue

GKaszewski · 2026-07-25T11:18:11Z

GKaszewski commented

2026-07-25 11:18:11 +00:00

Severity: Medium

src/actors.rs:122-126: ActorUrls::build() uses .expect("valid url") on four Url::parse calls. These are constructed from a user-supplied base_url string. If base_url is malformed, these panic at runtime.

The actor_url() function in src/urls.rs:39-42 has the same problem.

Fix: validate base_url once at construction time in the builder and return Result, not trust it blindly at every use site.

**Severity: Medium** `src/actors.rs:122-126`: `ActorUrls::build()` uses `.expect("valid url")` on four `Url::parse` calls. These are constructed from a user-supplied `base_url` string. If `base_url` is malformed, these panic at runtime. The `actor_url()` function in `src/urls.rs:39-42` has the same problem. Fix: validate `base_url` once at construction time in the builder and return `Result`, not trust it blindly at every use site.

GKaszewski closed this issue

2026-07-25 15:07:43 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GKaszewski/k-ap#16