GKaszewski/k-ap
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

Extract shared inbox dedup logic from broadcast methods #17

New Issue
Closed
opened 2026-07-25 11:18:15 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:18:15 +00:00
Owner
Copy Link

Severity: Medium

src/service/broadcast.rs: broadcast_create_note (lines 240-299) and broadcast_update_note (lines 303-351) are nearly identical — same inbox deduplication logic (lines 257-274 vs 318-335), same HashSet pattern, same early-return.

Extract into a shared helper function.

**Severity: Medium** `src/service/broadcast.rs`: `broadcast_create_note` (lines 240-299) and `broadcast_update_note` (lines 303-351) are nearly identical — same inbox deduplication logic (lines 257-274 vs 318-335), same HashSet pattern, same early-return. Extract into a shared helper function.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/k-ap#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?