From 4bcc9f0686867c1f17783bce369fd46cde940825 Mon Sep 17 00:00:00 2001 From: Gabriel Kaszewski Date: Wed, 26 Aug 2026 09:18:19 +0200 Subject: [PATCH] Refactor VAPID signature building for improved clarity and error handling --- crates/adapters/web-push/src/lib.rs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/crates/adapters/web-push/src/lib.rs b/crates/adapters/web-push/src/lib.rs index 2672c52..28fd88d 100644 --- a/crates/adapters/web-push/src/lib.rs +++ b/crates/adapters/web-push/src/lib.rs @@ -83,16 +83,13 @@ impl domain::ports::ReminderSenderPort for WebPushSender { let payload_str = payload.to_string(); for sub in &subscriptions { - let subscription_info = - SubscriptionInfo::new(sub.endpoint(), sub.p256dh(), sub.auth()); + let subscription_info = SubscriptionInfo::new(sub.endpoint(), sub.p256dh(), sub.auth()); - let mut sig_builder = VapidSignatureBuilder::from_base64( - &self.vapid_private_key, - &subscription_info, - ) - .map_err(|e| { - DomainError::InvalidInput(format!("failed to build VAPID signature: {e}")) - })?; + let mut sig_builder = + VapidSignatureBuilder::from_base64(&self.vapid_private_key, &subscription_info) + .map_err(|e| { + DomainError::InvalidInput(format!("failed to build VAPID signature: {e}")) + })?; sig_builder.add_claim("sub", &*self.vapid_subject); let signature = sig_builder.build().map_err(|e| {