fix: harden kernel — eliminate UB, proper process cleanup

Critical: kernel_ref() UB eliminated
- kernel_ref() returned &'static mut, creating aliasing mutable
  references across trap handler + boot code (13+ call sites)
- Replaced with kernel_ptr() -> *mut Kernel, each use site does
  explicit unsafe { &mut *kernel_ptr() }
- KernelCell: removed get_mut(), added as_ptr() -> *mut T
- UB is gone: raw pointer access makes the single-core invariant
  explicit at every use site

Important: process cleanup on exit/fault
- New destroy_process() method consolidates cleanup:
  - Removes all threads from scheduler and endpoints
  - Clears pending messages and results
  - Destroys process and frees ProcessMemory
- handle_exit and handle_fault both use destroy_process()
- handle_exit_thread uses destroy_process when last thread exits

IPC hardening:
- Added invariant comment on pending_messages[sender].take()
  (sender in wait queue must have a pending message)

handle_release_pages:
- Now uses translate_va to convert VA→PA (was treating VA as PA)
This commit is contained in:
2026-10-18 22:22:48 +02:00
parent 61e28f0af5
commit ea2ac5d1d9
12 changed files with 100 additions and 92 deletions

View File

@@ -14,6 +14,7 @@ impl<P: Platform> Kernel<P> {
Err(_) => return,
};
// Try to deliver fault to a fault handler endpoint (if configured)
if let Ok(process) = self.processes.get(pid) {
if let Some(handler_slot) = process.fault_handler() {
if let Ok(cap) = process.capabilities().get(handler_slot) {
@@ -46,21 +47,6 @@ impl<P: Platform> Kernel<P> {
}
}
let thread_ids: [Option<types::id::ThreadId>; 4] = {
match self.processes.get(pid) {
Ok(p) => {
let mut ids = [None; 4];
for (i, t) in p.thread_ids().enumerate() {
if i < 4 { ids[i] = Some(t); }
}
ids
}
Err(_) => return,
}
};
self.cleanup_threads(&thread_ids);
let _ = self.processes.destroy(pid);
self.process_memory[pid.raw() as usize] = None;
self.destroy_process(pid);
}
}

View File

@@ -151,6 +151,8 @@ impl<P: Platform> Kernel<P> {
let message = self.pending_messages[sender_tid.raw() as usize]
.take()
// A sender in the wait queue must have a pending message.
// If not, the kernel state is inconsistent.
.unwrap_or_else(|| domain::message::Message::empty());
self.pending_results[sender_tid.raw() as usize] = Some(SyscallResult::Ok);

View File

@@ -50,25 +50,7 @@ impl<P: Platform> Kernel<P> {
_caller_tid: types::id::ThreadId,
pid: types::id::ProcessId,
) -> SyscallOutcome {
let thread_ids: [Option<types::id::ThreadId>; 4] = {
match self.processes.get(pid) {
Ok(p) => {
let mut ids = [None; 4];
for (i, tid) in p.thread_ids().enumerate() {
if i < 4 {
ids[i] = Some(tid);
}
}
ids
}
Err(_) => return SyscallOutcome::TerminateCaller,
}
};
self.cleanup_threads(&thread_ids);
let _ = self.processes.destroy(pid);
self.process_memory[pid.raw() as usize] = None;
self.destroy_process(pid);
SyscallOutcome::TerminateCaller
}
@@ -85,8 +67,7 @@ impl<P: Platform> Kernel<P> {
if let Ok(process) = self.processes.get_mut(pid) {
process.remove_thread(caller_tid);
if process.thread_ids().count() == 0 {
let _ = self.processes.destroy(pid);
self.process_memory[pid.raw() as usize] = None;
self.destroy_process(pid);
}
}