GKaszewski/k-photos
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Deduplicate count_search and bind_filters logic #4

New Issue
Open
opened 2026-07-25 11:17:18 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:17:18 +00:00
Owner
Copy Link

Severity: Medium

In crates/adapters/postgres/src/catalog/mod.rs, the count_search method manually re-binds all filter parameters instead of reusing the bind_filters helper function that exists right above it.

The duplication is ~15 lines and a maintenance hazard — if a new filter is added to bind_filters but not to count_search, they'll diverge silently.

**Severity: Medium** In `crates/adapters/postgres/src/catalog/mod.rs`, the `count_search` method manually re-binds all filter parameters instead of reusing the `bind_filters` helper function that exists right above it. The duplication is ~15 lines and a maintenance hazard — if a new filter is added to `bind_filters` but not to `count_search`, they'll diverge silently.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/k-photos#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?