GKaszewski/k-photos
1
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Log warnings on silent JSON deserialization failures #6

New Issue
Open
opened 2026-07-25 11:17:28 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:17:28 +00:00
Owner
Copy Link

Severity: Low

candidates_from_json and members_from_json use serde_json::from_value(v).unwrap_or_default(). If the JSON in the database is malformed, these silently return empty vectors instead of surfacing the error.

For production data integrity, this should at least log a warning when deserialization fails.

**Severity: Low** `candidates_from_json` and `members_from_json` use `serde_json::from_value(v).unwrap_or_default()`. If the JSON in the database is malformed, these silently return empty vectors instead of surfacing the error. For production data integrity, this should at least log a warning when deserialization fails.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/k-photos#6
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?