feat: multi-instance provider support
- provider_configs: add id TEXT PK; migrate existing rows (provider_type becomes id)
- local_files_index: add provider_id column + index; scope all queries per instance
- ProviderConfigRow: add id field; add get_by_id to trait
- LocalIndex:🆕 add provider_id param; all SQL scoped by provider_id
- factory: thread provider_id through build_local_files_bundle
- AppState.local_index: Option<Arc<LocalIndex>> → HashMap<String, Arc<LocalIndex>>
- admin_providers: restructured routes (POST /admin/providers create, PUT/DELETE /{id}, POST /test)
- admin_providers: use row.id as registry key for jellyfin and local_files
- files.rescan: optional ?provider=<id> query param
- frontend: add id to ProviderConfig, update api/hooks, new multi-instance panel UX
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
//! Admin provider management routes.
|
||||
//!
|
||||
//! All routes require an admin user. Allows listing, updating, deleting, and
|
||||
//! All routes require an admin user. Allows listing, creating, updating, deleting, and
|
||||
//! testing media provider configs stored in the DB. Only available when
|
||||
//! CONFIG_SOURCE=db.
|
||||
|
||||
@@ -26,14 +26,36 @@ use crate::state::AppState;
|
||||
// DTOs
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
/// Validate that an instance id is a safe slug (alphanumeric + hyphens, 1-40 chars).
|
||||
fn is_valid_instance_id(id: &str) -> bool {
|
||||
!id.is_empty()
|
||||
&& id.len() <= 40
|
||||
&& id.chars().all(|c| c.is_ascii_alphanumeric() || c == '-')
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
pub struct ProviderConfigPayload {
|
||||
pub struct CreateProviderRequest {
|
||||
pub id: String,
|
||||
pub provider_type: String,
|
||||
pub config_json: HashMap<String, String>,
|
||||
pub enabled: bool,
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
pub struct UpdateProviderRequest {
|
||||
pub config_json: HashMap<String, String>,
|
||||
pub enabled: bool,
|
||||
}
|
||||
|
||||
#[derive(Debug, Deserialize)]
|
||||
pub struct TestProviderRequest {
|
||||
pub provider_type: String,
|
||||
pub config_json: HashMap<String, String>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Serialize)]
|
||||
pub struct ProviderConfigResponse {
|
||||
pub id: String,
|
||||
pub provider_type: String,
|
||||
pub config_json: HashMap<String, serde_json::Value>,
|
||||
pub enabled: bool,
|
||||
@@ -51,9 +73,9 @@ pub struct TestResult {
|
||||
|
||||
pub fn router() -> Router<AppState> {
|
||||
Router::new()
|
||||
.route("/", get(list_providers))
|
||||
.route("/{type}", put(update_provider).delete(delete_provider))
|
||||
.route("/{type}/test", post(test_provider))
|
||||
.route("/", get(list_providers).post(create_provider))
|
||||
.route("/{id}", put(update_provider).delete(delete_provider))
|
||||
.route("/test", post(test_provider))
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
@@ -97,6 +119,12 @@ async fn rebuild_registry(state: &AppState) -> DomainResult<()> {
|
||||
let rows = state.provider_config_repo.get_all().await?;
|
||||
let mut new_registry = infra::ProviderRegistry::new();
|
||||
|
||||
#[cfg(feature = "local-files")]
|
||||
let mut new_local_index: std::collections::HashMap<String, Arc<infra::LocalIndex>> =
|
||||
std::collections::HashMap::new();
|
||||
#[cfg(feature = "local-files")]
|
||||
let mut first_transcode_manager: Option<Arc<infra::TranscodeManager>> = None;
|
||||
|
||||
for row in &rows {
|
||||
if !row.enabled {
|
||||
continue;
|
||||
@@ -108,7 +136,7 @@ async fn rebuild_registry(state: &AppState) -> DomainResult<()> {
|
||||
serde_json::from_str::<infra::JellyfinConfig>(&row.config_json)
|
||||
{
|
||||
new_registry.register(
|
||||
"jellyfin",
|
||||
&row.id,
|
||||
Arc::new(infra::JellyfinMediaProvider::new(cfg)),
|
||||
);
|
||||
}
|
||||
@@ -144,16 +172,19 @@ async fn rebuild_registry(state: &AppState) -> DomainResult<()> {
|
||||
transcode_dir,
|
||||
cleanup_ttl_hours,
|
||||
base_url,
|
||||
&row.id,
|
||||
).await {
|
||||
Ok(bundle) => {
|
||||
let scan_idx = Arc::clone(&bundle.local_index);
|
||||
tokio::spawn(async move { scan_idx.rescan().await; });
|
||||
new_registry.register("local", bundle.provider);
|
||||
*state.local_index.write().await = Some(bundle.local_index);
|
||||
*state.transcode_manager.write().await = bundle.transcode_manager;
|
||||
new_registry.register(&row.id, bundle.provider);
|
||||
new_local_index.insert(row.id.clone(), bundle.local_index);
|
||||
if first_transcode_manager.is_none() {
|
||||
first_transcode_manager = bundle.transcode_manager;
|
||||
}
|
||||
}
|
||||
Err(e) => {
|
||||
tracing::warn!("local_files provider requires SQLite; skipping: {}", e);
|
||||
tracing::warn!("local_files provider [{}] requires SQLite; skipping: {}", row.id, e);
|
||||
continue;
|
||||
}
|
||||
}
|
||||
@@ -167,6 +198,11 @@ async fn rebuild_registry(state: &AppState) -> DomainResult<()> {
|
||||
}
|
||||
|
||||
*state.provider_registry.write().await = Arc::new(new_registry);
|
||||
#[cfg(feature = "local-files")]
|
||||
{
|
||||
*state.local_index.write().await = new_local_index;
|
||||
*state.transcode_manager.write().await = first_transcode_manager;
|
||||
}
|
||||
Ok(())
|
||||
}
|
||||
|
||||
@@ -187,6 +223,7 @@ pub async fn list_providers(
|
||||
let response: Vec<ProviderConfigResponse> = rows
|
||||
.iter()
|
||||
.map(|row| ProviderConfigResponse {
|
||||
id: row.id.clone(),
|
||||
provider_type: row.provider_type.clone(),
|
||||
config_json: mask_config(&row.config_json),
|
||||
enabled: row.enabled,
|
||||
@@ -196,29 +233,49 @@ pub async fn list_providers(
|
||||
Ok(Json(response))
|
||||
}
|
||||
|
||||
pub async fn update_provider(
|
||||
pub async fn create_provider(
|
||||
State(state): State<AppState>,
|
||||
AdminUser(_user): AdminUser,
|
||||
Path(provider_type): Path<String>,
|
||||
Json(payload): Json<ProviderConfigPayload>,
|
||||
Json(payload): Json<CreateProviderRequest>,
|
||||
) -> Result<impl IntoResponse, ApiError> {
|
||||
if state.config.config_source != ConfigSource::Db {
|
||||
return Ok(conflict_response().into_response());
|
||||
}
|
||||
|
||||
let known = matches!(provider_type.as_str(), "jellyfin" | "local_files");
|
||||
if !is_valid_instance_id(&payload.id) {
|
||||
return Err(ApiError::Validation(
|
||||
"Instance id must be 1-40 alphanumeric+hyphen characters".to_string(),
|
||||
));
|
||||
}
|
||||
|
||||
let known = matches!(payload.provider_type.as_str(), "jellyfin" | "local_files");
|
||||
if !known {
|
||||
return Err(ApiError::Validation(format!(
|
||||
"Unknown provider type: {}",
|
||||
provider_type
|
||||
payload.provider_type
|
||||
)));
|
||||
}
|
||||
|
||||
// Check for uniqueness
|
||||
if state
|
||||
.provider_config_repo
|
||||
.get_by_id(&payload.id)
|
||||
.await
|
||||
.map_err(ApiError::from)?
|
||||
.is_some()
|
||||
{
|
||||
return Ok((
|
||||
StatusCode::CONFLICT,
|
||||
Json(serde_json::json!({ "error": format!("Provider instance '{}' already exists", payload.id) })),
|
||||
).into_response());
|
||||
}
|
||||
|
||||
let config_json = serde_json::to_string(&payload.config_json)
|
||||
.map_err(|e| ApiError::Internal(format!("Failed to serialize config: {}", e)))?;
|
||||
|
||||
let row = ProviderConfigRow {
|
||||
provider_type: provider_type.clone(),
|
||||
id: payload.id.clone(),
|
||||
provider_type: payload.provider_type.clone(),
|
||||
config_json: config_json.clone(),
|
||||
enabled: payload.enabled,
|
||||
updated_at: chrono::Utc::now().to_rfc3339(),
|
||||
@@ -235,7 +292,56 @@ pub async fn update_provider(
|
||||
.map_err(ApiError::from)?;
|
||||
|
||||
let response = ProviderConfigResponse {
|
||||
provider_type,
|
||||
id: payload.id,
|
||||
provider_type: payload.provider_type,
|
||||
config_json: mask_config(&config_json),
|
||||
enabled: payload.enabled,
|
||||
};
|
||||
|
||||
Ok((StatusCode::CREATED, Json(response)).into_response())
|
||||
}
|
||||
|
||||
pub async fn update_provider(
|
||||
State(state): State<AppState>,
|
||||
AdminUser(_user): AdminUser,
|
||||
Path(instance_id): Path<String>,
|
||||
Json(payload): Json<UpdateProviderRequest>,
|
||||
) -> Result<impl IntoResponse, ApiError> {
|
||||
if state.config.config_source != ConfigSource::Db {
|
||||
return Ok(conflict_response().into_response());
|
||||
}
|
||||
|
||||
let existing = state
|
||||
.provider_config_repo
|
||||
.get_by_id(&instance_id)
|
||||
.await
|
||||
.map_err(ApiError::from)?
|
||||
.ok_or_else(|| ApiError::NotFound(format!("Provider instance '{}' not found", instance_id)))?;
|
||||
|
||||
let config_json = serde_json::to_string(&payload.config_json)
|
||||
.map_err(|e| ApiError::Internal(format!("Failed to serialize config: {}", e)))?;
|
||||
|
||||
let row = ProviderConfigRow {
|
||||
id: existing.id.clone(),
|
||||
provider_type: existing.provider_type.clone(),
|
||||
config_json: config_json.clone(),
|
||||
enabled: payload.enabled,
|
||||
updated_at: chrono::Utc::now().to_rfc3339(),
|
||||
};
|
||||
|
||||
state
|
||||
.provider_config_repo
|
||||
.upsert(&row)
|
||||
.await
|
||||
.map_err(ApiError::from)?;
|
||||
|
||||
rebuild_registry(&state)
|
||||
.await
|
||||
.map_err(ApiError::from)?;
|
||||
|
||||
let response = ProviderConfigResponse {
|
||||
id: existing.id,
|
||||
provider_type: existing.provider_type,
|
||||
config_json: mask_config(&config_json),
|
||||
enabled: payload.enabled,
|
||||
};
|
||||
@@ -246,7 +352,7 @@ pub async fn update_provider(
|
||||
pub async fn delete_provider(
|
||||
State(state): State<AppState>,
|
||||
AdminUser(_user): AdminUser,
|
||||
Path(provider_type): Path<String>,
|
||||
Path(instance_id): Path<String>,
|
||||
) -> Result<impl IntoResponse, ApiError> {
|
||||
if state.config.config_source != ConfigSource::Db {
|
||||
return Ok(conflict_response().into_response());
|
||||
@@ -254,7 +360,7 @@ pub async fn delete_provider(
|
||||
|
||||
state
|
||||
.provider_config_repo
|
||||
.delete(&provider_type)
|
||||
.delete(&instance_id)
|
||||
.await
|
||||
.map_err(ApiError::from)?;
|
||||
|
||||
@@ -268,10 +374,9 @@ pub async fn delete_provider(
|
||||
pub async fn test_provider(
|
||||
State(_state): State<AppState>,
|
||||
AdminUser(_user): AdminUser,
|
||||
Path(provider_type): Path<String>,
|
||||
Json(payload): Json<ProviderConfigPayload>,
|
||||
Json(payload): Json<TestProviderRequest>,
|
||||
) -> Result<impl IntoResponse, ApiError> {
|
||||
let result = match provider_type.as_str() {
|
||||
let result = match payload.provider_type.as_str() {
|
||||
"jellyfin" => test_jellyfin(&payload.config_json).await,
|
||||
"local_files" => test_local_files(&payload.config_json),
|
||||
_ => TestResult {
|
||||
|
||||
@@ -22,6 +22,7 @@ use crate::{error::ApiError, state::AppState};
|
||||
#[cfg(feature = "local-files")]
|
||||
use axum::{
|
||||
Json,
|
||||
extract::Query,
|
||||
http::StatusCode,
|
||||
routing::{delete, post},
|
||||
};
|
||||
@@ -143,13 +144,25 @@ async fn stream_file(
|
||||
// Rescan
|
||||
// ============================================================================
|
||||
|
||||
#[cfg(feature = "local-files")]
|
||||
#[derive(Deserialize)]
|
||||
struct RescanQuery {
|
||||
provider: Option<String>,
|
||||
}
|
||||
|
||||
#[cfg(feature = "local-files")]
|
||||
async fn trigger_rescan(
|
||||
State(state): State<AppState>,
|
||||
CurrentUser(_user): CurrentUser,
|
||||
Query(query): Query<RescanQuery>,
|
||||
) -> Result<Json<serde_json::Value>, ApiError> {
|
||||
let index = state.local_index.read().await.clone()
|
||||
.ok_or_else(|| ApiError::not_implemented("no local files provider active"))?;
|
||||
let map = state.local_index.read().await.clone();
|
||||
let index = if let Some(id) = &query.provider {
|
||||
map.get(id).cloned()
|
||||
} else {
|
||||
map.values().next().cloned()
|
||||
};
|
||||
let index = index.ok_or_else(|| ApiError::not_implemented("no local files provider active"))?;
|
||||
let count = index.rescan().await;
|
||||
Ok(Json(serde_json::json!({ "items_found": count })))
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user