GKaszewski/k-tv
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Magic numbers in schedule logic #24

New Issue
Open
opened 2026-07-25 11:16:57 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:16:57 +00:00
Owner
Copy Link

Severity: Low

  • crates/domain/src/services/schedule/mod.rs has .with_limit(10_000) hardcoded inline in media_filter_to_library_search. Should be a named constant or configurable.
  • crates/domain/src/services/schedule/fill.rs has if idx > ordered.len() * 100 { break; } — an undocumented safety valve with a magic multiplier.

Extract these into named constants with comments explaining the rationale.

**Severity: Low** - `crates/domain/src/services/schedule/mod.rs` has `.with_limit(10_000)` hardcoded inline in `media_filter_to_library_search`. Should be a named constant or configurable. - `crates/domain/src/services/schedule/fill.rs` has `if idx > ordered.len() * 100 { break; }` — an undocumented safety valve with a magic multiplier. Extract these into named constants with comments explaining the rationale.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
needs-triage
Maintainer needs to evaluate this issue
 prd
Product Requirements Document
 ready-for-agent
Fully specified, ready for an AFK agent
 ready-for-human
Requires human implementation
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/k-tv#24
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?