GKaszewski/libertas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Enhance error handling by adding Forbidden and Unknown error types

Browse Source
This commit is contained in:
Gabriel Kaszewski
2025-11-15 17:29:58 +01:00
parent a9805b5eb1
commit 3f96de117b
3 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libertas_api/src/error.rs
View File

@@ -22,6 +22,11 @@ impl IntoResponse for ApiError {
), ),
CoreError::Duplicate(e) => (StatusCode::CONFLICT, e), CoreError::Duplicate(e) => (StatusCode::CONFLICT, e),
CoreError::Auth(e) => (StatusCode::UNAUTHORIZED, e), CoreError::Auth(e) => (StatusCode::UNAUTHORIZED, e),
CoreError::Forbidden(e) => (StatusCode::FORBIDDEN, e),
CoreError::Unknown(e) => (
StatusCode::INTERNAL_SERVER_ERROR,
format!("An unknown error occurred: {}", e),
),
_ => ( _ => (
StatusCode::INTERNAL_SERVER_ERROR, StatusCode::INTERNAL_SERVER_ERROR,
"An unknown error occurred".to_string(), "An unknown error occurred".to_string(),

26
libertas_api/src/services/authorization_service.rs
View File

@@ -149,9 +149,15 @@ impl AuthorizationService for AuthorizationServiceImpl {
} }
} }
Err(CoreError::Auth( if user_id.is_some() {
return Err(CoreError::Forbidden(
"User does not have permission to view this media.".into(), "User does not have permission to view this media.".into(),
)) ));
} else {
return Err(CoreError::Auth(
"Authentication required for this action".into(),
));
}
} }
Permission::DeleteMedia(media_id) | Permission::EditMedia(media_id) => { Permission::DeleteMedia(media_id) | Permission::EditMedia(media_id) => {
@@ -163,7 +169,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to modify this media.".into(), "User does not have permission to modify this media.".into(),
)) ))
} }
@@ -189,7 +195,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to modify tags for this media.".into(), "User does not have permission to modify tags for this media.".into(),
)) ))
} }
@@ -206,7 +212,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to view this album.".into(), "User does not have permission to view this album.".into(),
)) ))
} }
@@ -222,7 +228,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to modify this album.".into(), "User does not have permission to modify this album.".into(),
)) ))
} }
@@ -237,7 +243,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to share or delete this album.".into(), "User does not have permission to share or delete this album.".into(),
)) ))
} }
@@ -253,7 +259,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to view this person.".into(), "User does not have permission to view this person.".into(),
)) ))
} }
@@ -270,7 +276,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to modify this person.".into(), "User does not have permission to modify this person.".into(),
)) ))
} }
@@ -286,7 +292,7 @@ impl AuthorizationService for AuthorizationServiceImpl {
return Ok(()); return Ok(());
} }
Err(CoreError::Auth( Err(CoreError::Forbidden(
"User does not have permission to use this person.".into(), "User does not have permission to use this person.".into(),
)) ))
} }

3
libertas_core/src/error.rs
View File

@@ -23,6 +23,9 @@ pub enum CoreError {
#[error("Authentication failed: {0}")] #[error("Authentication failed: {0}")]
Auth(String), Auth(String),
#[error("Forbidden: {0}")]
Forbidden(String),
#[error("An unknown error occurred: {0}")] #[error("An unknown error occurred: {0}")]
Unknown(String), Unknown(String),
} }