feat: add user roles and storage quota management
This commit is contained in:
@@ -0,0 +1,4 @@
|
|||||||
|
ALTER TABLE users
|
||||||
|
ADD COLUMN role TEXT NOT NULL DEFAULT 'user',
|
||||||
|
ADD COLUMN storage_quota BIGINT NOT NULL DEFAULT 10737418240, -- 10 GiB default
|
||||||
|
ADD COLUMN storage_used BIGINT NOT NULL DEFAULT 0;
|
||||||
@@ -32,9 +32,14 @@ pub async fn build_app_state(config: Config) -> CoreResult<AppState> {
|
|||||||
let hasher = Arc::new(Argon2Hasher::default());
|
let hasher = Arc::new(Argon2Hasher::default());
|
||||||
let tokenizer = Arc::new(JwtGenerator::new(config.jwt_secret.clone()));
|
let tokenizer = Arc::new(JwtGenerator::new(config.jwt_secret.clone()));
|
||||||
|
|
||||||
let user_service = Arc::new(UserServiceImpl::new(user_repo, hasher, tokenizer.clone()));
|
let user_service = Arc::new(UserServiceImpl::new(
|
||||||
|
user_repo.clone(),
|
||||||
|
hasher,
|
||||||
|
tokenizer.clone(),
|
||||||
|
));
|
||||||
let media_service = Arc::new(MediaServiceImpl::new(
|
let media_service = Arc::new(MediaServiceImpl::new(
|
||||||
media_repo.clone(),
|
media_repo.clone(),
|
||||||
|
user_repo.clone(),
|
||||||
config.clone(),
|
config.clone(),
|
||||||
nats_client.clone(),
|
nats_client.clone(),
|
||||||
));
|
));
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ use std::sync::Arc;
|
|||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
use chrono::Utc;
|
use chrono::Utc;
|
||||||
use libertas_core::{
|
use libertas_core::{
|
||||||
|
authz,
|
||||||
error::{CoreError, CoreResult},
|
error::{CoreError, CoreResult},
|
||||||
models::Album,
|
models::Album,
|
||||||
repositories::{AlbumRepository, MediaRepository},
|
repositories::{AlbumRepository, MediaRepository},
|
||||||
@@ -65,9 +66,7 @@ impl AlbumService for AlbumServiceImpl {
|
|||||||
.await?
|
.await?
|
||||||
.ok_or(CoreError::NotFound("Album".to_string(), album_id))?;
|
.ok_or(CoreError::NotFound("Album".to_string(), album_id))?;
|
||||||
|
|
||||||
// Security check: Only owner (for now) can see album details
|
if !authz::is_owner(user_id, &album) {
|
||||||
if album.owner_id != user_id {
|
|
||||||
// Later, this would also check share permissions
|
|
||||||
return Err(CoreError::Auth("Access denied to album".to_string()));
|
return Err(CoreError::Auth("Access denied to album".to_string()));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -75,12 +74,16 @@ impl AlbumService for AlbumServiceImpl {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async fn add_media_to_album(&self, data: AddMediaToAlbumData, user_id: Uuid) -> CoreResult<()> {
|
async fn add_media_to_album(&self, data: AddMediaToAlbumData, user_id: Uuid) -> CoreResult<()> {
|
||||||
// 1. Verify the user owns the album
|
let album = self
|
||||||
if !self.is_album_owner(user_id, data.album_id).await? {
|
.album_repo
|
||||||
|
.find_by_id(data.album_id)
|
||||||
|
.await?
|
||||||
|
.ok_or(CoreError::NotFound("Album".to_string(), data.album_id))?;
|
||||||
|
|
||||||
|
if !authz::is_owner(user_id, &album) {
|
||||||
return Err(CoreError::Auth("User does not own this album".to_string()));
|
return Err(CoreError::Auth("User does not own this album".to_string()));
|
||||||
}
|
}
|
||||||
|
|
||||||
// 2. Bonus: Verify the user owns all media items
|
|
||||||
for media_id in &data.media_ids {
|
for media_id in &data.media_ids {
|
||||||
let media = self
|
let media = self
|
||||||
.media_repo
|
.media_repo
|
||||||
@@ -88,7 +91,7 @@ impl AlbumService for AlbumServiceImpl {
|
|||||||
.await?
|
.await?
|
||||||
.ok_or(CoreError::NotFound("Media".to_string(), *media_id))?;
|
.ok_or(CoreError::NotFound("Media".to_string(), *media_id))?;
|
||||||
|
|
||||||
if media.owner_id != user_id {
|
if !authz::is_owner(user_id, &media) {
|
||||||
return Err(CoreError::Auth(format!(
|
return Err(CoreError::Auth(format!(
|
||||||
"Access denied to media item {}",
|
"Access denied to media item {}",
|
||||||
media_id
|
media_id
|
||||||
@@ -96,7 +99,6 @@ impl AlbumService for AlbumServiceImpl {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// 3. Call the repository to add them
|
|
||||||
self.album_repo
|
self.album_repo
|
||||||
.add_media_to_album(data.album_id, &data.media_ids)
|
.add_media_to_album(data.album_id, &data.media_ids)
|
||||||
.await
|
.await
|
||||||
|
|||||||
@@ -4,10 +4,11 @@ use async_trait::async_trait;
|
|||||||
use chrono::Datelike;
|
use chrono::Datelike;
|
||||||
use futures::stream::StreamExt;
|
use futures::stream::StreamExt;
|
||||||
use libertas_core::{
|
use libertas_core::{
|
||||||
|
authz,
|
||||||
config::Config,
|
config::Config,
|
||||||
error::{CoreError, CoreResult},
|
error::{CoreError, CoreResult},
|
||||||
models::Media,
|
models::Media,
|
||||||
repositories::MediaRepository,
|
repositories::{MediaRepository, UserRepository},
|
||||||
schema::UploadMediaData,
|
schema::UploadMediaData,
|
||||||
services::MediaService,
|
services::MediaService,
|
||||||
};
|
};
|
||||||
@@ -18,6 +19,7 @@ use uuid::Uuid;
|
|||||||
|
|
||||||
pub struct MediaServiceImpl {
|
pub struct MediaServiceImpl {
|
||||||
repo: Arc<dyn MediaRepository>,
|
repo: Arc<dyn MediaRepository>,
|
||||||
|
user_repo: Arc<dyn UserRepository>,
|
||||||
config: Config,
|
config: Config,
|
||||||
nats_client: async_nats::Client,
|
nats_client: async_nats::Client,
|
||||||
}
|
}
|
||||||
@@ -25,11 +27,13 @@ pub struct MediaServiceImpl {
|
|||||||
impl MediaServiceImpl {
|
impl MediaServiceImpl {
|
||||||
pub fn new(
|
pub fn new(
|
||||||
repo: Arc<dyn MediaRepository>,
|
repo: Arc<dyn MediaRepository>,
|
||||||
|
user_repo: Arc<dyn UserRepository>,
|
||||||
config: Config,
|
config: Config,
|
||||||
nats_client: async_nats::Client,
|
nats_client: async_nats::Client,
|
||||||
) -> Self {
|
) -> Self {
|
||||||
Self {
|
Self {
|
||||||
repo,
|
repo,
|
||||||
|
user_repo,
|
||||||
config,
|
config,
|
||||||
nats_client,
|
nats_client,
|
||||||
}
|
}
|
||||||
@@ -39,6 +43,12 @@ impl MediaServiceImpl {
|
|||||||
#[async_trait]
|
#[async_trait]
|
||||||
impl MediaService for MediaServiceImpl {
|
impl MediaService for MediaServiceImpl {
|
||||||
async fn upload_media(&self, mut data: UploadMediaData<'_>) -> CoreResult<Media> {
|
async fn upload_media(&self, mut data: UploadMediaData<'_>) -> CoreResult<Media> {
|
||||||
|
let user = self
|
||||||
|
.user_repo
|
||||||
|
.find_by_id(data.owner_id)
|
||||||
|
.await?
|
||||||
|
.ok_or(CoreError::NotFound("User".to_string(), data.owner_id))?;
|
||||||
|
|
||||||
let mut hasher = Sha256::new();
|
let mut hasher = Sha256::new();
|
||||||
let mut file_bytes = Vec::new();
|
let mut file_bytes = Vec::new();
|
||||||
|
|
||||||
@@ -47,6 +57,14 @@ impl MediaService for MediaServiceImpl {
|
|||||||
hasher.update(&chunk);
|
hasher.update(&chunk);
|
||||||
file_bytes.extend_from_slice(&chunk);
|
file_bytes.extend_from_slice(&chunk);
|
||||||
}
|
}
|
||||||
|
let file_size = file_bytes.len() as i64;
|
||||||
|
|
||||||
|
if user.storage_used + file_size > user.storage_quota {
|
||||||
|
return Err(CoreError::Auth(format!(
|
||||||
|
"Storage quota exceeded. Used: {}, Quota: {}",
|
||||||
|
user.storage_used, user.storage_quota
|
||||||
|
)));
|
||||||
|
}
|
||||||
|
|
||||||
let hash = format!("{:x}", hasher.finalize());
|
let hash = format!("{:x}", hasher.finalize());
|
||||||
|
|
||||||
@@ -97,6 +115,9 @@ impl MediaService for MediaServiceImpl {
|
|||||||
};
|
};
|
||||||
|
|
||||||
self.repo.create(&media_model).await?;
|
self.repo.create(&media_model).await?;
|
||||||
|
self.user_repo
|
||||||
|
.update_storage_used(user.id, file_size)
|
||||||
|
.await?;
|
||||||
|
|
||||||
let job_payload = json!({ "media_id": media_model.id });
|
let job_payload = json!({ "media_id": media_model.id });
|
||||||
self.nats_client
|
self.nats_client
|
||||||
@@ -114,7 +135,13 @@ impl MediaService for MediaServiceImpl {
|
|||||||
.await?
|
.await?
|
||||||
.ok_or(CoreError::NotFound("Media".to_string(), id))?;
|
.ok_or(CoreError::NotFound("Media".to_string(), id))?;
|
||||||
|
|
||||||
if media.owner_id != user_id {
|
let user = self
|
||||||
|
.user_repo
|
||||||
|
.find_by_id(user_id)
|
||||||
|
.await?
|
||||||
|
.ok_or(CoreError::NotFound("User".to_string(), user_id))?;
|
||||||
|
|
||||||
|
if !authz::is_owner(user_id, &media) && !authz::is_admin(&user) {
|
||||||
return Err(CoreError::Auth("Access denied".to_string()));
|
return Err(CoreError::Auth("Access denied".to_string()));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -132,7 +159,13 @@ impl MediaService for MediaServiceImpl {
|
|||||||
.await?
|
.await?
|
||||||
.ok_or(CoreError::NotFound("Media".to_string(), id))?;
|
.ok_or(CoreError::NotFound("Media".to_string(), id))?;
|
||||||
|
|
||||||
if media.owner_id != user_id {
|
let user = self
|
||||||
|
.user_repo
|
||||||
|
.find_by_id(user_id)
|
||||||
|
.await?
|
||||||
|
.ok_or(CoreError::NotFound("User".to_string(), user_id))?;
|
||||||
|
|
||||||
|
if !authz::is_owner(user_id, &media) && !authz::is_admin(&user) {
|
||||||
return Err(CoreError::Auth("Access denied".to_string()));
|
return Err(CoreError::Auth("Access denied".to_string()));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -3,7 +3,7 @@ use std::sync::Arc;
|
|||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
use libertas_core::{
|
use libertas_core::{
|
||||||
error::{CoreError, CoreResult},
|
error::{CoreError, CoreResult},
|
||||||
models::User,
|
models::{Role, User},
|
||||||
repositories::UserRepository,
|
repositories::UserRepository,
|
||||||
schema::{CreateUserData, LoginUserData},
|
schema::{CreateUserData, LoginUserData},
|
||||||
services::UserService,
|
services::UserService,
|
||||||
@@ -57,6 +57,9 @@ impl UserService for UserServiceImpl {
|
|||||||
hashed_password,
|
hashed_password,
|
||||||
created_at: chrono::Utc::now(),
|
created_at: chrono::Utc::now(),
|
||||||
updated_at: chrono::Utc::now(),
|
updated_at: chrono::Utc::now(),
|
||||||
|
role: Role::User,
|
||||||
|
storage_quota: 10 * 1024 * 1024 * 1024, // 10 GB
|
||||||
|
storage_used: 0,
|
||||||
};
|
};
|
||||||
|
|
||||||
self.repo.create(user.clone()).await?;
|
self.repo.create(user.clone()).await?;
|
||||||
|
|||||||
25
libertas_core/src/authz.rs
Normal file
25
libertas_core/src/authz.rs
Normal file
@@ -0,0 +1,25 @@
|
|||||||
|
use uuid::Uuid;
|
||||||
|
|
||||||
|
use crate::models::{Album, Media, Role, User};
|
||||||
|
|
||||||
|
pub trait Ownable {
|
||||||
|
fn owner_id(&self) -> Uuid;
|
||||||
|
}
|
||||||
|
impl Ownable for Media {
|
||||||
|
fn owner_id(&self) -> Uuid {
|
||||||
|
self.owner_id
|
||||||
|
}
|
||||||
|
}
|
||||||
|
impl Ownable for Album {
|
||||||
|
fn owner_id(&self) -> Uuid {
|
||||||
|
self.owner_id
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn is_admin(user: &User) -> bool {
|
||||||
|
user.role == Role::Admin
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn is_owner(user_id: Uuid, entity: &impl Ownable) -> bool {
|
||||||
|
user_id == entity.owner_id()
|
||||||
|
}
|
||||||
@@ -1,3 +1,4 @@
|
|||||||
|
pub mod authz;
|
||||||
pub mod config;
|
pub mod config;
|
||||||
pub mod error;
|
pub mod error;
|
||||||
pub mod models;
|
pub mod models;
|
||||||
|
|||||||
@@ -1,3 +1,20 @@
|
|||||||
|
#[derive(Debug, Clone, PartialEq, Eq, sqlx::Type)]
|
||||||
|
#[sqlx(rename_all = "lowercase")]
|
||||||
|
#[sqlx(type_name = "TEXT")]
|
||||||
|
pub enum Role {
|
||||||
|
User,
|
||||||
|
Admin,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Role {
|
||||||
|
pub fn as_str(&self) -> &'static str {
|
||||||
|
match self {
|
||||||
|
Role::User => "user",
|
||||||
|
Role::Admin => "admin",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
pub struct Media {
|
pub struct Media {
|
||||||
pub id: uuid::Uuid,
|
pub id: uuid::Uuid,
|
||||||
pub owner_id: uuid::Uuid,
|
pub owner_id: uuid::Uuid,
|
||||||
@@ -11,7 +28,7 @@ pub struct Media {
|
|||||||
pub height: Option<i32>,
|
pub height: Option<i32>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Clone)]
|
#[derive(Clone, sqlx::FromRow)]
|
||||||
pub struct User {
|
pub struct User {
|
||||||
pub id: uuid::Uuid,
|
pub id: uuid::Uuid,
|
||||||
pub username: String,
|
pub username: String,
|
||||||
@@ -19,6 +36,10 @@ pub struct User {
|
|||||||
pub hashed_password: String,
|
pub hashed_password: String,
|
||||||
pub created_at: chrono::DateTime<chrono::Utc>,
|
pub created_at: chrono::DateTime<chrono::Utc>,
|
||||||
pub updated_at: chrono::DateTime<chrono::Utc>,
|
pub updated_at: chrono::DateTime<chrono::Utc>,
|
||||||
|
|
||||||
|
pub role: Role,
|
||||||
|
pub storage_quota: i64, // in bytes
|
||||||
|
pub storage_used: i64, // in bytes
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct Album {
|
pub struct Album {
|
||||||
|
|||||||
@@ -27,6 +27,7 @@ pub trait UserRepository: Send + Sync {
|
|||||||
async fn find_by_email(&self, email: &str) -> CoreResult<Option<User>>;
|
async fn find_by_email(&self, email: &str) -> CoreResult<Option<User>>;
|
||||||
async fn find_by_username(&self, username: &str) -> CoreResult<Option<User>>;
|
async fn find_by_username(&self, username: &str) -> CoreResult<Option<User>>;
|
||||||
async fn find_by_id(&self, id: Uuid) -> CoreResult<Option<User>>;
|
async fn find_by_id(&self, id: Uuid) -> CoreResult<Option<User>>;
|
||||||
|
async fn update_storage_used(&self, user_id: Uuid, bytes: i64) -> CoreResult<()>;
|
||||||
}
|
}
|
||||||
|
|
||||||
#[async_trait]
|
#[async_trait]
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
use libertas_core::{
|
use libertas_core::{
|
||||||
error::{CoreError, CoreResult},
|
error::{CoreError, CoreResult},
|
||||||
models::User,
|
models::{Role, User},
|
||||||
repositories::UserRepository,
|
repositories::UserRepository,
|
||||||
};
|
};
|
||||||
use sqlx::{PgPool, SqlitePool, types::Uuid};
|
use sqlx::{PgPool, SqlitePool, types::Uuid};
|
||||||
@@ -33,15 +33,18 @@ impl UserRepository for PostgresUserRepository {
|
|||||||
async fn create(&self, user: User) -> CoreResult<()> {
|
async fn create(&self, user: User) -> CoreResult<()> {
|
||||||
sqlx::query!(
|
sqlx::query!(
|
||||||
r#"
|
r#"
|
||||||
INSERT INTO users (id, username, email, hashed_password, created_at, updated_at)
|
INSERT INTO users (id, username, email, hashed_password, created_at, updated_at, role, storage_quota, storage_used)
|
||||||
VALUES ($1, $2, $3, $4, $5, $6)
|
VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9)
|
||||||
"#,
|
"#,
|
||||||
user.id,
|
user.id,
|
||||||
user.username,
|
user.username,
|
||||||
user.email,
|
user.email,
|
||||||
user.hashed_password,
|
user.hashed_password,
|
||||||
user.created_at,
|
user.created_at,
|
||||||
user.updated_at
|
user.updated_at,
|
||||||
|
user.role.as_str(),
|
||||||
|
user.storage_quota,
|
||||||
|
user.storage_used
|
||||||
)
|
)
|
||||||
.execute(&self.pool)
|
.execute(&self.pool)
|
||||||
.await
|
.await
|
||||||
@@ -51,24 +54,74 @@ impl UserRepository for PostgresUserRepository {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async fn find_by_email(&self, email: &str) -> CoreResult<Option<User>> {
|
async fn find_by_email(&self, email: &str) -> CoreResult<Option<User>> {
|
||||||
sqlx::query_as!(User, "SELECT * FROM users WHERE email = $1", email)
|
sqlx::query_as!(
|
||||||
.fetch_optional(&self.pool)
|
User,
|
||||||
.await
|
r#"
|
||||||
.map_err(|e| CoreError::Database(e.to_string()))
|
SELECT
|
||||||
|
id, username, email, hashed_password, created_at, updated_at,
|
||||||
|
role as "role: Role",
|
||||||
|
storage_quota, storage_used
|
||||||
|
FROM users
|
||||||
|
WHERE email = $1
|
||||||
|
"#,
|
||||||
|
email
|
||||||
|
)
|
||||||
|
.fetch_optional(&self.pool)
|
||||||
|
.await
|
||||||
|
.map_err(|e| CoreError::Database(e.to_string()))
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn find_by_username(&self, username: &str) -> CoreResult<Option<User>> {
|
async fn find_by_username(&self, username: &str) -> CoreResult<Option<User>> {
|
||||||
sqlx::query_as!(User, "SELECT * FROM users WHERE username = $1", username)
|
sqlx::query_as!(
|
||||||
.fetch_optional(&self.pool)
|
User,
|
||||||
.await
|
r#"
|
||||||
.map_err(|e| CoreError::Database(e.to_string()))
|
SELECT
|
||||||
|
id, username, email, hashed_password, created_at, updated_at,
|
||||||
|
role as "role: Role",
|
||||||
|
storage_quota, storage_used
|
||||||
|
FROM users
|
||||||
|
WHERE username = $1
|
||||||
|
"#,
|
||||||
|
username
|
||||||
|
)
|
||||||
|
.fetch_optional(&self.pool)
|
||||||
|
.await
|
||||||
|
.map_err(|e| CoreError::Database(e.to_string()))
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn find_by_id(&self, id: Uuid) -> CoreResult<Option<User>> {
|
async fn find_by_id(&self, id: Uuid) -> CoreResult<Option<User>> {
|
||||||
sqlx::query_as!(User, "SELECT * FROM users WHERE id = $1", id)
|
sqlx::query_as!(
|
||||||
.fetch_optional(&self.pool)
|
User,
|
||||||
.await
|
r#"
|
||||||
.map_err(|e| CoreError::Database(e.to_string()))
|
SELECT
|
||||||
|
id, username, email, hashed_password, created_at, updated_at,
|
||||||
|
role as "role: Role",
|
||||||
|
storage_quota, storage_used
|
||||||
|
FROM users
|
||||||
|
WHERE id = $1
|
||||||
|
"#,
|
||||||
|
id
|
||||||
|
)
|
||||||
|
.fetch_optional(&self.pool)
|
||||||
|
.await
|
||||||
|
.map_err(|e| CoreError::Database(e.to_string()))
|
||||||
|
}
|
||||||
|
|
||||||
|
async fn update_storage_used(&self, user_id: Uuid, bytes: i64) -> CoreResult<()> {
|
||||||
|
sqlx::query!(
|
||||||
|
r#"
|
||||||
|
UPDATE users
|
||||||
|
SET storage_used = storage_used + $1, updated_at = NOW()
|
||||||
|
WHERE id = $2
|
||||||
|
"#,
|
||||||
|
bytes,
|
||||||
|
user_id
|
||||||
|
)
|
||||||
|
.execute(&self.pool)
|
||||||
|
.await
|
||||||
|
.map_err(|e| CoreError::Database(e.to_string()))?;
|
||||||
|
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -93,4 +146,9 @@ impl UserRepository for SqliteUserRepository {
|
|||||||
println!("SQLITE REPO: Finding user by id");
|
println!("SQLITE REPO: Finding user by id");
|
||||||
Ok(None)
|
Ok(None)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn update_storage_used(&self, _user_id: Uuid, _bytes: i64) -> CoreResult<()> {
|
||||||
|
println!("SQLITE REPO: Updating user storage used");
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user