GKaszewski/loco-keycloak-auth
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

Add test suite for authentication library #1

New Issue
Open
opened 2026-07-25 11:16:23 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:16:23 +00:00
Owner
Copy Link

Severity: Critical

This is a security-critical authentication library published on crates.io with zero test coverage. The README acknowledges this ("Run tests if there are any").

Minimum tests needed:

  • Unit test for PassthroughModeDef deserialization (valid "Block", valid "Pass", invalid "Foo")
  • Unit test for Settings struct deserialization from a sample JSON/YAML
  • Integration test for build_keycloak_layer with a mock AppContext
  • Test that invalid/missing Keycloak config produces proper errors, not panics
**Severity: Critical** This is a security-critical authentication library published on crates.io with zero test coverage. The README acknowledges this ("Run tests if there are any"). Minimum tests needed: - Unit test for `PassthroughModeDef` deserialization (valid "Block", valid "Pass", invalid "Foo") - Unit test for `Settings` struct deserialization from a sample JSON/YAML - Integration test for `build_keycloak_layer` with a mock `AppContext` - Test that invalid/missing Keycloak config produces proper errors, not panics
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/loco-keycloak-auth#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?