ADR-0003: local follows bypass AP, unified FollowCommand/FollowQuery ports, FederationRepos struct, base_url normalization

crates/presentation/src/handlers/diary.rs

@@ -312,8 +312,7 @@ pub async fn get_activity_feed_html(
     let limit = params.limit.unwrap_or(20);
     let offset = params.offset.unwrap_or(0);
 
-    let filter_following =
-        cfg!(feature = "federation") && params.filter == "following" && user_id.is_some();
+    let filter_following = params.filter == "following" && user_id.is_some();
     let filter_str = if filter_following { "following" } else { "all" };
 
     let sort_by_str = match params.sort_by.as_str() {

crates/presentation/src/handlers/social.rs

@@ -189,9 +189,7 @@ pub async fn block_actor_api(
         &deps,
         application::social::commands::SocialCmd::Block {
             blocker_id: user.0.value(),
-            target: SocialIdentity::Remote {
-                actor_url: body.actor_url,
-            },
+            target: SocialIdentity::from_actor_url(&body.actor_url, &state.app_ctx.config.base_url),
         },
     )
     .await?;
@@ -217,9 +215,7 @@ pub async fn unblock_actor_api(
         &deps,
         application::social::commands::SocialCmd::Unblock {
             blocker_id: user.0.value(),
-            target: SocialIdentity::Remote {
-                actor_url: body.actor_url,
-            },
+            target: SocialIdentity::from_actor_url(&body.actor_url, &state.app_ctx.config.base_url),
         },
     )
     .await?;
@@ -381,9 +377,7 @@ pub async fn unfollow(
         &deps,
         application::social::commands::SocialCmd::Unfollow {
             follower_id: user.0.value(),
-            target: SocialIdentity::Remote {
-                actor_url: body.actor_url,
-            },
+            target: SocialIdentity::from_actor_url(&body.actor_url, &state.app_ctx.config.base_url),
         },
     )
     .await?;
@@ -409,9 +403,10 @@ pub async fn accept_follower(
         &deps,
         application::social::commands::SocialCmd::AcceptFollow {
             owner_id: user.0.value(),
-            requester: SocialIdentity::Remote {
-                actor_url: body.actor_url,
-            },
+            requester: SocialIdentity::from_actor_url(
+                &body.actor_url,
+                &state.app_ctx.config.base_url,
+            ),
         },
     )
     .await?;
@@ -437,9 +432,10 @@ pub async fn reject_follower(
         &deps,
         application::social::commands::SocialCmd::RejectFollow {
             owner_id: user.0.value(),
-            requester: SocialIdentity::Remote {
-                actor_url: body.actor_url,
-            },
+            requester: SocialIdentity::from_actor_url(
+                &body.actor_url,
+                &state.app_ctx.config.base_url,
+            ),
         },
     )
     .await?;
@@ -465,9 +461,10 @@ pub async fn remove_follower(
         &deps,
         application::social::commands::SocialCmd::RemoveFollower {
             owner_id: user.0.value(),
-            follower: SocialIdentity::Remote {
-                actor_url: body.actor_url,
-            },
+            follower: SocialIdentity::from_actor_url(
+                &body.actor_url,
+                &state.app_ctx.config.base_url,
+            ),
         },
     )
     .await?;
@@ -563,9 +560,7 @@ pub async fn unfollow_remote_user(
         &deps,
         application::social::commands::SocialCmd::Unfollow {
             follower_id: user_id.value(),
-            target: SocialIdentity::Remote {
-                actor_url: form.actor_url,
-            },
+            target: SocialIdentity::from_actor_url(&form.actor_url, &state.app_ctx.config.base_url),
         },
     )
     .await
@@ -602,9 +597,10 @@ pub async fn accept_follower_html(
         &deps,
         application::social::commands::SocialCmd::AcceptFollow {
             owner_id: user_id.value(),
-            requester: SocialIdentity::Remote {
-                actor_url: form.actor_url,
-            },
+            requester: SocialIdentity::from_actor_url(
+                &form.actor_url,
+                &state.app_ctx.config.base_url,
+            ),
         },
     )
     .await
@@ -635,9 +631,10 @@ pub async fn reject_follower_html(
         &deps,
         application::social::commands::SocialCmd::RejectFollow {
             owner_id: user_id.value(),
-            requester: SocialIdentity::Remote {
-                actor_url: form.actor_url,
-            },
+            requester: SocialIdentity::from_actor_url(
+                &form.actor_url,
+                &state.app_ctx.config.base_url,
+            ),
         },
     )
     .await
@@ -832,9 +829,10 @@ pub async fn remove_follower_html(
         &deps,
         application::social::commands::SocialCmd::RemoveFollower {
             owner_id: user_id.value(),
-            follower: SocialIdentity::Remote {
-                actor_url: form.actor_url,
-            },
+            follower: SocialIdentity::from_actor_url(
+                &form.actor_url,
+                &state.app_ctx.config.base_url,
+            ),
         },
     )
     .await
@@ -1001,9 +999,7 @@ pub async fn post_block_actor_html(
         &deps,
         application::social::commands::SocialCmd::Block {
             blocker_id: user_id.value(),
-            target: SocialIdentity::Remote {
-                actor_url: form.actor_url,
-            },
+            target: SocialIdentity::from_actor_url(&form.actor_url, &state.app_ctx.config.base_url),
         },
     )
     .await
@@ -1030,9 +1026,7 @@ pub async fn post_unblock_actor(
         &deps,
         application::social::commands::SocialCmd::Unblock {
             blocker_id: user_id.value(),
-            target: SocialIdentity::Remote {
-                actor_url: form.actor_url,
-            },
+            target: SocialIdentity::from_actor_url(&form.actor_url, &state.app_ctx.config.base_url),
         },
     )
     .await

crates/presentation/src/main.rs

@@ -75,15 +75,7 @@ async fn wire_dependencies() -> anyhow::Result<(AppState, axum::Router)> {
         social_command_arc,
         social_query_unified_arc,
     ) = {
-        let (
-            activity_repo,
-            follow_repo,
-            actor_repo,
-            blocklist_repo,
-            social_query_arc,
-            review_store,
-            remote_watchlist_repo,
-        ) = match &db_pool {
+        let fed_repos = match &db_pool {
             #[cfg(feature = "postgres-federation")]
             factory::DbPool::Postgres(pool) => postgres_federation::wire(pool.clone()),
             #[cfg(feature = "sqlite-federation")]
@@ -97,12 +89,12 @@ async fn wire_dependencies() -> anyhow::Result<(AppState, axum::Router)> {
         let ep = create_event_publisher(event_bus, &db_pool).await?;
 
         let ap = activitypub::wire(activitypub::ActivityPubDeps {
-            activity_repo,
-            follow_repo,
-            actor_repo,
-            blocklist_repo,
-            review_store,
-            remote_watchlist_repo: remote_watchlist_repo.clone(),
+            activity_repo: fed_repos.activity,
+            follow_repo: fed_repos.follow,
+            actor_repo: fed_repos.actor,
+            blocklist_repo: fed_repos.blocklist,
+            review_store: fed_repos.review_store,
+            remote_watchlist_repo: fed_repos.remote_watchlist.clone(),
             remote_goal_repo: Arc::clone(&db.remote_goal),
             local_ap_content: Arc::clone(&ap_content_repo),
             movie_repo: Arc::clone(&db.movie_query),
@@ -112,6 +104,8 @@ async fn wire_dependencies() -> anyhow::Result<(AppState, axum::Router)> {
             stats_repo: Arc::clone(&db.stats),
             user_repo: Arc::clone(&db.user),
             federation_settings: std::sync::Arc::clone(&db.federation_settings),
+            follow_command: Arc::clone(&fed_repos.follow_command),
+            follow_query: Arc::clone(&fed_repos.follow_query),
             base_url: app_config.base_url.clone(),
             allow_registration: app_config.allow_registration,
             event_publisher: Arc::clone(&ep),
@@ -123,6 +117,8 @@ async fn wire_dependencies() -> anyhow::Result<(AppState, axum::Router)> {
         let composite_social = Arc::new(activitypub::CompositeSocialAdapter::new(
             Arc::clone(&ap_service_arc),
             Arc::clone(&db.user),
+            fed_repos.follow_command,
+            fed_repos.follow_query,
             app_config.base_url.clone(),
         ));
 
@@ -130,8 +126,8 @@ async fn wire_dependencies() -> anyhow::Result<(AppState, axum::Router)> {
             ep,
             ap_router,
             ap_service_arc,
-            social_query_arc,
-            remote_watchlist_repo,
+            fed_repos.admin_query,
+            fed_repos.remote_watchlist,
             composite_social.clone() as Arc<dyn domain::ports::SocialCommand>,
             composite_social as Arc<dyn domain::ports::SocialQuery>,
         )