test: cascading in-memory store

crates/application/src/diary/tests/review_logger.rs

@@ -8,10 +8,7 @@ use domain::{
     models::WatchlistEntry,
     models::{MetadataSearchCriteria, Movie},
     ports::{MetadataClient, MovieCommand, WatchlistRepository},
-    testing::{
-        FakeMetadataClient, InMemoryMovieRepository, InMemoryReviewRepository,
-        InMemoryWatchlistRepository, NoopEventPublisher,
-    },
+    testing::{FakeMetadataClient, InMemoryStore, NoopEventPublisher},
     value_objects::{ExternalMetadataId, MovieId, PosterUrl, UserId},
 };
 use uuid::Uuid;
@@ -21,9 +18,9 @@ use crate::diary::review_logger::DefaultReviewLogger;
 use crate::ports::ReviewLogger;
 
 fn make_logger(
-    movies: &Arc<InMemoryMovieRepository>,
-    reviews: &Arc<InMemoryReviewRepository>,
-    watchlist: &Arc<InMemoryWatchlistRepository>,
+    movies: &Arc<InMemoryStore>,
+    reviews: &Arc<InMemoryStore>,
+    watchlist: &Arc<InMemoryStore>,
     events: &Arc<NoopEventPublisher>,
 ) -> DefaultReviewLogger {
     DefaultReviewLogger::new(
@@ -38,9 +35,9 @@ fn make_logger(
 
 #[tokio::test]
 async fn logs_review_with_manual_movie() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
     let logger = make_logger(&movies, &reviews, &watchlist, &events);
 
@@ -49,15 +46,15 @@ async fn logs_review_with_manual_movie() {
 
     logger.log_review(cmd).await.unwrap();
 
-    assert_eq!(movies.count(), 1);
-    assert_eq!(reviews.count(), 1);
+    assert_eq!(movies.movie_count(), 1);
+    assert_eq!(reviews.review_count(), 1);
 }
 
 #[tokio::test]
 async fn removes_from_watchlist_on_review() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
     let logger = make_logger(&movies, &reviews, &watchlist, &events);
 
@@ -72,7 +69,7 @@ async fn removes_from_watchlist_on_review() {
     // Add to watchlist
     let entry = WatchlistEntry::new(user_id.clone(), MovieId::from_uuid(movie_id));
     watchlist.add(&entry).await.unwrap();
-    assert_eq!(watchlist.count(), 1);
+    assert_eq!(watchlist.watchlist_count(), 1);
 
     // Log review for same movie
     let cmd = LogReviewCommand {
@@ -82,14 +79,14 @@ async fn removes_from_watchlist_on_review() {
 
     logger.log_review(cmd).await.unwrap();
 
-    assert_eq!(watchlist.count(), 0);
+    assert_eq!(watchlist.watchlist_count(), 0);
 }
 
 #[tokio::test]
 async fn logs_review_with_existing_movie_by_id() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
     let logger = make_logger(&movies, &reviews, &watchlist, &events);
 
@@ -104,15 +101,15 @@ async fn logs_review_with_existing_movie_by_id() {
 
     logger.log_review(cmd).await.unwrap();
 
-    assert_eq!(movies.count(), 1);
-    assert_eq!(reviews.count(), 1);
+    assert_eq!(movies.movie_count(), 1);
+    assert_eq!(reviews.review_count(), 1);
 }
 
 #[tokio::test]
 async fn existing_movie_not_found_returns_error() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
     let logger = make_logger(&movies, &reviews, &watchlist, &events);
 
@@ -123,9 +120,9 @@ async fn existing_movie_not_found_returns_error() {
 
 #[tokio::test]
 async fn invalid_rating_returns_error() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
     let logger = make_logger(&movies, &reviews, &watchlist, &events);
 
@@ -137,15 +134,15 @@ async fn invalid_rating_returns_error() {
     let result = logger.log_review(cmd).await;
     assert!(result.is_err());
     // No repo calls should have happened
-    assert_eq!(movies.count(), 0);
-    assert_eq!(reviews.count(), 0);
+    assert_eq!(movies.movie_count(), 0);
+    assert_eq!(reviews.review_count(), 0);
 }
 
 #[tokio::test]
 async fn watchlist_not_present_does_not_publish_removed() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
     let logger = make_logger(&movies, &reviews, &watchlist, &events);
 
@@ -187,9 +184,9 @@ impl MetadataClient for MetadataClientWithExternalId {
 
 #[tokio::test]
 async fn publishes_movie_discovered_for_new_movie_with_external_id() {
-    let movies = InMemoryMovieRepository::new();
-    let reviews = InMemoryReviewRepository::new();
-    let watchlist = InMemoryWatchlistRepository::new();
+    let movies = InMemoryStore::new();
+    let reviews = Arc::clone(&movies);
+    let watchlist = Arc::clone(&movies);
     let events = NoopEventPublisher::new();
 
     let logger = DefaultReviewLogger::new(