fix: clippy too-many-args on update_remote_review, use RemoteReviewUpdate struct

This commit is contained in:
2026-07-10 00:41:51 +02:00
parent cde2f5aaae
commit 081a20ae31
5 changed files with 43 additions and 60 deletions

View File

@@ -1,4 +1,4 @@
use activitypub::RemoteReviewRepository;
use activitypub::{RemoteReviewRepository, RemoteReviewUpdate};
use anyhow::{Result, anyhow};
use async_trait::async_trait;
use domain::models::{Review, ReviewSource};
@@ -71,37 +71,28 @@ impl RemoteReviewRepository for SqliteFederationRepository {
Ok(())
}
async fn update_remote_review(
&self,
ap_id: &str,
actor_url: &str,
rating: u8,
comment: Option<&str>,
watched_at: chrono::NaiveDateTime,
poster_url: Option<&str>,
watch_medium: Option<&str>,
) -> Result<()> {
let watched_at_str = datetime_to_str(&watched_at);
async fn update_remote_review(&self, u: RemoteReviewUpdate<'_>) -> Result<()> {
let watched_at_str = datetime_to_str(&u.watched_at);
sqlx::query(
"UPDATE reviews SET rating = ?, comment = ?, watched_at = ?, watch_medium = ?
WHERE ap_id = ? AND remote_actor_url = ?",
)
.bind(rating as i64)
.bind(comment)
.bind(u.rating as i64)
.bind(u.comment)
.bind(&watched_at_str)
.bind(watch_medium)
.bind(ap_id)
.bind(actor_url)
.bind(u.watch_medium)
.bind(u.ap_id)
.bind(u.actor_url)
.execute(&self.pool)
.await?;
if let Some(url) = poster_url {
if let Some(url) = u.poster_url {
sqlx::query(
"UPDATE movies SET poster_path = ?
WHERE id = (SELECT movie_id FROM reviews WHERE ap_id = ? AND remote_actor_url = ?)",
)
.bind(url)
.bind(ap_id)
.bind(actor_url)
.bind(u.ap_id)
.bind(u.actor_url)
.execute(&self.pool)
.await?;
}