refactor: fix HIGH+MEDIUM architectural violations from code review

HIGH: fix watch_medium data-loss bug, standardize error handling on
ApiError, fix dep direction (rss/template-askama no longer dep on
application), extract ImageFetcher port (remove reqwest from app layer),
move event construction from save_review to use case, extract
infra-wiring crate (DbPool/EventBusBackend dedup), deduplicate
presentation helpers (encode_error, export streaming, multipart parsing)

MEDIUM: split LocalApContentQuery god-trait 10→3 methods, dedup movie
resolution orchestration, add RemoteActorDto/PersonDto mappers, move
AppConfig to infra-wiring, fix SocialQueryPort Uuid→UserId, replace
stringly-typed api-types with domain enums, move count_reviews_in_year
to StatsRepository, dedup event publisher cfg blocks, extract
should_enrich, move group_by_month to application, dedup
count_local_posts, add FederationFlags Default, TUI input helper +
ShowError rename + typed auth errors, api-types cleanup
(UserSettingsDto/UserProfileBase/PreviewRowData)

102 files changed, -681 lines net
This commit is contained in:
2026-07-10 02:08:39 +02:00
parent 26152660bb
commit 12da356a40
110 changed files with 1399 additions and 1867 deletions

16
Cargo.lock generated
View File

@@ -293,6 +293,7 @@ checksum = "7f202df86484c868dbad7eaa557ef785d5c66295e41b460ef922eca0723b842c"
name = "api-types"
version = "0.1.0"
dependencies = [
"domain",
"serde",
"utoipa",
"uuid",
@@ -319,8 +320,8 @@ dependencies = [
"domain",
"futures",
"hex",
"infra-wiring",
"rand 0.9.4",
"reqwest 0.13.3",
"serde_json",
"sha2",
"tokio",
@@ -2701,6 +2702,14 @@ dependencies = [
"cfb",
]
[[package]]
name = "infra-wiring"
version = "0.1.0"
dependencies = [
"anyhow",
"sqlx",
]
[[package]]
name = "inout"
version = "0.1.4"
@@ -3982,6 +3991,7 @@ dependencies = [
"http-body-util",
"importer",
"infer",
"infra-wiring",
"jellyfin",
"metadata",
"nats",
@@ -4587,7 +4597,6 @@ dependencies = [
name = "rss"
version = "0.1.0"
dependencies = [
"application",
"domain",
"rss 2.0.13",
]
@@ -5597,7 +5606,7 @@ dependencies = [
name = "template-askama"
version = "0.1.0"
dependencies = [
"application",
"api-types",
"askama",
"chrono",
"domain",
@@ -7127,6 +7136,7 @@ dependencies = [
"export",
"image-converter",
"importer",
"infra-wiring",
"metadata",
"nats",
"object-storage",