refactor: fix HIGH+MEDIUM architectural violations from code review

HIGH: fix watch_medium data-loss bug, standardize error handling on
ApiError, fix dep direction (rss/template-askama no longer dep on
application), extract ImageFetcher port (remove reqwest from app layer),
move event construction from save_review to use case, extract
infra-wiring crate (DbPool/EventBusBackend dedup), deduplicate
presentation helpers (encode_error, export streaming, multipart parsing)

MEDIUM: split LocalApContentQuery god-trait 10→3 methods, dedup movie
resolution orchestration, add RemoteActorDto/PersonDto mappers, move
AppConfig to infra-wiring, fix SocialQueryPort Uuid→UserId, replace
stringly-typed api-types with domain enums, move count_reviews_in_year
to StatsRepository, dedup event publisher cfg blocks, extract
should_enrich, move group_by_month to application, dedup
count_local_posts, add FederationFlags Default, TUI input helper +
ShowError rename + typed auth errors, api-types cleanup
(UserSettingsDto/UserProfileBase/PreviewRowData)

102 files changed, -681 lines net

crates/application/src/users/get_current_profile.rs

@@ -17,7 +17,7 @@ pub struct CurrentProfileData {
     pub banner_path: Option<String>,
     pub also_known_as: Option<String>,
     pub fields: Vec<ProfileFieldData>,
-    pub role: String,
+    pub role: domain::models::UserRole,
 }
 
 pub async fn execute(
@@ -47,7 +47,7 @@ pub async fn execute(
         banner_path: found.banner_path().map(|s| s.to_string()),
         also_known_as: found.also_known_as().map(|s| s.to_string()),
         fields,
-        role: found.role().as_str().into(),
+        role: found.role().clone(),
     })
 }
 

crates/application/src/users/get_profile.rs

@@ -37,7 +37,7 @@ pub async fn execute(
     let stats = deps.stats.get_user_stats(&user_id).await?;
 
     let (following_count, followers_count, pending_followers) =
-        load_social_counts(deps, query.user_id, query.is_own_profile).await;
+        load_social_counts(deps, &user_id, query.is_own_profile).await;
 
     let base = |entries, history, trends| UserProfileData {
         stats,
@@ -76,7 +76,7 @@ pub async fn execute(
 
 async fn load_social_counts(
     deps: &GetProfileDeps,
-    user_id: uuid::Uuid,
+    user_id: &UserId,
     is_own_profile: bool,
 ) -> (usize, usize, Vec<PendingFollowerView>) {
     let following = deps

crates/application/src/users/mod.rs

@@ -9,3 +9,52 @@ pub mod queries;
 pub mod update_profile;
 pub mod update_profile_fields;
 pub mod update_settings;
+
+use chrono::Datelike;
+use domain::models::{DiaryEntry, MonthActivity};
+
+pub fn group_by_month(entries: Vec<DiaryEntry>) -> Vec<MonthActivity> {
+    use std::collections::BTreeMap;
+    let mut map: BTreeMap<(i32, u32), Vec<DiaryEntry>> = BTreeMap::new();
+    for entry in entries {
+        let watched_at = entry.review().watched_at();
+        let year = watched_at.year();
+        let month = watched_at.month();
+        map.entry((year, month)).or_default().push(entry);
+    }
+    map.into_iter()
+        .rev()
+        .map(|((year, month), entries)| {
+            let year_month = format!("{:04}-{:02}", year, month);
+            MonthActivity {
+                month_label: format_year_month_long(&year_month),
+                count: entries.len() as i64,
+                entries,
+                year_month,
+            }
+        })
+        .collect()
+}
+
+fn format_year_month_long(ym: &str) -> String {
+    let parts: Vec<&str> = ym.splitn(2, '-').collect();
+    if parts.len() != 2 {
+        return ym.to_string();
+    }
+    let month = match parts[1] {
+        "01" => "January",
+        "02" => "February",
+        "03" => "March",
+        "04" => "April",
+        "05" => "May",
+        "06" => "June",
+        "07" => "July",
+        "08" => "August",
+        "09" => "September",
+        "10" => "October",
+        "11" => "November",
+        "12" => "December",
+        _ => parts[1],
+    };
+    format!("{} {}", month, parts[0])
+}