From 21cc6ed437edbb89c4c39ba3fb223304edf095b0 Mon Sep 17 00:00:00 2001
From: Gabriel Kaszewski <gabrielkaszewski@gmail.com>
Date: Thu, 11 Jun 2026 12:59:13 +0200
Subject: [PATCH] fix: move useDocumentTitle before early returns (Rules of
 Hooks)

---
 spa/src/routes/_app/movies.$id.tsx | 2 +-
 spa/src/routes/_app/people.$id.tsx | 2 +-
 spa/src/routes/_app/users.$id.tsx  | 3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/spa/src/routes/_app/movies.$id.tsx b/spa/src/routes/_app/movies.$id.tsx
index 0732a59..a7f510a 100644
--- a/spa/src/routes/_app/movies.$id.tsx
+++ b/spa/src/routes/_app/movies.$id.tsx
@@ -30,12 +30,12 @@ function MovieDetailPage() {
   const { data, isPending } = useMovie(id)
   const { data: profile } = useMovieProfile(id)
   const { data: history } = useMovieHistory(id)
+  useDocumentTitle(data?.movie.title)
 
   if (isPending) return <DetailSkeleton />
   if (!data) return null
 
   const { movie, stats, reviews } = data
-  useDocumentTitle(movie.title)
   const hasStats = profile && (profile.budget_usd != null || profile.revenue_usd != null || profile.vote_average != null)
 
   return (
diff --git a/spa/src/routes/_app/people.$id.tsx b/spa/src/routes/_app/people.$id.tsx
index ca6c13a..7e17800 100644
--- a/spa/src/routes/_app/people.$id.tsx
+++ b/spa/src/routes/_app/people.$id.tsx
@@ -17,12 +17,12 @@ function PersonDetailPage() {
   const { t } = useTranslation()
   const { id } = Route.useParams()
   const { data, isPending } = usePersonCredits(id)
+  useDocumentTitle(data?.person.name)
 
   if (isPending) return <PersonSkeleton />
   if (!data) return null
 
   const { person, cast, crew } = data
-  useDocumentTitle(person.name)
 
   return (
     <div className="space-y-4 p-4">
diff --git a/spa/src/routes/_app/users.$id.tsx b/spa/src/routes/_app/users.$id.tsx
index dd3c83c..3e6d9a8 100644
--- a/spa/src/routes/_app/users.$id.tsx
+++ b/spa/src/routes/_app/users.$id.tsx
@@ -25,11 +25,10 @@ function UserProfilePage() {
   const unfollowMutation = useUnfollow()
 
   const [search, setSearch] = useState("")
+  useDocumentTitle(data?.username)
 
   if (isPending) return <ProfileSkeleton />
   if (!data) return null
-
-  useDocumentTitle(data?.username)
   const isSelf = auth?.user_id === id
   const isFollowing = followingData?.actors.some((a) => a.handle === data.username) ?? false