refactor: fix all clippy warnings properly

- UserProfile struct groups display_name/bio/avatar/banner/also_known_as/profile_fields
- User::from_persistence takes UserProfile (6 args, was 11)
- PersistedReview struct for Review::from_persistence (1 arg, was 8)
- WatchlistApInput struct for watchlist_to_ap_object (1 arg, was 8)
- ActivityPubDeps struct for activitypub::wire (1 arg, was 11)
- FederationRepos type alias for wire() return types
- FeedSortBy: impl std::str::FromStr instead of inherent from_str
- postgres users.rs: row_to_user takes &PgRow like sqlite
- collapse nested ifs in multipart handlers
- type alias for complex return types (image-converter, worker)
- tui: allow large_enum_variant at crate level (pre-existing, unrelated)

crates/adapters/sqlite/src/models.rs

@@ -2,8 +2,8 @@ use chrono::NaiveDateTime;
 use domain::{
     errors::DomainError,
     models::{
-        DiaryEntry, FeedEntry, Movie, MovieSummary, Review, ReviewSource, UserSummary,
-        WatchlistEntry, WatchlistWithMovie,
+        DiaryEntry, FeedEntry, Movie, MovieSummary, PersistedReview, Review, ReviewSource,
+        UserSummary, WatchlistEntry, WatchlistWithMovie,
     },
     value_objects::{
         Comment, Email, ExternalMetadataId, MovieId, MovieTitle, PosterPath, Rating, ReleaseYear,
@@ -109,9 +109,16 @@ impl ReviewRow {
             None => ReviewSource::Local,
             Some(url) => ReviewSource::Remote { actor_url: url },
         };
-        Ok(Review::from_persistence(
-            id, movie_id, user_id, rating, comment, watched_at, created_at, source,
-        ))
+        Ok(Review::from_persistence(PersistedReview {
+            id,
+            movie_id,
+            user_id,
+            rating,
+            comment,
+            watched_at,
+            created_at,
+            source,
+        }))
     }
 }
 

crates/adapters/sqlite/src/tests/users.rs

@@ -6,7 +6,7 @@ use sqlx::SqlitePool;
 async fn setup() -> (SqlitePool, SqliteUserRepository) {
     let pool = SqlitePool::connect(":memory:").await.unwrap();
     sqlx::query(
-        "CREATE TABLE users (id TEXT PRIMARY KEY, email TEXT NOT NULL UNIQUE, username TEXT NOT NULL UNIQUE, password_hash TEXT NOT NULL, created_at TEXT NOT NULL, role TEXT NOT NULL DEFAULT 'standard', bio TEXT, avatar_path TEXT, banner_path TEXT, also_known_as TEXT)"
+        "CREATE TABLE users (id TEXT PRIMARY KEY, email TEXT NOT NULL UNIQUE, username TEXT NOT NULL UNIQUE, password_hash TEXT NOT NULL, created_at TEXT NOT NULL, role TEXT NOT NULL DEFAULT 'standard', display_name TEXT, bio TEXT, avatar_path TEXT, banner_path TEXT, also_known_as TEXT)"
     )
     .execute(&pool)
     .await
@@ -65,10 +65,11 @@ async fn update_profile_persists_bio_and_avatar() {
 
     repo.update_profile(
         user.id(),
-        Some("My biography".to_string()),
-        Some("avatars/user1".to_string()),
-        None,
-        None,
+        &domain::models::UserProfile {
+            bio: Some("My biography".to_string()),
+            avatar_path: Some("avatars/user1".to_string()),
+            ..Default::default()
+        },
     )
     .await
     .unwrap();
@@ -90,14 +91,15 @@ async fn update_profile_clears_fields_with_none() {
     repo.save(&user).await.unwrap();
     repo.update_profile(
         user.id(),
-        Some("bio".to_string()),
-        Some("path".to_string()),
-        None,
-        None,
+        &domain::models::UserProfile {
+            bio: Some("bio".to_string()),
+            avatar_path: Some("path".to_string()),
+            ..Default::default()
+        },
     )
     .await
     .unwrap();
-    repo.update_profile(user.id(), None, None, None, None)
+    repo.update_profile(user.id(), &domain::models::UserProfile::default())
         .await
         .unwrap();
 

crates/adapters/sqlite/src/users.rs

@@ -51,12 +51,14 @@ impl SqliteUserRepository {
             username,
             hash,
             Self::parse_role(&role_str),
-            row.try_get("display_name").ok().flatten(),
-            row.try_get("bio").ok().flatten(),
-            row.try_get("avatar_path").ok().flatten(),
-            row.try_get("banner_path").ok().flatten(),
-            row.try_get("also_known_as").ok().flatten(),
-            profile_fields,
+            domain::models::UserProfile {
+                display_name: row.try_get("display_name").ok().flatten(),
+                bio: row.try_get("bio").ok().flatten(),
+                avatar_path: row.try_get("avatar_path").ok().flatten(),
+                banner_path: row.try_get("banner_path").ok().flatten(),
+                also_known_as: row.try_get("also_known_as").ok().flatten(),
+                profile_fields,
+            },
         ))
     }
 }
@@ -161,21 +163,17 @@ impl UserRepository for SqliteUserRepository {
     async fn update_profile(
         &self,
         user_id: &UserId,
-        display_name: Option<String>,
-        bio: Option<String>,
-        avatar_path: Option<String>,
-        banner_path: Option<String>,
-        also_known_as: Option<String>,
+        profile: &domain::models::UserProfile,
     ) -> Result<(), DomainError> {
         let id_str = user_id.value().to_string();
         sqlx::query(
             "UPDATE users SET display_name = ?, bio = ?, avatar_path = ?, banner_path = ?, also_known_as = ? WHERE id = ?",
         )
-        .bind(&display_name)
-        .bind(&bio)
-        .bind(&avatar_path)
-        .bind(&banner_path)
-        .bind(&also_known_as)
+        .bind(&profile.display_name)
+        .bind(&profile.bio)
+        .bind(&profile.avatar_path)
+        .bind(&profile.banner_path)
+        .bind(&profile.also_known_as)
         .bind(&id_str)
         .execute(&self.pool)
         .await