refactor: remove SocialQueryPort — replaced by SocialQuery + FederationAdminQuery

-319 lines. Legacy SocialQueryPort trait, NoopSocialQueryPort,
PanicSocialQueryPort all deleted. Federation repos now implement
FederationAdminQuery (single method). get_users uses FederationAdminQuery.
All other consumers use unified SocialQuery.

crates/domain/src/ports/noop.rs

@@ -94,38 +94,18 @@ impl super::SocialQuery for NoopSocialQuery {
     async fn get_accepted_following_urls(&self, _: &UserId) -> Result<Vec<String>, DomainError> {
         Ok(vec![])
     }
-    async fn list_all_followed_remote_actors(
-        &self,
-    ) -> Result<Vec<crate::models::RemoteActorInfo>, DomainError> {
-        Ok(vec![])
-    }
 }
 
-// ── NoopSocialQueryPort ───────────────────────────────────────────────────────
+// ── NoopFederationAdminQuery ─────────────────────────────────────────────────
 
 /// Stub used when federation is disabled — returns empty results.
-pub struct NoopSocialQueryPort;
+pub struct NoopFederationAdminQuery;
 
 #[async_trait]
-impl super::SocialQueryPort for NoopSocialQueryPort {
-    async fn get_accepted_following_urls(&self, _: &UserId) -> Result<Vec<String>, DomainError> {
-        Ok(vec![])
-    }
+impl super::FederationAdminQuery for NoopFederationAdminQuery {
     async fn list_all_followed_remote_actors(
         &self,
     ) -> Result<Vec<crate::models::RemoteActorInfo>, DomainError> {
         Ok(vec![])
     }
-    async fn count_following(&self, _: &UserId) -> Result<usize, DomainError> {
-        Ok(0)
-    }
-    async fn count_accepted_followers(&self, _: &UserId) -> Result<usize, DomainError> {
-        Ok(0)
-    }
-    async fn get_pending_followers(
-        &self,
-        _: &UserId,
-    ) -> Result<Vec<crate::models::PendingFollowerInfo>, DomainError> {
-        Ok(vec![])
-    }
 }

crates/domain/src/ports/social.rs

@@ -4,7 +4,7 @@ use chrono::NaiveDateTime;
 use crate::{
     errors::DomainError,
     models::{
-        DiaryEntry, FederationFlags, PendingFollowerInfo, RemoteActorInfo, RemoteGoalEntry,
+        DiaryEntry, FederationFlags, RemoteActorInfo, RemoteGoalEntry,
         RemoteWatchlistEntry, WatchlistWithMovie,
     },
     value_objects::{MovieId, SocialActor, SocialIdentity, UserId},
@@ -94,26 +94,11 @@ pub trait SocialQuery: Send + Sync {
         user_id: &UserId,
     ) -> Result<Vec<String>, DomainError>;
 
-    async fn list_all_followed_remote_actors(
-        &self,
-    ) -> Result<Vec<crate::models::RemoteActorInfo>, DomainError>;
 }
 
-// ── Legacy ports (pre-unification, still used by AP adapter + handlers) ─────
-
 #[async_trait]
-pub trait SocialQueryPort: Send + Sync {
-    async fn get_accepted_following_urls(
-        &self,
-        user_id: &UserId,
-    ) -> Result<Vec<String>, DomainError>;
+pub trait FederationAdminQuery: Send + Sync {
     async fn list_all_followed_remote_actors(&self) -> Result<Vec<RemoteActorInfo>, DomainError>;
-    async fn count_following(&self, user_id: &UserId) -> Result<usize, DomainError>;
-    async fn count_accepted_followers(&self, user_id: &UserId) -> Result<usize, DomainError>;
-    async fn get_pending_followers(
-        &self,
-        user_id: &UserId,
-    ) -> Result<Vec<PendingFollowerInfo>, DomainError>;
 }
 
 #[async_trait]

crates/domain/src/testing/in_memory.rs

@@ -1124,10 +1124,4 @@ impl SocialQuery for InMemorySocialRepository {
     ) -> Result<Vec<String>, DomainError> {
         Ok(vec![])
     }
-
-    async fn list_all_followed_remote_actors(
-        &self,
-    ) -> Result<Vec<crate::models::RemoteActorInfo>, DomainError> {
-        Ok(vec![])
-    }
 }

crates/domain/src/testing/noops.rs

@@ -65,7 +65,7 @@ impl ObjectStorage for NoopObjectStorage {
 // Re-export production noop types so test code that imports from
 // `domain::testing` keeps compiling without changes.
 pub use crate::ports::noop::NoopRemoteWatchlistRepository;
-pub use crate::ports::noop::NoopSocialQueryPort;
+pub use crate::ports::noop::NoopFederationAdminQuery;
 
 // ── NoopGoalCommand ───────────────────────────────────────────────────────────
 

crates/domain/src/testing/panics.rs

@@ -6,7 +6,7 @@ use crate::{
         AnnotatedRow, DiaryEntry, DiaryFilter, EntityType, ExportFormat, ExternalPersonId,
         FeedEntry, FeedSortBy, FieldMapping, FileFormat, FollowingFilter, ImportError,
         ImportProfile, ImportSession, IndexableDocument, MovieProfile, MovieStats, ParsedFile,
-        PendingFollowerInfo, Person, PersonCredits, PersonEnrichmentData, PersonId, RefreshSession,
+        Person, PersonCredits, PersonEnrichmentData, PersonId, RefreshSession,
         RemoteActorInfo, ReviewHistory, SearchQuery, SearchResults, UserStats, UserTrends,
         collections::{PageParams, Paginated},
     },
@@ -326,36 +326,12 @@ impl UserProfileFieldsRepository for PanicProfileFieldsRepo {
     }
 }
 
-pub struct PanicSocialQueryPort;
+pub struct PanicFederationAdminQuery;
 
 #[async_trait]
-impl crate::ports::SocialQueryPort for PanicSocialQueryPort {
-    async fn get_accepted_following_urls(
-        &self,
-        _: &crate::value_objects::UserId,
-    ) -> Result<Vec<String>, DomainError> {
-        panic!("PanicSocialQueryPort called")
-    }
+impl crate::ports::FederationAdminQuery for PanicFederationAdminQuery {
     async fn list_all_followed_remote_actors(&self) -> Result<Vec<RemoteActorInfo>, DomainError> {
-        panic!("PanicSocialQueryPort called")
-    }
-    async fn count_following(
-        &self,
-        _: &crate::value_objects::UserId,
-    ) -> Result<usize, DomainError> {
-        panic!("PanicSocialQueryPort called")
-    }
-    async fn count_accepted_followers(
-        &self,
-        _: &crate::value_objects::UserId,
-    ) -> Result<usize, DomainError> {
-        panic!("PanicSocialQueryPort called")
-    }
-    async fn get_pending_followers(
-        &self,
-        _: &crate::value_objects::UserId,
-    ) -> Result<Vec<PendingFollowerInfo>, DomainError> {
-        panic!("PanicSocialQueryPort called")
+        panic!("PanicFederationAdminQuery called")
     }
 }