refactor: remove SocialQueryPort — replaced by SocialQuery + FederationAdminQuery

-319 lines. Legacy SocialQueryPort trait, NoopSocialQueryPort,
PanicSocialQueryPort all deleted. Federation repos now implement
FederationAdminQuery (single method). get_users uses FederationAdminQuery.
All other consumers use unified SocialQuery.

crates/presentation/src/context.rs

@@ -6,7 +6,7 @@ use domain::ports::{
     MovieCommand, MovieProfileRepository, MovieQuery, ObjectStorage, PasswordHasher, PersonCommand,
     PersonEnrichmentClient, PersonQuery, PosterFetcherClient, RefreshSessionRepository,
     RemoteGoalRepository, RemoteWatchlistRepository, ReviewRepository, SearchCommand, SearchPort,
-    SocialCommand, SocialQuery, SocialQueryPort, StatsRepository, UserProfileFieldsRepository,
+    FederationAdminQuery, SocialCommand, SocialQuery, StatsRepository, UserProfileFieldsRepository,
     UserRepository, UserSettingsRepository, WatchEventCommand, WatchEventQuery,
     WatchlistRepository, WebhookTokenRepository, WrapUpRepository, WrapUpStatsQuery,
 };
@@ -37,7 +37,7 @@ pub struct Repositories {
     pub remote_watchlist: Arc<dyn RemoteWatchlistRepository>,
     pub social_command: Arc<dyn SocialCommand>,
     pub social_query_unified: Arc<dyn SocialQuery>,
-    pub social_query: Arc<dyn SocialQueryPort>,
+    pub federation_admin: Arc<dyn FederationAdminQuery>,
     pub wrapup_stats: Arc<dyn WrapUpStatsQuery>,
     pub wrapup_repo: Arc<dyn WrapUpRepository>,
     pub goal_command: Arc<dyn GoalCommand>,

crates/presentation/src/handlers/users.rs

@@ -178,7 +178,7 @@ pub async fn update_profile_fields_handler(
 pub async fn list_users(State(state): State<AppState>) -> Result<Json<UsersResponse>, ApiError> {
     let deps = application::users::deps::GetUsersListDeps {
         user: state.app_ctx.repos.user.clone(),
-        social_query_legacy: state.app_ctx.repos.social_query.clone(),
+        federation_admin: state.app_ctx.repos.federation_admin.clone(),
     };
     let result = get_users::execute(&deps, GetUsersQuery).await?;
     Ok(Json(UsersResponse {
@@ -486,7 +486,7 @@ pub async fn get_users_list(
 
     let users_deps = application::users::deps::GetUsersListDeps {
         user: state.app_ctx.repos.user.clone(),
-        social_query_legacy: state.app_ctx.repos.social_query.clone(),
+        federation_admin: state.app_ctx.repos.federation_admin.clone(),
     };
     match application::users::get_users::execute(
         &users_deps,

crates/presentation/src/main.rs

@@ -176,9 +176,9 @@ async fn wire_dependencies() -> anyhow::Result<(AppState, axum::Router)> {
             social_command: social_command_arc,
             social_query_unified: social_query_unified_arc,
             #[cfg(feature = "federation")]
-            social_query: social_query.clone(),
+            federation_admin: social_query.clone(),
             #[cfg(not(feature = "federation"))]
-            social_query: Arc::new(domain::ports::noop::NoopSocialQueryPort),
+            federation_admin: Arc::new(domain::ports::noop::NoopFederationAdminQuery),
             wrapup_stats: db.wrapup_stats,
             wrapup_repo: db.wrapup_repo,
             goal_command: db.goal_command,

crates/presentation/src/tests/extractors.rs

@@ -154,30 +154,6 @@ impl DiaryQuery for Panic {
         panic!()
     }
 }
-#[cfg(feature = "federation")]
-#[async_trait::async_trait]
-impl domain::ports::SocialQueryPort for Panic {
-    async fn get_accepted_following_urls(&self, _: &UserId) -> Result<Vec<String>, DomainError> {
-        panic!()
-    }
-    async fn list_all_followed_remote_actors(
-        &self,
-    ) -> Result<Vec<domain::models::RemoteActorInfo>, DomainError> {
-        panic!()
-    }
-    async fn count_following(&self, _: &UserId) -> Result<usize, DomainError> {
-        panic!()
-    }
-    async fn count_accepted_followers(&self, _: &UserId) -> Result<usize, DomainError> {
-        panic!()
-    }
-    async fn get_pending_followers(
-        &self,
-        _: &UserId,
-    ) -> Result<Vec<domain::models::PendingFollowerInfo>, DomainError> {
-        panic!()
-    }
-}
 #[async_trait::async_trait]
 impl StatsRepository for Panic {
     async fn get_user_stats(&self, _: &UserId) -> Result<UserStats, DomainError> {
@@ -813,7 +789,7 @@ pub fn make_test_state(auth_service: Arc<dyn AuthService>) -> crate::state::AppS
                 remote_watchlist: Arc::clone(&repo) as _,
                 social_command: Arc::new(domain::ports::noop::NoopSocialCommand) as _,
                 social_query_unified: Arc::new(domain::ports::noop::NoopSocialQuery) as _,
-                social_query: Arc::clone(&repo) as _,
+                federation_admin: Arc::new(domain::ports::noop::NoopFederationAdminQuery) as _,
                 wrapup_stats: Arc::clone(&repo) as _,
                 wrapup_repo: Arc::clone(&repo) as _,
                 goal_command: Arc::clone(&repo) as _,

crates/presentation/tests/api_test.rs

@@ -372,9 +372,6 @@ impl SearchCommand for PanicSearchCommand {
     }
 }
 
-#[cfg(feature = "federation")]
-struct PanicSocialQuery;
-
 #[cfg(feature = "federation")]
 struct PanicRemoteWatchlist;
 #[cfg(feature = "federation")]
@@ -402,40 +399,6 @@ impl domain::ports::RemoteWatchlistRepository for PanicRemoteWatchlist {
         Ok(vec![])
     }
 }
-#[cfg(feature = "federation")]
-#[async_trait::async_trait]
-impl domain::ports::SocialQueryPort for PanicSocialQuery {
-    async fn get_accepted_following_urls(
-        &self,
-        _: &domain::value_objects::UserId,
-    ) -> Result<Vec<String>, DomainError> {
-        panic!()
-    }
-    async fn list_all_followed_remote_actors(
-        &self,
-    ) -> Result<Vec<domain::models::RemoteActorInfo>, DomainError> {
-        panic!()
-    }
-    async fn count_following(
-        &self,
-        _: &domain::value_objects::UserId,
-    ) -> Result<usize, DomainError> {
-        panic!()
-    }
-    async fn count_accepted_followers(
-        &self,
-        _: &domain::value_objects::UserId,
-    ) -> Result<usize, DomainError> {
-        panic!()
-    }
-    async fn get_pending_followers(
-        &self,
-        _: &domain::value_objects::UserId,
-    ) -> Result<Vec<domain::models::PendingFollowerInfo>, DomainError> {
-        panic!()
-    }
-}
-
 async fn test_app() -> Router {
     let pool = SqlitePool::connect("sqlite::memory:")
         .await
@@ -466,7 +429,7 @@ async fn test_app() -> Router {
                 remote_watchlist: Arc::new(PanicRemoteWatchlist),
                 social_command: Arc::new(domain::ports::noop::NoopSocialCommand),
                 social_query_unified: Arc::new(domain::ports::noop::NoopSocialQuery),
-                social_query: Arc::new(PanicSocialQuery),
+                federation_admin: Arc::new(domain::ports::noop::NoopFederationAdminQuery) as _,
                 wrapup_stats: Arc::new(domain::testing::PanicWrapUpStatsQuery) as _,
                 wrapup_repo: Arc::new(domain::testing::PanicWrapUpRepository) as _,
                 goal_command: Arc::new(domain::testing::NoopGoalCommand),