test: shared factories and command builders

crates/adapters/sqlite/src/repositories/persons/tests.rs

@@ -1,6 +1,7 @@
 use super::SqlitePersonAdapter;
+use domain::testing::test_person_with_tmdb;
 use domain::{
-    models::{ExternalPersonId, Person, PersonId},
+    models::{ExternalPersonId, PersonId},
     ports::{PersonCommand, PersonQuery},
 };
 use sqlx::SqlitePool;
@@ -47,25 +48,14 @@ async fn pool_with_schema() -> SqlitePool {
     pool
 }
 
-fn make_person(tmdb_id: i64, name: &str, dept: Option<&str>) -> Person {
-    let ext = ExternalPersonId::new(format!("tmdb:{tmdb_id}"));
-    Person::basic(
-        PersonId::from_external(&ext),
-        ext,
-        name.to_string(),
-        dept.map(str::to_string),
-        None,
-    )
-}
-
 #[tokio::test]
 async fn upsert_batch_inserts_persons() {
     let pool = pool_with_schema().await;
     let adapter = SqlitePersonAdapter::new(pool.clone());
 
     let persons = vec![
-        make_person(1, "Alice", Some("Acting")),
-        make_person(2, "Bob", Some("Directing")),
+        test_person_with_tmdb(1, "Alice", Some("Acting")),
+        test_person_with_tmdb(2, "Bob", Some("Directing")),
     ];
     adapter.upsert_batch(&persons).await.unwrap();
 
@@ -81,7 +71,7 @@ async fn upsert_batch_is_idempotent() {
     let pool = pool_with_schema().await;
     let adapter = SqlitePersonAdapter::new(pool.clone());
 
-    let persons = vec![make_person(1, "Alice", Some("Acting"))];
+    let persons = vec![test_person_with_tmdb(1, "Alice", Some("Acting"))];
     adapter.upsert_batch(&persons).await.unwrap();
     adapter.upsert_batch(&persons).await.unwrap();
 
@@ -97,7 +87,7 @@ async fn get_by_id_returns_person() {
     let pool = pool_with_schema().await;
     let adapter = SqlitePersonAdapter::new(pool.clone());
 
-    let p = make_person(42, "Charlie", Some("Acting"));
+    let p = test_person_with_tmdb(42, "Charlie", Some("Acting"));
     adapter
         .upsert_batch(std::slice::from_ref(&p))
         .await
@@ -122,7 +112,7 @@ async fn get_credits_returns_cast_and_crew() {
     let pool = pool_with_schema().await;
     let adapter = SqlitePersonAdapter::new(pool.clone());
 
-    let p = make_person(7, "Diana", Some("Acting"));
+    let p = test_person_with_tmdb(7, "Diana", Some("Acting"));
     adapter
         .upsert_batch(std::slice::from_ref(&p))
         .await

crates/adapters/sqlite/src/repositories/users/tests.rs

@@ -1,6 +1,5 @@
 use super::*;
-use domain::models::UserRole;
-use domain::value_objects::{Email, PasswordHash, Username};
+use domain::testing::test_user;
 use sqlx::SqlitePool;
 
 async fn setup() -> (SqlitePool, SqliteUserRepository) {
@@ -55,12 +54,7 @@ async fn find_by_id_returns_user_when_found() {
 #[tokio::test]
 async fn update_profile_persists_bio_and_avatar() {
     let (_, repo) = setup().await;
-    let user = domain::models::User::new(
-        Email::new("test@example.com".to_string()).unwrap(),
-        Username::new("testuser".to_string()).unwrap(),
-        PasswordHash::new("hash".to_string()).unwrap(),
-        UserRole::Standard,
-    );
+    let user = test_user("testuser");
     repo.save(&user).await.unwrap();
 
     repo.update_profile(
@@ -82,12 +76,7 @@ async fn update_profile_persists_bio_and_avatar() {
 #[tokio::test]
 async fn update_profile_clears_fields_with_none() {
     let (_, repo) = setup().await;
-    let user = domain::models::User::new(
-        Email::new("test2@example.com".to_string()).unwrap(),
-        Username::new("testuser2".to_string()).unwrap(),
-        PasswordHash::new("hash".to_string()).unwrap(),
-        UserRole::Standard,
-    );
+    let user = test_user("testuser2");
     repo.save(&user).await.unwrap();
     repo.update_profile(
         user.id(),