test: shared factories and command builders

crates/application/src/movies/tests/enrich_movie.rs

@@ -1,14 +1,15 @@
+use domain::testing::test_movie_with_year;
 use std::sync::Arc;
 
 use chrono::Utc;
 use domain::{
-    models::{Movie, MovieProfile},
+    models::MovieProfile,
     ports::MovieCommand,
     testing::{
         FakeSearchCommand, InMemoryMovieProfileRepository, InMemoryMovieRepository,
         PanicPersonCommand,
     },
-    value_objects::{MovieId, MovieTitle, ReleaseYear},
+    value_objects::MovieId,
 };
 
 use crate::movies::{commands::EnrichMovieCommand, deps::EnrichMovieDeps, enrich_movie};
@@ -19,13 +20,7 @@ async fn stores_profile_and_indexes() {
     let profile_repo = InMemoryMovieProfileRepository::new();
     // PanicPersonCommand is safe here — empty cast/crew means upsert_batch is never called
 
-    let movie = Movie::new(
-        None,
-        MovieTitle::new("Test".into()).unwrap(),
-        ReleaseYear::new(2024).unwrap(),
-        None,
-        None,
-    );
+    let movie = test_movie_with_year("Test", 2024);
     let movie_id = MovieId::from_uuid(movie.id().value());
     movie_repo.upsert_movie(&movie).await.unwrap();
 
@@ -99,13 +94,7 @@ async fn extracts_and_indexes_persons() {
     let movie_repo = InMemoryMovieRepository::new();
     let profile_repo = InMemoryMovieProfileRepository::new();
 
-    let movie = Movie::new(
-        None,
-        MovieTitle::new("Cast Movie".into()).unwrap(),
-        ReleaseYear::new(2024).unwrap(),
-        None,
-        None,
-    );
+    let movie = test_movie_with_year("Cast Movie", 2024);
     let movie_id = MovieId::from_uuid(movie.id().value());
     movie_repo.upsert_movie(&movie).await.unwrap();
 

crates/application/src/movies/tests/sync_poster.rs

@@ -1,3 +1,5 @@
+use crate::test_support::sync_poster_command;
+use domain::testing::{test_movie_with_external_id, test_movie_with_year};
 use std::sync::Arc;
 
 use uuid::Uuid;
@@ -10,13 +12,10 @@ use domain::{
         FakeSearchCommand, InMemoryMovieProfileRepository, InMemoryMovieRepository,
         NoopEventPublisher, NoopObjectStorage,
     },
-    value_objects::{ExternalMetadataId, MovieTitle, PosterUrl, ReleaseYear},
+    value_objects::{ExternalMetadataId, PosterUrl},
 };
 
-use crate::{
-    diary::commands::SyncPosterCommand,
-    movies::{deps::SyncPosterDeps, sync_poster},
-};
+use crate::movies::{deps::SyncPosterDeps, sync_poster};
 
 fn default_deps() -> SyncPosterDeps {
     SyncPosterDeps {
@@ -35,13 +34,7 @@ fn default_deps() -> SyncPosterDeps {
 async fn fails_when_movie_not_found() {
     let deps = default_deps();
 
-    let result = sync_poster::execute(
-        &deps,
-        SyncPosterCommand {
-            movie_id: Uuid::new_v4(),
-        },
-    )
-    .await;
+    let result = sync_poster::execute(&deps, sync_poster_command(Uuid::new_v4())).await;
 
     assert!(result.is_err());
 }
@@ -49,13 +42,7 @@ async fn fails_when_movie_not_found() {
 #[tokio::test]
 async fn fails_when_no_external_id() {
     let movies = InMemoryMovieRepository::new();
-    let movie = Movie::new(
-        None,
-        MovieTitle::new("Test".into()).unwrap(),
-        ReleaseYear::new(2024).unwrap(),
-        None,
-        None,
-    );
+    let movie = test_movie_with_year("Test", 2024);
     let movie_id = movie.id().value();
     movies.upsert_movie(&movie).await.unwrap();
 
@@ -65,7 +52,7 @@ async fn fails_when_no_external_id() {
         ..default_deps()
     };
 
-    let result = sync_poster::execute(&deps, SyncPosterCommand { movie_id }).await;
+    let result = sync_poster::execute(&deps, sync_poster_command(movie_id)).await;
 
     assert!(result.is_err());
 }
@@ -94,13 +81,7 @@ impl MetadataClient for FakeMetaWithPoster {
 async fn syncs_poster_for_movie_with_external_id() {
     let movies = InMemoryMovieRepository::new();
     let ext_id = ExternalMetadataId::new("tmdb:999".into()).unwrap();
-    let movie = Movie::new(
-        Some(ext_id),
-        MovieTitle::new("Poster Movie".into()).unwrap(),
-        ReleaseYear::new(2024).unwrap(),
-        None,
-        None,
-    );
+    let movie = test_movie_with_external_id("Poster Movie", 2024, ext_id);
     let movie_id = movie.id().value();
     movies.upsert_movie(&movie).await.unwrap();
 
@@ -111,7 +92,7 @@ async fn syncs_poster_for_movie_with_external_id() {
         ..default_deps()
     };
 
-    sync_poster::execute(&deps, SyncPosterCommand { movie_id })
+    sync_poster::execute(&deps, sync_poster_command(movie_id))
         .await
         .unwrap();