test: refusing fakes, failure-path tests, shared panic stubs

crates/application/src/diary/tests/edit_review.rs

@@ -129,3 +129,27 @@ async fn edit_sets_watch_medium() {
     let updated = reviews.get_review_by_id(&review_id).await.unwrap().unwrap();
     assert_eq!(updated.watch_medium(), Some(&WatchMedium::Cinema));
 }
+
+#[tokio::test]
+async fn editing_a_review_fails_when_the_store_refuses() {
+    let (_, events, review_id, user_id) = setup().await;
+    let deps = EditReviewDeps {
+        review: Arc::new(domain::testing::RefusingReviewRepository),
+        event_publisher: Arc::clone(&events) as _,
+    };
+
+    let result = edit_review::execute(
+        &deps,
+        EditReviewCommand {
+            review_id: review_id.value(),
+            requesting_user_id: user_id.value(),
+            ..edit_review_command(5)
+        },
+    )
+    .await;
+
+    assert!(matches!(
+        result,
+        Err(domain::errors::DomainError::InfrastructureError(m)) if m == "refused"
+    ));
+}

crates/application/src/diary/tests/review_logger.rs

@@ -220,3 +220,47 @@ async fn publishes_movie_discovered_for_new_movie_with_external_id() {
         "should publish MovieEnrichmentRequested"
     );
 }
+
+#[tokio::test]
+async fn logging_a_review_fails_when_the_review_store_refuses() {
+    let movies = InMemoryStore::new();
+    let logger = DefaultReviewLogger::new(
+        Arc::clone(&movies) as _,
+        Arc::clone(&movies) as _,
+        Arc::new(domain::testing::RefusingReviewRepository),
+        Arc::clone(&movies) as _,
+        Arc::new(FakeMetadataClient),
+        NoopEventPublisher::new(),
+    );
+
+    let result = logger
+        .log_review(log_review_command_manual(Uuid::new_v4(), "Test Film", 2024))
+        .await;
+
+    assert!(matches!(result, Err(DomainError::InfrastructureError(m)) if m == "refused"));
+}
+
+#[tokio::test]
+async fn logging_a_review_when_event_publishing_fails_returns_the_error_but_keeps_the_saved_review()
+{
+    let movies = InMemoryStore::new();
+    let logger = DefaultReviewLogger::new(
+        Arc::clone(&movies) as _,
+        Arc::clone(&movies) as _,
+        Arc::clone(&movies) as _,
+        Arc::clone(&movies) as _,
+        Arc::new(FakeMetadataClient),
+        Arc::new(domain::testing::RefusingEventPublisher),
+    );
+
+    let result = logger
+        .log_review(log_review_command_manual(Uuid::new_v4(), "Test Film", 2024))
+        .await;
+
+    assert!(matches!(result, Err(DomainError::InfrastructureError(m)) if m == "refused"));
+    assert_eq!(
+        movies.review_count(),
+        1,
+        "review is saved before publishing"
+    );
+}