refactor: typed errors in rss/import ports

crates/adapters/jellyfin/src/lib.rs

@@ -60,73 +60,5 @@ struct JellyfinPayload {
 }
 
 #[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn parses_valid_playback_stop() {
-        let body = serde_json::json!({
-            "NotificationType": "PlaybackStop",
-            "ItemType": "Movie",
-            "Name": "Blade Runner",
-            "Year": 1982,
-            "PlayedToCompletion": true,
-            "Provider_tmdb": "78",
-            "Provider_imdb": "tt0083658"
-        });
-        let parser = JellyfinParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        let event = result.expect("should parse");
-        assert_eq!(event.title, "Blade Runner");
-        assert_eq!(event.year, Some(1982));
-        assert_eq!(event.tmdb_id, Some("tmdb:78".into()));
-        assert_eq!(event.imdb_id, Some("tt0083658".into()));
-    }
-
-    #[test]
-    fn ignores_non_movie() {
-        let body = serde_json::json!({
-            "NotificationType": "PlaybackStop",
-            "ItemType": "Episode",
-            "Name": "Some Episode",
-            "PlayedToCompletion": true
-        });
-        let parser = JellyfinParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        assert!(result.is_none());
-    }
-
-    #[test]
-    fn ignores_incomplete_playback() {
-        let body = serde_json::json!({
-            "NotificationType": "PlaybackStop",
-            "ItemType": "Movie",
-            "Name": "Blade Runner",
-            "PlayedToCompletion": false
-        });
-        let parser = JellyfinParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        assert!(result.is_none());
-    }
-
-    #[test]
-    fn ignores_playback_start() {
-        let body = serde_json::json!({
-            "NotificationType": "PlaybackStart",
-            "ItemType": "Movie",
-            "Name": "Blade Runner",
-            "PlayedToCompletion": false
-        });
-        let parser = JellyfinParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        assert!(result.is_none());
-    }
-}
+#[path = "tests/lib.rs"]
+mod tests;

crates/adapters/jellyfin/src/tests/lib.rs

@@ -0,0 +1,68 @@
+use super::*;
+
+#[test]
+fn parses_valid_playback_stop() {
+    let body = serde_json::json!({
+        "NotificationType": "PlaybackStop",
+        "ItemType": "Movie",
+        "Name": "Blade Runner",
+        "Year": 1982,
+        "PlayedToCompletion": true,
+        "Provider_tmdb": "78",
+        "Provider_imdb": "tt0083658"
+    });
+    let parser = JellyfinParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    let event = result.expect("should parse");
+    assert_eq!(event.title, "Blade Runner");
+    assert_eq!(event.year, Some(1982));
+    assert_eq!(event.tmdb_id, Some("tmdb:78".into()));
+    assert_eq!(event.imdb_id, Some("tt0083658".into()));
+}
+
+#[test]
+fn ignores_non_movie() {
+    let body = serde_json::json!({
+        "NotificationType": "PlaybackStop",
+        "ItemType": "Episode",
+        "Name": "Some Episode",
+        "PlayedToCompletion": true
+    });
+    let parser = JellyfinParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    assert!(result.is_none());
+}
+
+#[test]
+fn ignores_incomplete_playback() {
+    let body = serde_json::json!({
+        "NotificationType": "PlaybackStop",
+        "ItemType": "Movie",
+        "Name": "Blade Runner",
+        "PlayedToCompletion": false
+    });
+    let parser = JellyfinParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    assert!(result.is_none());
+}
+
+#[test]
+fn ignores_playback_start() {
+    let body = serde_json::json!({
+        "NotificationType": "PlaybackStart",
+        "ItemType": "Movie",
+        "Name": "Blade Runner",
+        "PlayedToCompletion": false
+    });
+    let parser = JellyfinParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    assert!(result.is_none());
+}

crates/adapters/plex/src/lib.rs

@@ -70,100 +70,5 @@ struct PlexGuid {
 }
 
 #[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn parses_movie_scrobble() {
-        let body = serde_json::json!({
-            "event": "media.scrobble",
-            "Metadata": {
-                "type": "movie",
-                "title": "Blade Runner",
-                "year": 1982,
-                "Guid": [
-                    {"id": "tmdb://78"},
-                    {"id": "imdb://tt0083658"}
-                ]
-            }
-        });
-        let parser = PlexParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        let event = result.expect("should parse");
-        assert_eq!(event.title, "Blade Runner");
-        assert_eq!(event.year, Some(1982));
-        assert_eq!(event.tmdb_id, Some("tmdb:78".into()));
-        assert_eq!(event.imdb_id, Some("tt0083658".into()));
-    }
-
-    #[test]
-    fn ignores_tv_episode() {
-        let body = serde_json::json!({
-            "event": "media.scrobble",
-            "Metadata": {
-                "type": "episode",
-                "title": "Pilot",
-                "grandparentTitle": "Breaking Bad",
-                "year": 2008,
-                "Guid": []
-            }
-        });
-        let parser = PlexParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        assert!(result.is_none());
-    }
-
-    #[test]
-    fn ignores_play_event() {
-        let body = serde_json::json!({
-            "event": "media.play",
-            "Metadata": {
-                "type": "movie",
-                "title": "Blade Runner",
-                "year": 1982,
-                "Guid": []
-            }
-        });
-        let parser = PlexParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        assert!(result.is_none());
-    }
-
-    #[test]
-    fn handles_no_guids() {
-        let body = serde_json::json!({
-            "event": "media.scrobble",
-            "Metadata": {
-                "type": "movie",
-                "title": "Some Indie Film",
-                "year": 2023
-            }
-        });
-        let parser = PlexParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        let event = result.expect("should parse");
-        assert_eq!(event.title, "Some Indie Film");
-        assert!(event.tmdb_id.is_none());
-        assert!(event.imdb_id.is_none());
-    }
-
-    #[test]
-    fn handles_missing_metadata() {
-        let body = serde_json::json!({
-            "event": "media.scrobble"
-        });
-        let parser = PlexParser;
-        let result = parser
-            .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
-            .unwrap();
-        assert!(result.is_none());
-    }
-}
+#[path = "tests/lib.rs"]
+mod tests;

crates/adapters/plex/src/tests/lib.rs

@@ -0,0 +1,95 @@
+use super::*;
+
+#[test]
+fn parses_movie_scrobble() {
+    let body = serde_json::json!({
+        "event": "media.scrobble",
+        "Metadata": {
+            "type": "movie",
+            "title": "Blade Runner",
+            "year": 1982,
+            "Guid": [
+                {"id": "tmdb://78"},
+                {"id": "imdb://tt0083658"}
+            ]
+        }
+    });
+    let parser = PlexParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    let event = result.expect("should parse");
+    assert_eq!(event.title, "Blade Runner");
+    assert_eq!(event.year, Some(1982));
+    assert_eq!(event.tmdb_id, Some("tmdb:78".into()));
+    assert_eq!(event.imdb_id, Some("tt0083658".into()));
+}
+
+#[test]
+fn ignores_tv_episode() {
+    let body = serde_json::json!({
+        "event": "media.scrobble",
+        "Metadata": {
+            "type": "episode",
+            "title": "Pilot",
+            "grandparentTitle": "Breaking Bad",
+            "year": 2008,
+            "Guid": []
+        }
+    });
+    let parser = PlexParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    assert!(result.is_none());
+}
+
+#[test]
+fn ignores_play_event() {
+    let body = serde_json::json!({
+        "event": "media.play",
+        "Metadata": {
+            "type": "movie",
+            "title": "Blade Runner",
+            "year": 1982,
+            "Guid": []
+        }
+    });
+    let parser = PlexParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    assert!(result.is_none());
+}
+
+#[test]
+fn handles_no_guids() {
+    let body = serde_json::json!({
+        "event": "media.scrobble",
+        "Metadata": {
+            "type": "movie",
+            "title": "Some Indie Film",
+            "year": 2023
+        }
+    });
+    let parser = PlexParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    let event = result.expect("should parse");
+    assert_eq!(event.title, "Some Indie Film");
+    assert!(event.tmdb_id.is_none());
+    assert!(event.imdb_id.is_none());
+}
+
+#[test]
+fn handles_missing_metadata() {
+    let body = serde_json::json!({
+        "event": "media.scrobble"
+    });
+    let parser = PlexParser;
+    let result = parser
+        .parse_playback_event(serde_json::to_vec(&body).unwrap().as_slice())
+        .unwrap();
+    assert!(result.is_none());
+}

crates/adapters/rss/src/lib.rs

@@ -1,3 +1,4 @@
+use domain::errors::DomainError;
 use domain::models::DiaryEntry;
 use domain::ports::{FeedChannel, RssFeedRenderer};
 use rss_feed::extension::atom::{self, AtomExtensionBuilder, Link};
@@ -24,7 +25,7 @@ impl RssFeedRenderer for RssAdapter {
         &self,
         entries: &[DiaryEntry],
         channel: &FeedChannel<'_>,
-    ) -> Result<String, String> {
+    ) -> Result<String, DomainError> {
         let items = entries
             .iter()
             .map(|e| {