GKaszewski/movies-diary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(event-handlers): expect over unwrap, panic-stub comment, fix deprecated chrono call

Browse Source
This commit is contained in:
Gabriel Kaszewski
2026-05-04 12:42:03 +02:00
parent 4c547df04e
commit 5c70b8b8be
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/presentation/src/event_handlers.rs
View File

@@ -51,7 +51,7 @@ impl EventHandler for PosterSyncHandler {
} }
} }
let err = last_err.unwrap(); let err = last_err.expect("loop runs at least once and always sets last_err on Err");
tracing::error!( tracing::error!(
attempts = self.max_retries + 1, attempts = self.max_retries + 1,
"poster sync failed after all attempts: {err}" "poster sync failed after all attempts: {err}"
@@ -79,6 +79,8 @@ mod tests {
}, },
}; };
// Panic-stub ports: each method panics so any accidental dispatch into a service
// fails the test loudly rather than silently succeeding.
struct PanicRepo; struct PanicRepo;
struct PanicMetadata; struct PanicMetadata;
struct PanicFetcher; struct PanicFetcher;
@@ -161,7 +163,7 @@ mod tests {
movie_id: MovieId::generate(), movie_id: MovieId::generate(),
user_id: UserId::generate(), user_id: UserId::generate(),
rating: Rating::new(4).unwrap(), rating: Rating::new(4).unwrap(),
watched_at: chrono::NaiveDateTime::from_timestamp_opt(0, 0).unwrap(), watched_at: chrono::NaiveDate::from_ymd_opt(2024, 1, 1).unwrap().and_hms_opt(0, 0, 0).unwrap(),
}; };
assert!(handler.handle(&event).await.is_ok()); assert!(handler.handle(&event).await.is_ok());
} }