refactor: LOW+MEDIUM cleanups — CQRS DiaryQuery/GoalCommand+GoalQuery,

test-helpers out of production, decompose get_user_profile_html,
dedup secure_flag, remove vestigial social_query, drop
PersistedImportSession, LoginCommand rename, DeleteAccountDeps,
PersonId macro, ReviewSortBy rename, TUI Command for fs::read,
generic PaginatedResponse<T>, noop ports for production fallbacks

crates/worker/Cargo.toml

@@ -13,7 +13,7 @@ sqlite-federation = ["sqlite", "dep:sqlite-federation", "dep:activitypub", "fede
 postgres-federation = ["postgres", "dep:postgres-federation", "dep:activitypub", "federation"]
 
 [dependencies]
-domain = { workspace = true, features = ["test-helpers"] }
+domain = { workspace = true }
 application = { workspace = true }
 tokio = { workspace = true }
 anyhow = { workspace = true }

crates/worker/src/db.rs

@@ -2,7 +2,7 @@ use std::sync::Arc;
 
 use anyhow::Context;
 use domain::ports::{
-    DiaryRepository, GoalRepository, ImageRefCommand, ImageRefQuery, ImportSessionRepository,
+    DiaryQuery, GoalCommand, GoalQuery, ImageRefCommand, ImageRefQuery, ImportSessionRepository,
     LocalApContentQuery, MovieCommand, MovieDeduplicator, MovieProfileRepository, MovieQuery,
     PersonCommand, PersonQuery, ReviewRepository, SearchCommand, StatsRepository, UserRepository,
     WatchEventCommand, WatchEventQuery,
@@ -14,9 +14,10 @@ pub struct WorkerDbOutput {
     pub movie_command: Arc<dyn MovieCommand>,
     pub movie_query: Arc<dyn MovieQuery>,
     pub review: Arc<dyn ReviewRepository>,
-    pub diary: Arc<dyn DiaryRepository>,
+    pub diary: Arc<dyn DiaryQuery>,
     pub stats: Arc<dyn StatsRepository>,
-    pub goal: Arc<dyn GoalRepository>,
+    pub _goal_command: Arc<dyn GoalCommand>,
+    pub goal_query: Arc<dyn GoalQuery>,
     pub user: Arc<dyn UserRepository>,
     pub import_session: Arc<dyn ImportSessionRepository>,
     pub movie_profile: Arc<dyn MovieProfileRepository>,
@@ -55,7 +56,8 @@ pub async fn connect(database_url: &str, backend: &str) -> anyhow::Result<Worker
                 review: w.review,
                 diary: w.diary,
                 stats: w.stats,
-                goal: w.goal,
+                _goal_command: w.goal_command,
+                goal_query: w.goal_query,
                 user: w.user,
                 import_session: w.import_session,
                 movie_profile: w.movie_profile,
@@ -94,7 +96,8 @@ pub async fn connect(database_url: &str, backend: &str) -> anyhow::Result<Worker
                 review: w.review,
                 diary: w.diary,
                 stats: w.stats,
-                goal: w.goal,
+                _goal_command: w.goal_command,
+                goal_query: w.goal_query,
                 user: w.user,
                 import_session: w.import_session,
                 movie_profile: w.movie_profile,

crates/worker/src/main.rs

@@ -53,7 +53,7 @@ async fn main() -> anyhow::Result<()> {
         Arc::clone(&db.movie_query),
         Arc::clone(&db.review),
         Arc::clone(&db.diary),
-        Arc::clone(&db.goal),
+        Arc::clone(&db.goal_query),
         Arc::clone(&db.stats),
         Arc::clone(&db.user),
         app_config.base_url.clone(),