feat: atomic wrapup, movie, integration writes

Ride writes: WrapUpRequested/Completed (wrapup create/set_complete),
MovieDiscovered (resolve upsert, new+ext id only), PosterSynced (poster
handler upsert), MovieDeleted (delete_movie), WatchEventIngested (save).
Deps drop event_publisher: wrapup, ingest, delete_review, watchlist add,
review logger.

Remaining .publish( sites:
announce-only: users/delete_account UserDeleted, person/get +
get_credits PersonEnrichmentRequested, jobs/enrichment_staleness,
http-axum search, movies/sync_poster + poster_sync_handler +
image-converter backfill + users/update_profile ImageStored (object
storage), activitypub federation_event_bridge (reacting to events).
rides write, deferred: social/execute (see report),
activitypub review_handler MovieEnrichmentRequested (after
save_remote_review).
This commit is contained in:
2026-10-26 01:02:34 +01:00
parent 2f133afb96
commit 6c295866a0
51 changed files with 1281 additions and 329 deletions

View File

@@ -19,7 +19,7 @@ async fn stores_profile_and_indexes() {
let movie = test_movie_with_year("Test", 2024);
let movie_id = MovieId::from_uuid(movie.id().value());
movie_repo.upsert_movie(&movie).await.unwrap();
movie_repo.upsert_movie(&movie, &[]).await.unwrap();
let profile = MovieProfile {
movie_id: movie_id.clone(),
@@ -68,7 +68,7 @@ async fn extracts_and_indexes_persons() {
let movie = test_movie_with_year("Cast Movie", 2024);
let movie_id = MovieId::from_uuid(movie.id().value());
movie_repo.upsert_movie(&movie).await.unwrap();
movie_repo.upsert_movie(&movie, &[]).await.unwrap();
let profile = MovieProfile {
movie_id: movie_id.clone(),

View File

@@ -0,0 +1,89 @@
use std::sync::Arc;
use async_trait::async_trait;
use domain::{
errors::DomainError,
events::DomainEvent,
models::Movie,
ports::{EventHandler, MetadataClient, MovieCommand},
testing::{
FakePosterFetcher, InMemoryStore, NoopEventPublisher, NoopObjectStorage,
RefusingMovieCommand, test_movie_with_external_id,
},
value_objects::{ExternalMetadataId, PosterUrl},
};
use application::movies::poster_sync_handler::PosterSyncHandler;
struct MetadataWithPoster;
#[async_trait]
impl MetadataClient for MetadataWithPoster {
async fn fetch_movie_metadata(
&self,
_: &domain::models::MetadataSearchCriteria,
) -> Result<Movie, DomainError> {
unimplemented!()
}
async fn get_poster_url(
&self,
_: &ExternalMetadataId,
) -> Result<Option<PosterUrl>, DomainError> {
Ok(Some(
PosterUrl::new("https://example.com/poster.jpg".into()).unwrap(),
))
}
}
async fn seeded() -> (Arc<InMemoryStore>, Movie, DomainEvent) {
let store = InMemoryStore::new();
let ext = ExternalMetadataId::new("tmdb:42".into()).unwrap();
let movie = test_movie_with_external_id("Heat", 1995, ext.clone());
store.upsert_movie(&movie, &[]).await.unwrap();
let event = DomainEvent::MovieDiscovered {
movie_id: movie.id().clone(),
external_metadata_id: ext,
};
(store, movie, event)
}
fn handler(command: Arc<dyn MovieCommand>, store: &Arc<InMemoryStore>) -> PosterSyncHandler {
PosterSyncHandler::new(
command,
Arc::clone(store) as _,
Arc::new(MetadataWithPoster),
Arc::new(FakePosterFetcher),
Arc::new(NoopObjectStorage),
NoopEventPublisher::new(),
0,
)
}
#[tokio::test]
async fn poster_synced_rides_the_movie_write() {
let (store, movie, event) = seeded().await;
handler(Arc::clone(&store) as _, &store)
.handle(&event)
.await
.unwrap();
let recorded = store.recorded_events();
assert_eq!(recorded.len(), 1);
assert!(matches!(
&recorded[0],
DomainEvent::PosterSynced { movie_id } if movie_id == movie.id()
));
}
#[tokio::test]
async fn a_refused_upsert_propagates_and_records_nothing() {
let (store, _movie, event) = seeded().await;
let result = handler(Arc::new(RefusingMovieCommand), &store)
.handle(&event)
.await;
assert!(matches!(result, Err(DomainError::InfrastructureError(m)) if m == "refused"));
assert!(store.recorded_events().is_empty());
}

View File

@@ -0,0 +1,127 @@
use async_trait::async_trait;
use domain::{
errors::DomainError,
events::DomainEvent,
models::{MetadataSearchCriteria, Movie},
ports::{MetadataClient, MovieCommand},
testing::{
FakeMetadataClient, InMemoryStore, RefusingMovieCommand, test_movie_with_external_id,
test_movie_with_year,
},
value_objects::{ExternalMetadataId, PosterUrl},
};
use application::diary::commands::MovieInput;
use application::movies::resolve::resolve_and_persist_movie;
struct MetadataWithExternalId;
#[async_trait]
impl MetadataClient for MetadataWithExternalId {
async fn fetch_movie_metadata(&self, _: &MetadataSearchCriteria) -> Result<Movie, DomainError> {
Ok(test_movie_with_external_id(
"Discovered Film",
2024,
ExternalMetadataId::new("tmdb:99999".into()).unwrap(),
))
}
async fn get_poster_url(
&self,
_: &ExternalMetadataId,
) -> Result<Option<PosterUrl>, DomainError> {
Ok(None)
}
}
fn manual_input(title: &str) -> MovieInput {
MovieInput {
movie_id: None,
external_metadata_id: None,
manual_title: Some(title.into()),
manual_release_year: Some(2024),
manual_director: None,
}
}
#[tokio::test]
async fn a_new_movie_with_an_external_id_is_persisted_with_movie_discovered() {
let store = InMemoryStore::new();
let (movie, is_new) = resolve_and_persist_movie(
&manual_input("Discovered Film"),
store.as_ref(),
store.as_ref(),
&MetadataWithExternalId,
)
.await
.unwrap();
assert!(is_new);
assert_eq!(store.movie_count(), 1);
let recorded = store.recorded_events();
assert_eq!(recorded.len(), 1);
assert!(matches!(
&recorded[0],
DomainEvent::MovieDiscovered { movie_id, .. } if movie_id == movie.id()
));
}
#[tokio::test]
async fn a_new_movie_without_an_external_id_records_no_event() {
let store = InMemoryStore::new();
let (_, is_new) = resolve_and_persist_movie(
&manual_input("Home Movie"),
store.as_ref(),
store.as_ref(),
&FakeMetadataClient,
)
.await
.unwrap();
assert!(is_new);
assert_eq!(store.movie_count(), 1);
assert!(store.recorded_events().is_empty());
}
#[tokio::test]
async fn an_existing_movie_is_not_rewritten_and_records_no_event() {
let store = InMemoryStore::new();
let movie = test_movie_with_year("Known", 2001);
store.upsert_movie(&movie, &[]).await.unwrap();
let input = MovieInput {
movie_id: Some(movie.id().value()),
..manual_input("ignored")
};
let (resolved, is_new) = resolve_and_persist_movie(
&input,
store.as_ref(),
store.as_ref(),
&MetadataWithExternalId,
)
.await
.unwrap();
assert!(!is_new);
assert_eq!(resolved.id(), movie.id());
assert!(store.recorded_events().is_empty());
}
#[tokio::test]
async fn a_refused_upsert_propagates_and_records_nothing() {
let store = InMemoryStore::new();
let result = resolve_and_persist_movie(
&manual_input("Discovered Film"),
&RefusingMovieCommand,
store.as_ref(),
&MetadataWithExternalId,
)
.await;
assert!(matches!(result, Err(DomainError::InfrastructureError(m)) if m == "refused"));
assert_eq!(store.movie_count(), 0);
assert!(store.recorded_events().is_empty());
}

View File

@@ -41,7 +41,7 @@ async fn fails_when_no_external_id() {
let movies = InMemoryStore::new();
let movie = test_movie_with_year("Test", 2024);
let movie_id = movie.id().value();
movies.upsert_movie(&movie).await.unwrap();
movies.upsert_movie(&movie, &[]).await.unwrap();
let deps = SyncPosterDeps {
movie_command: Arc::clone(&movies) as _,
@@ -80,7 +80,7 @@ async fn syncs_poster_for_movie_with_external_id() {
let ext_id = ExternalMetadataId::new("tmdb:999".into()).unwrap();
let movie = test_movie_with_external_id("Poster Movie", 2024, ext_id);
let movie_id = movie.id().value();
movies.upsert_movie(&movie).await.unwrap();
movies.upsert_movie(&movie, &[]).await.unwrap();
let deps = SyncPosterDeps {
movie_command: Arc::clone(&movies) as _,