From c647f4c13b6d3553fd30d237d078f50705341064 Mon Sep 17 00:00:00 2001
From: Gabriel Kaszewski <gabrielkaszewski@gmail.com>
Date: Thu, 4 Jun 2026 17:58:01 +0200
Subject: [PATCH] =?UTF-8?q?fix:=20clippy=201.96=20lints=20=E2=80=94=20map?=
 =?UTF-8?q?=5For,=20duplicate=5Fmod,=20needless=5Fborrows,=20slice=5Frefs?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 crates/adapters/sqlite/src/tests/persons.rs   | 4 ++--
 crates/application/src/test_helpers.rs        | 6 ++++++
 crates/presentation/src/extractors.rs         | 2 +-
 crates/presentation/src/tests/api_handlers.rs | 6 +++---
 crates/presentation/src/tests/mod.rs          | 9 ---------
 crates/tui/src/tests/app.rs                   | 6 +++---
 6 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/crates/adapters/sqlite/src/tests/persons.rs b/crates/adapters/sqlite/src/tests/persons.rs
index 8b355ff..2876deb 100644
--- a/crates/adapters/sqlite/src/tests/persons.rs
+++ b/crates/adapters/sqlite/src/tests/persons.rs
@@ -95,7 +95,7 @@ async fn get_by_id_returns_person() {
     let adapter = SqlitePersonAdapter::new(pool.clone());
 
     let p = make_person(42, "Charlie", Some("Acting"));
-    adapter.upsert_batch(&[p.clone()]).await.unwrap();
+    adapter.upsert_batch(std::slice::from_ref(&p)).await.unwrap();
 
     let found = adapter.get_by_id(p.id()).await.unwrap().unwrap();
     assert_eq!(found.name(), "Charlie");
@@ -117,7 +117,7 @@ async fn get_credits_returns_cast_and_crew() {
     let adapter = SqlitePersonAdapter::new(pool.clone());
 
     let p = make_person(7, "Diana", Some("Acting"));
-    adapter.upsert_batch(&[p.clone()]).await.unwrap();
+    adapter.upsert_batch(std::slice::from_ref(&p)).await.unwrap();
 
     sqlx::query("INSERT INTO movies VALUES ('m1', 'The Film', 2020, 'Dir', NULL, NULL)")
         .execute(&pool)
diff --git a/crates/application/src/test_helpers.rs b/crates/application/src/test_helpers.rs
index c536c5a..7719448 100644
--- a/crates/application/src/test_helpers.rs
+++ b/crates/application/src/test_helpers.rs
@@ -59,6 +59,12 @@ pub struct TestContextBuilder {
     pub config: AppConfig,
 }
 
+impl Default for TestContextBuilder {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl TestContextBuilder {
     pub fn new() -> Self {
         Self {
diff --git a/crates/presentation/src/extractors.rs b/crates/presentation/src/extractors.rs
index 8b92266..d28c04e 100644
--- a/crates/presentation/src/extractors.rs
+++ b/crates/presentation/src/extractors.rs
@@ -156,4 +156,4 @@ where
 
 #[cfg(test)]
 #[path = "tests/extractors.rs"]
-mod tests;
+pub(crate) mod tests;
diff --git a/crates/presentation/src/tests/api_handlers.rs b/crates/presentation/src/tests/api_handlers.rs
index 9209f0d..e8745ed 100644
--- a/crates/presentation/src/tests/api_handlers.rs
+++ b/crates/presentation/src/tests/api_handlers.rs
@@ -1,4 +1,4 @@
-use super::extractors::{Panic, make_test_state};
+use crate::extractors::tests::{Panic, make_test_state};
 use axum::{
     Router,
     body::Body,
@@ -133,7 +133,7 @@ async fn person_endpoint_returns_404_for_unknown_id() {
     let resp = app
         .oneshot(
             Request::builder()
-                .uri(&format!("/api/v1/people/{}", unknown_id))
+                .uri(format!("/api/v1/people/{}", unknown_id))
                 .body(Body::empty())
                 .unwrap(),
         )
@@ -159,7 +159,7 @@ async fn person_credits_endpoint_returns_404_for_unknown_id() {
     let resp = app
         .oneshot(
             Request::builder()
-                .uri(&format!("/api/v1/people/{}/credits", unknown_id))
+                .uri(format!("/api/v1/people/{}/credits", unknown_id))
                 .body(Body::empty())
                 .unwrap(),
         )
diff --git a/crates/presentation/src/tests/mod.rs b/crates/presentation/src/tests/mod.rs
index 6a0034a..1df7f56 100644
--- a/crates/presentation/src/tests/mod.rs
+++ b/crates/presentation/src/tests/mod.rs
@@ -1,10 +1 @@
-// API types for tests
-pub use crate::{
-    extractors::{AuthenticatedUser, OptionalCookieUser, RequiredCookieUser},
-    forms::{LogReviewData, LogReviewForm, to_diary_query},
-};
-pub use api_types::{DiaryQueryParams, LogReviewRequest};
-
 mod api_handlers;
-mod extractors;
-mod forms;
diff --git a/crates/tui/src/tests/app.rs b/crates/tui/src/tests/app.rs
index be6c80f..1cfae76 100644
--- a/crates/tui/src/tests/app.rs
+++ b/crates/tui/src/tests/app.rs
@@ -150,7 +150,7 @@ fn login_submit_with_empty_fields_sets_error_status() {
     let mut app = login_app();
     let cmds = update(&mut app, Action::LoginSubmit);
     assert!(cmds.is_empty());
-    assert!(app.status.as_ref().map_or(false, |s| s.is_error));
+    assert!(app.status.as_ref().is_some_and(|s| s.is_error));
 }
 
 #[test]
@@ -170,7 +170,7 @@ fn auth_fail_sets_error_status_and_clears_loading() {
     app.loading = true;
     update(&mut app, Action::AuthFail("bad creds".into()));
     assert!(!app.loading);
-    assert!(app.status.as_ref().map_or(false, |s| s.is_error));
+    assert!(app.status.as_ref().is_some_and(|s| s.is_error));
 }
 
 // ── Diary ─────────────────────────────────────────────────────────────────
@@ -360,7 +360,7 @@ fn review_submit_with_missing_title_and_id_sets_error() {
     }
     let cmds = update(&mut app, Action::ReviewSubmit);
     assert!(cmds.is_empty());
-    assert!(app.status.as_ref().map_or(false, |s| s.is_error));
+    assert!(app.status.as_ref().is_some_and(|s| s.is_error));
 }
 
 // ── Bulk Import ───────────────────────────────────────────────────────────