refactor: single refusal shape with openapi contract test

crates/adapters/http-axum/src/api/users.rs

@@ -1,3 +1,4 @@
+use crate::extractors::Body;
 use crate::{errors::ApiError, extractors::AuthenticatedUser, state::AppState};
 use api_types::{ProfileResponse, UserSummaryDto, UsersResponse};
 use application::users::{
@@ -14,8 +15,8 @@ use axum::{
     get, path = "/api/v1/profile",
     responses(
         (status = 200, body = ProfileResponse),
-        (status = 401, description = "Unauthorized"),
-        (status = 404, description = "User not found"),
+        (status = 401, description = "Unauthorized", body = api_types::ErrorResponse),
+        (status = 404, description = "User not found", body = api_types::ErrorResponse),
     ),
     security(("bearer_auth" = []))
 )]
@@ -56,9 +57,9 @@ pub async fn get_profile(
     put, path = "/api/v1/profile",
     responses(
         (status = 204, description = "Profile updated"),
-        (status = 400, description = "Invalid input"),
-        (status = 401, description = "Unauthorized"),
-        (status = 500, description = "Internal server error"),
+        (status = 400, description = "Invalid input", body = api_types::ErrorResponse),
+        (status = 401, description = "Unauthorized", body = api_types::ErrorResponse),
+        (status = 500, description = "Internal server error", body = api_types::ErrorResponse),
     ),
     security(("bearer_auth" = []))
 )]
@@ -82,7 +83,7 @@ pub async fn update_profile_handler(
 
     match update_profile::execute(&state.app_ctx.deps.users.update_profile, cmd).await {
         Ok(()) => StatusCode::NO_CONTENT.into_response(),
-        Err(e) => crate::errors::domain_error_response(e),
+        Err(e) => crate::errors::ApiError(e).into_response(),
     }
 }
 
@@ -91,20 +92,26 @@ pub async fn update_profile_handler(
     request_body = api_types::UpdateProfileFieldsRequest,
     responses(
         (status = 204, description = "Profile fields updated"),
-        (status = 400, description = "Invalid input"),
-        (status = 401, description = "Unauthorized"),
-        (status = 500, description = "Internal server error"),
+        (status = 400, description = "Invalid input", body = api_types::ErrorResponse),
+        (status = 401, description = "Unauthorized", body = api_types::ErrorResponse),
+        (status = 500, description = "Internal server error", body = api_types::ErrorResponse),
     ),
     security(("bearer_auth" = []))
 )]
 pub async fn update_profile_fields_handler(
     State(state): State<AppState>,
     AuthenticatedUser(user_id): AuthenticatedUser,
-    axum::Json(body): axum::Json<serde_json::Value>,
+    Body(body): Body<serde_json::Value>,
 ) -> impl IntoResponse {
     let raw_fields = match body.get("fields").and_then(|f| f.as_array()) {
         Some(arr) => arr.clone(),
-        None => return StatusCode::BAD_REQUEST.into_response(),
+        None => {
+            return crate::errors::refuse(
+                StatusCode::BAD_REQUEST,
+                crate::errors::INVALID_INPUT,
+                "body must contain a fields array",
+            );
+        }
     };
 
     let fields: Vec<domain::models::ProfileField> = raw_fields
@@ -124,13 +131,16 @@ pub async fn update_profile_fields_handler(
     match update_profile_fields::execute(&state.app_ctx.deps.users.update_profile_fields, cmd).await
     {
         Ok(()) => StatusCode::NO_CONTENT.into_response(),
-        Err(e) => crate::errors::domain_error_response(e),
+        Err(e) => crate::errors::ApiError(e).into_response(),
     }
 }
 
 #[utoipa::path(
     get, path = "/api/v1/users",
-    responses((status = 200, body = UsersResponse)),
+    responses(
+        (status = 200, body = UsersResponse),
+        (status = 429, description = "Rate limited", body = api_types::ErrorResponse),
+    ),
 )]
 pub async fn list_users(State(state): State<AppState>) -> Result<Json<UsersResponse>, ApiError> {
     let result =