add 400+ unit tests for domain and application layers

Extract ReviewLogger trait to decouple import/integrations
from diary::log_review (cross-module coupling smell).

Add in-memory fakes for all repository ports, enabling
isolated testing of every use case module without a database.

Coverage: domain+application 22% → 80%, 427 tests.

crates/application/src/movies/tests/enrich_movie.rs

@@ -0,0 +1,151 @@
+use std::sync::Arc;
+
+use chrono::Utc;
+use domain::{
+    models::{Movie, MovieProfile},
+    ports::MovieRepository,
+    testing::{
+        FakeSearchCommand, InMemoryMovieProfileRepository, InMemoryMovieRepository,
+        PanicPersonCommand,
+    },
+    value_objects::{MovieId, MovieTitle, ReleaseYear},
+};
+
+use crate::movies::{commands::EnrichMovieCommand, enrich_movie};
+
+#[tokio::test]
+async fn stores_profile_and_indexes() {
+    let movie_repo = InMemoryMovieRepository::new();
+    let profile_repo = InMemoryMovieProfileRepository::new();
+    let search_cmd: Arc<dyn domain::ports::SearchCommand> = Arc::new(FakeSearchCommand);
+    // PanicPersonCommand is safe here — empty cast/crew means upsert_batch is never called
+    let person_cmd: Arc<dyn domain::ports::PersonCommand> = Arc::new(PanicPersonCommand);
+
+    let movie = Movie::new(
+        None,
+        MovieTitle::new("Test".into()).unwrap(),
+        ReleaseYear::new(2024).unwrap(),
+        None,
+        None,
+    );
+    let movie_id = MovieId::from_uuid(movie.id().value());
+    movie_repo.upsert_movie(&movie).await.unwrap();
+
+    let profile = MovieProfile {
+        movie_id: movie_id.clone(),
+        tmdb_id: 999,
+        imdb_id: None,
+        overview: Some("A test movie".into()),
+        tagline: None,
+        runtime_minutes: Some(120),
+        budget_usd: None,
+        revenue_usd: None,
+        vote_average: Some(7.5),
+        vote_count: Some(100),
+        original_language: Some("en".into()),
+        collection_name: None,
+        genres: vec![],
+        keywords: vec![],
+        cast: vec![],
+        crew: vec![],
+        enriched_at: Utc::now(),
+    };
+
+    enrich_movie::execute(
+        &(movie_repo as Arc<_>),
+        &(profile_repo.clone() as Arc<_>),
+        &person_cmd,
+        &search_cmd,
+        EnrichMovieCommand {
+            movie_id: movie_id.clone(),
+            profile,
+        },
+    )
+    .await
+    .unwrap();
+
+    assert_eq!(profile_repo.count(), 1);
+}
+
+struct NoopPersonCommand;
+
+#[async_trait::async_trait]
+impl domain::ports::PersonCommand for NoopPersonCommand {
+    async fn upsert_batch(
+        &self,
+        _: &[domain::models::Person],
+    ) -> Result<(), domain::errors::DomainError> {
+        Ok(())
+    }
+    async fn backfill_from_credits_batch(
+        &self,
+        _: u32,
+    ) -> Result<(u64, bool), domain::errors::DomainError> {
+        Ok((0, false))
+    }
+}
+
+#[tokio::test]
+async fn extracts_and_indexes_persons() {
+    let movie_repo = InMemoryMovieRepository::new();
+    let profile_repo = InMemoryMovieProfileRepository::new();
+    let search_cmd: Arc<dyn domain::ports::SearchCommand> = Arc::new(FakeSearchCommand);
+    let person_cmd: Arc<dyn domain::ports::PersonCommand> = Arc::new(NoopPersonCommand);
+
+    let movie = Movie::new(
+        None,
+        MovieTitle::new("Cast Movie".into()).unwrap(),
+        ReleaseYear::new(2024).unwrap(),
+        None,
+        None,
+    );
+    let movie_id = MovieId::from_uuid(movie.id().value());
+    movie_repo.upsert_movie(&movie).await.unwrap();
+
+    let profile = MovieProfile {
+        movie_id: movie_id.clone(),
+        tmdb_id: 1001,
+        imdb_id: None,
+        overview: None,
+        tagline: None,
+        runtime_minutes: None,
+        budget_usd: None,
+        revenue_usd: None,
+        vote_average: None,
+        vote_count: None,
+        original_language: None,
+        collection_name: None,
+        genres: vec![],
+        keywords: vec![],
+        cast: vec![domain::models::CastMember {
+            tmdb_person_id: 42,
+            name: "Actor One".into(),
+            character: "Hero".into(),
+            billing_order: 0,
+            profile_path: None,
+        }],
+        crew: vec![domain::models::CrewMember {
+            tmdb_person_id: 99,
+            name: "Director One".into(),
+            job: "Director".into(),
+            department: "Directing".into(),
+            profile_path: None,
+        }],
+        enriched_at: Utc::now(),
+    };
+
+    enrich_movie::execute(
+        &(movie_repo as Arc<_>),
+        &(profile_repo.clone() as Arc<_>),
+        &person_cmd,
+        &search_cmd,
+        EnrichMovieCommand {
+            movie_id: movie_id.clone(),
+            profile,
+        },
+    )
+    .await
+    .unwrap();
+
+    assert_eq!(profile_repo.count(), 1);
+}

crates/application/src/movies/tests/get_movie_profile.rs

@@ -0,0 +1,92 @@
+use std::sync::Arc;
+
+use chrono::Utc;
+use uuid::Uuid;
+
+use domain::{
+    models::{CastMember, CrewMember, MovieProfile},
+    ports::MovieProfileRepository,
+    testing::InMemoryMovieProfileRepository,
+    value_objects::MovieId,
+};
+
+use crate::{
+    movies::get_movie_profile::{self, GetMovieProfileQuery},
+    test_helpers::TestContextBuilder,
+};
+
+#[tokio::test]
+async fn returns_none_when_no_profile() {
+    let ctx = TestContextBuilder::new().build();
+
+    let result = get_movie_profile::execute(
+        &ctx,
+        GetMovieProfileQuery {
+            movie_id: Uuid::new_v4(),
+        },
+    )
+    .await
+    .unwrap();
+
+    assert!(result.is_none());
+}
+
+#[tokio::test]
+async fn returns_profile_with_cast_and_crew() {
+    let profile_repo = InMemoryMovieProfileRepository::new();
+    let movie_id = MovieId::generate();
+
+    let profile = MovieProfile {
+        movie_id: movie_id.clone(),
+        tmdb_id: 42,
+        imdb_id: Some("tt1234567".into()),
+        overview: Some("A great movie".into()),
+        tagline: None,
+        runtime_minutes: Some(120),
+        budget_usd: None,
+        revenue_usd: None,
+        vote_average: Some(8.0),
+        vote_count: Some(500),
+        original_language: Some("en".into()),
+        collection_name: None,
+        genres: vec![],
+        keywords: vec![],
+        cast: vec![CastMember {
+            tmdb_person_id: 1,
+            name: "Alice".into(),
+            character: "Hero".into(),
+            billing_order: 0,
+            profile_path: None,
+        }],
+        crew: vec![CrewMember {
+            tmdb_person_id: 2,
+            name: "Bob".into(),
+            job: "Director".into(),
+            department: "Directing".into(),
+            profile_path: None,
+        }],
+        enriched_at: Utc::now(),
+    };
+    profile_repo.upsert(&profile).await.unwrap();
+
+    let ctx = TestContextBuilder::new()
+        .with_movie_profiles(Arc::clone(&profile_repo) as _)
+        .build();
+
+    let result = get_movie_profile::execute(
+        &ctx,
+        GetMovieProfileQuery {
+            movie_id: movie_id.value(),
+        },
+    )
+    .await
+    .unwrap();
+
+    let res = result.expect("profile should be present");
+    assert_eq!(res.cast.len(), 1);
+    assert_eq!(res.cast[0].name, "Alice");
+    assert_eq!(res.cast[0].character, "Hero");
+    assert_eq!(res.crew.len(), 1);
+    assert_eq!(res.crew[0].name, "Bob");
+    assert_eq!(res.crew[0].job, "Director");
+}

crates/application/src/movies/tests/get_movies.rs

@@ -0,0 +1,24 @@
+use crate::{
+    movies::{get_movies, queries::GetMoviesQuery},
+    test_helpers::TestContextBuilder,
+};
+
+#[tokio::test]
+async fn returns_empty_when_no_movies() {
+    let ctx = TestContextBuilder::new().build();
+
+    let result = get_movies::execute(
+        &ctx,
+        GetMoviesQuery {
+            limit: None,
+            offset: None,
+            search: None,
+            genre: None,
+            language: None,
+        },
+    )
+    .await
+    .unwrap();
+
+    assert!(result.items.is_empty());
+}

crates/application/src/movies/tests/request_enrichment.rs

@@ -0,0 +1,103 @@
+use std::sync::Arc;
+
+use async_trait::async_trait;
+use chrono::Utc;
+use domain::{
+    errors::DomainError,
+    models::MovieProfile,
+    ports::{MovieEnrichmentClient, MovieProfileRepository},
+    testing::{FakeMovieEnrichmentClient, InMemoryMovieProfileRepository},
+    value_objects::MovieId,
+};
+
+use crate::movies::request_enrichment;
+
+#[tokio::test]
+async fn returns_profile_when_none_cached() {
+    let enrichment = FakeMovieEnrichmentClient;
+    let profile_repo = InMemoryMovieProfileRepository::new();
+    let movie_id = MovieId::generate();
+
+    let result = request_enrichment::fetch_if_stale(
+        &enrichment,
+        &(profile_repo as Arc<_>),
+        movie_id.clone(),
+        "tmdb:12345",
+    )
+    .await
+    .unwrap();
+
+    assert!(result.is_some());
+    assert_eq!(result.unwrap().movie_id, movie_id);
+}
+
+#[tokio::test]
+async fn returns_none_when_profile_is_fresh() {
+    let enrichment = FakeMovieEnrichmentClient;
+    let profile_repo = InMemoryMovieProfileRepository::new();
+    let movie_id = MovieId::generate();
+
+    // Seed a fresh profile (enriched_at = now)
+    let fresh_profile = MovieProfile {
+        movie_id: movie_id.clone(),
+        tmdb_id: 12345,
+        imdb_id: None,
+        overview: None,
+        tagline: None,
+        runtime_minutes: None,
+        budget_usd: None,
+        revenue_usd: None,
+        vote_average: None,
+        vote_count: None,
+        original_language: None,
+        collection_name: None,
+        genres: vec![],
+        keywords: vec![],
+        cast: vec![],
+        crew: vec![],
+        enriched_at: Utc::now(),
+    };
+    profile_repo.upsert(&fresh_profile).await.unwrap();
+
+    let result = request_enrichment::fetch_if_stale(
+        &enrichment,
+        &(Arc::clone(&profile_repo) as Arc<_>),
+        movie_id,
+        "tmdb:12345",
+    )
+    .await
+    .unwrap();
+
+    assert!(result.is_none(), "fresh profile should be skipped");
+}
+
+struct NotFoundEnrichmentClient;
+
+#[async_trait]
+impl MovieEnrichmentClient for NotFoundEnrichmentClient {
+    async fn fetch_profile(
+        &self,
+        _movie_id: MovieId,
+        _external_metadata_id: &str,
+    ) -> Result<MovieProfile, DomainError> {
+        Err(DomainError::NotFound("not found in TMDb".into()))
+    }
+}
+
+#[tokio::test]
+async fn returns_none_on_not_found_from_client() {
+    let enrichment = NotFoundEnrichmentClient;
+    let profile_repo = InMemoryMovieProfileRepository::new();
+    let movie_id = MovieId::generate();
+
+    let result = request_enrichment::fetch_if_stale(
+        &enrichment,
+        &(profile_repo as Arc<_>),
+        movie_id,
+        "tmdb:99999",
+    )
+    .await
+    .unwrap();
+
+    assert!(result.is_none(), "NotFound should return Ok(None), not Err");
+}

crates/application/src/movies/tests/sync_poster.rs

@@ -0,0 +1,103 @@
+use std::sync::Arc;
+
+use uuid::Uuid;
+
+use domain::{
+    errors::DomainError,
+    models::Movie,
+    ports::{MetadataClient, MovieRepository},
+    testing::InMemoryMovieRepository,
+    value_objects::{ExternalMetadataId, MovieTitle, PosterUrl, ReleaseYear},
+};
+
+use crate::{
+    diary::commands::SyncPosterCommand, movies::sync_poster, test_helpers::TestContextBuilder,
+};
+
+#[tokio::test]
+async fn fails_when_movie_not_found() {
+    let ctx = TestContextBuilder::new().build();
+
+    let result = sync_poster::execute(
+        &ctx,
+        SyncPosterCommand {
+            movie_id: Uuid::new_v4(),
+        },
+    )
+    .await;
+
+    assert!(result.is_err());
+}
+
+#[tokio::test]
+async fn fails_when_no_external_id() {
+    let movies = InMemoryMovieRepository::new();
+    let movie = Movie::new(
+        None,
+        MovieTitle::new("Test".into()).unwrap(),
+        ReleaseYear::new(2024).unwrap(),
+        None,
+        None,
+    );
+    let movie_id = movie.id().value();
+    movies.upsert_movie(&movie).await.unwrap();
+
+    let ctx = TestContextBuilder::new()
+        .with_movies(Arc::clone(&movies) as _)
+        .build();
+
+    let result = sync_poster::execute(&ctx, SyncPosterCommand { movie_id }).await;
+
+    assert!(result.is_err());
+}
+
+struct FakeMetaWithPoster;
+
+#[async_trait::async_trait]
+impl MetadataClient for FakeMetaWithPoster {
+    async fn fetch_movie_metadata(
+        &self,
+        _: &domain::ports::MetadataSearchCriteria,
+    ) -> Result<Movie, DomainError> {
+        unimplemented!()
+    }
+    async fn get_poster_url(
+        &self,
+        _: &ExternalMetadataId,
+    ) -> Result<Option<PosterUrl>, DomainError> {
+        Ok(Some(
+            PosterUrl::new("https://example.com/poster.jpg".into()).unwrap(),
+        ))
+    }
+}
+
+#[tokio::test]
+async fn syncs_poster_for_movie_with_external_id() {
+    let movies = InMemoryMovieRepository::new();
+    let ext_id = ExternalMetadataId::new("tmdb:999".into()).unwrap();
+    let movie = Movie::new(
+        Some(ext_id),
+        MovieTitle::new("Poster Movie".into()).unwrap(),
+        ReleaseYear::new(2024).unwrap(),
+        None,
+        None,
+    );
+    let movie_id = movie.id().value();
+    movies.upsert_movie(&movie).await.unwrap();
+
+    let ctx = TestContextBuilder::new()
+        .with_movies(Arc::clone(&movies) as _)
+        .with_metadata_client(Arc::new(FakeMetaWithPoster) as _)
+        .build();
+
+    sync_poster::execute(&ctx, SyncPosterCommand { movie_id })
+        .await
+        .unwrap();
+
+    let updated = movies
+        .get_movie_by_id(&domain::value_objects::MovieId::from_uuid(movie_id))
+        .await
+        .unwrap()
+        .unwrap();
+    assert!(updated.poster_path().is_some());
+}