Replace magic numbers with named constants #19

New Issue

GKaszewski · 2026-07-25T11:18:51Z

GKaszewski commented

2026-07-25 11:18:51 +00:00

Severity: Low

crates/infra-wiring/src/config.rs: 2_592_000u64 as the default refresh_ttl_seconds. This is 30 days in seconds. Use const DEFAULT_REFRESH_TTL_SECS: u64 = 30 * 24 * 60 * 60;
crates/worker/src/main.rs: PosterSyncHandler::new(...) ends with a bare 3 argument. Without reading the handler's signature, there's no way to know what this means (retry count? concurrency limit?). Use a named variable.

**Severity: Low** - `crates/infra-wiring/src/config.rs`: `2_592_000u64` as the default `refresh_ttl_seconds`. This is 30 days in seconds. Use `const DEFAULT_REFRESH_TTL_SECS: u64 = 30 * 24 * 60 * 60;` - `crates/worker/src/main.rs`: `PosterSyncHandler::new(...)` ends with a bare `3` argument. Without reading the handler's signature, there's no way to know what this means (retry count? concurrency limit?). Use a named variable.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GKaszewski/movies-diary#19