Refactor handlers and OpenAPI documentation for improved readability and consistency

- Reorganized imports in health, notifications, social, thoughts, and users handlers for clarity.
- Updated function signatures in handlers to improve readability by aligning parameters.
- Enhanced JSON response formatting in notifications and thoughts handlers.
- Improved error handling in user-related functions.
- Refactored OpenAPI documentation to maintain consistent formatting and structure.
- Cleaned up unnecessary code and comments across various files.
- Ensured consistent use of `Arc` for shared state in AppState and WorkerHandlers.

crates/adapters/activitypub-base/src/service.rs

@@ -154,9 +154,17 @@ impl ActivityPubService {
             .map_err(|e| anyhow::anyhow!("{e}"))?;
 
         let followers = data.federation_repo.get_followers(local_user_id).await?;
-        let blocked = data.federation_repo.get_blocked_actors(local_user_id).await.unwrap_or_default();
+        let blocked = data
+            .federation_repo
+            .get_blocked_actors(local_user_id)
+            .await
+            .unwrap_or_default();
         let blocked_set: std::collections::HashSet<String> = blocked.into_iter().collect();
-        let blocked_domains = data.federation_repo.get_blocked_domains().await.unwrap_or_default();
+        let blocked_domains = data
+            .federation_repo
+            .get_blocked_domains()
+            .await
+            .unwrap_or_default();
         let blocked_domain_set: std::collections::HashSet<String> =
             blocked_domains.into_iter().map(|d| d.domain).collect();
 
@@ -225,14 +233,18 @@ impl ActivityPubService {
         .map_err(|e| anyhow::anyhow!("{e}"))?;
 
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self.accepted_follower_inboxes(&data, local_user_id).await? else {
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, local_user_id).await?
+        else {
             return Ok(());
         };
 
         let announce = crate::activities::AnnounceActivity {
             id: announce_id,
             kind: Default::default(),
-            actor: activitypub_federation::fetch::object_id::ObjectId::from(local_actor.ap_id.clone()),
+            actor: activitypub_federation::fetch::object_id::ObjectId::from(
+                local_actor.ap_id.clone(),
+            ),
             object: object_ap_id,
             published: Some(chrono::Utc::now()),
             to: vec![crate::urls::AS_PUBLIC.to_string()],
@@ -270,17 +282,22 @@ impl ActivityPubService {
         ))
         .map_err(|e| anyhow::anyhow!("{e}"))?;
 
-        let undo_id = crate::urls::activity_url(&self.base_url).map_err(|e| anyhow::anyhow!("{e}"))?;
+        let undo_id =
+            crate::urls::activity_url(&self.base_url).map_err(|e| anyhow::anyhow!("{e}"))?;
 
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self.accepted_follower_inboxes(&data, local_user_id).await? else {
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, local_user_id).await?
+        else {
             return Ok(());
         };
 
         let undo = crate::activities::UndoActivity {
             id: undo_id,
             kind: Default::default(),
-            actor: activitypub_federation::fetch::object_id::ObjectId::from(local_actor.ap_id.clone()),
+            actor: activitypub_federation::fetch::object_id::ObjectId::from(
+                local_actor.ap_id.clone(),
+            ),
             object: serde_json::json!({
                 "type": "Announce",
                 "id": announce_id.to_string(),
@@ -298,7 +315,10 @@ impl ActivityPubService {
         .await?;
         let failures = send_with_retry(sends, &data).await;
         if !failures.is_empty() {
-            tracing::warn!(count = failures.len(), "some Undo(Announce) deliveries failed");
+            tracing::warn!(
+                count = failures.len(),
+                "some Undo(Announce) deliveries failed"
+            );
         }
         Ok(())
     }
@@ -620,7 +640,9 @@ impl ActivityPubService {
         ap_id: Url,
     ) -> anyhow::Result<()> {
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self.accepted_follower_inboxes(&data, local_user_id).await? else {
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, local_user_id).await?
+        else {
             return Ok(());
         };
 
@@ -655,7 +677,9 @@ impl ActivityPubService {
         object: serde_json::Value,
     ) -> anyhow::Result<()> {
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self.accepted_follower_inboxes(&data, local_user_id).await? else {
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, local_user_id).await?
+        else {
             return Ok(());
         };
 
@@ -683,7 +707,9 @@ impl ActivityPubService {
         watchlist_entry_ap_id: Url,
     ) -> anyhow::Result<()> {
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self.accepted_follower_inboxes(&data, local_user_id).await? else {
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, local_user_id).await?
+        else {
             return Ok(());
         };
 
@@ -1157,10 +1183,10 @@ impl domain::ports::OutboundFederationPort for ActivityPubService {
     ) -> Result<(), domain::errors::DomainError> {
         let user_uuid = author_user_id.as_uuid();
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self
-            .accepted_follower_inboxes(&data, user_uuid)
-            .await
-            .map_err(|e| domain::errors::DomainError::Internal(e.to_string()))?
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, user_uuid)
+                .await
+                .map_err(|e| domain::errors::DomainError::Internal(e.to_string()))?
         else {
             return Ok(());
         };
@@ -1171,7 +1197,9 @@ impl domain::ports::OutboundFederationPort for ActivityPubService {
         let create = crate::activities::CreateActivity {
             id: ap_id,
             kind: Default::default(),
-            actor: activitypub_federation::fetch::object_id::ObjectId::from(local_actor.ap_id.clone()),
+            actor: activitypub_federation::fetch::object_id::ObjectId::from(
+                local_actor.ap_id.clone(),
+            ),
             object: note,
             to: vec![crate::urls::AS_PUBLIC.to_string()],
             cc: vec![local_actor.followers_url.to_string()],
@@ -1214,10 +1242,10 @@ impl domain::ports::OutboundFederationPort for ActivityPubService {
     ) -> Result<(), domain::errors::DomainError> {
         let user_uuid = author_user_id.as_uuid();
         let data = self.federation_config.to_request_data();
-        let Some((local_actor, inboxes)) = self
-            .accepted_follower_inboxes(&data, user_uuid)
-            .await
-            .map_err(|e| domain::errors::DomainError::Internal(e.to_string()))?
+        let Some((local_actor, inboxes)) =
+            self.accepted_follower_inboxes(&data, user_uuid)
+                .await
+                .map_err(|e| domain::errors::DomainError::Internal(e.to_string()))?
         else {
             return Ok(());
         };
@@ -1234,7 +1262,9 @@ impl domain::ports::OutboundFederationPort for ActivityPubService {
         let update = crate::activities::UpdateActivity {
             id: update_id,
             kind: Default::default(),
-            actor: activitypub_federation::fetch::object_id::ObjectId::from(local_actor.ap_id.clone()),
+            actor: activitypub_federation::fetch::object_id::ObjectId::from(
+                local_actor.ap_id.clone(),
+            ),
             object: note,
             to: vec![crate::urls::AS_PUBLIC.to_string()],
             cc: vec![local_actor.followers_url.to_string()],