Refactor database error handling across repositories to use IntoDbResult for improved error management

- Updated PgNotificationRepository to utilize IntoDbResult for error handling in various methods.
- Refactored PgRemoteActorRepository to replace manual error mapping with IntoDbResult.
- Modified PgRemoteActorConnectionRepository to implement IntoDbResult for error handling.
- Adjusted PgTagRepository to use IntoDbResult for consistent error management.
- Introduced test_helpers module for seeding users and thoughts in tests.
- Enhanced PgThoughtRepository to leverage IntoDbResult for error handling.
- Updated PgTopFriendRepository to utilize IntoDbResult for error management.
- Refactored PgUserRepository to implement IntoDbResult for error handling.
- Added constants for pagination defaults in requests.
- Introduced MAX_TOP_FRIENDS constant for top friends validation.
- Refactored JWT expiration time to use a constant.
- Improved rate limiter configuration with constants for better readability.
- Added utility methods for FollowState and Visibility enums for string conversions.
- Introduced maximum length constants for Username, Email, and Content value objects.
- Cleaned up test modules by removing redundant code and utilizing a shared testing state.

crates/presentation/src/handlers/federation_actors.rs

@@ -92,63 +92,10 @@ async fn actor_connections_handler(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use async_trait::async_trait;
+    use crate::testing::make_state;
     use axum::{body::Body, http::Request, routing::get, Router};
-    use domain::{
-        errors::DomainError,
-        ports::{AuthService, GeneratedToken, PasswordHasher},
-        testing::TestStore,
-        value_objects::{PasswordHash, UserId},
-    };
-    use std::sync::Arc;
     use tower::ServiceExt;
 
-    struct NoOpAuth;
-    impl AuthService for NoOpAuth {
-        fn generate_token(&self, _uid: &UserId) -> Result<GeneratedToken, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        fn validate_token(&self, _token: &str) -> Result<UserId, DomainError> {
-            Err(DomainError::Unauthorized)
-        }
-    }
-
-    struct NoOpHasher;
-    #[async_trait]
-    impl PasswordHasher for NoOpHasher {
-        async fn hash(&self, _plain: &str) -> Result<PasswordHash, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        async fn verify(&self, _plain: &str, _hash: &PasswordHash) -> Result<bool, DomainError> {
-            Ok(false)
-        }
-    }
-
-    fn make_state() -> crate::state::AppState {
-        let store = Arc::new(TestStore::default());
-        crate::state::AppState {
-            users: store.clone(),
-            thoughts: store.clone(),
-            likes: store.clone(),
-            boosts: store.clone(),
-            follows: store.clone(),
-            blocks: store.clone(),
-            tags: store.clone(),
-            api_keys: store.clone(),
-            top_friends: store.clone(),
-            notifications: store.clone(),
-            remote_actors: store.clone(),
-            feed: store.clone(),
-            search: store.clone(),
-            auth: Arc::new(NoOpAuth),
-            hasher: Arc::new(NoOpHasher),
-            events: store.clone(),
-            federation: store.clone(),
-            ap_repo: store.clone(),
-            remote_actor_connections: store.clone(),
-        }
-    }
-
     fn app() -> Router {
         Router::new()
             .route(

crates/presentation/src/handlers/feed.rs

@@ -98,8 +98,8 @@ pub async fn search_handler(
     Query(q): Query<SearchQuery>,
 ) -> Result<Json<serde_json::Value>, ApiError> {
     let page = PageParams {
-        page: q.page.unwrap_or(1),
-        per_page: q.per_page.unwrap_or(20),
+        page: q.page.unwrap_or(api_types::requests::DEFAULT_PAGE),
+        per_page: q.per_page.unwrap_or(api_types::requests::DEFAULT_PER_PAGE),
     };
     let query = q.q.trim().to_string();
 
@@ -257,8 +257,12 @@ pub async fn get_popular_tags(
     let limit: usize = params
         .get("limit")
         .and_then(|v| v.parse().ok())
-        .unwrap_or(20);
-    let tags = uc_get_popular_tags(&*s.tags, limit.min(100)).await?;
+        .unwrap_or(api_types::requests::DEFAULT_PER_PAGE as usize);
+    let tags = uc_get_popular_tags(
+        &*s.tags,
+        limit.min(api_types::requests::MAX_PER_PAGE as usize),
+    )
+    .await?;
     Ok(Json(serde_json::json!({
         "tags": tags.iter().map(|(name, count)| serde_json::json!({
             "name": name,

crates/presentation/src/handlers/notifications.rs

@@ -59,68 +59,15 @@ pub async fn mark_all_read(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use async_trait::async_trait;
+    use crate::testing::make_state;
     use axum::{
         body::Body,
         http::{header, Request},
         routing::{get, patch},
         Router,
     };
-    use domain::{
-        errors::DomainError,
-        ports::{AuthService, GeneratedToken, PasswordHasher},
-        testing::TestStore,
-        value_objects::{PasswordHash, UserId},
-    };
-    use std::sync::Arc;
     use tower::ServiceExt;
 
-    struct NoOpAuth;
-    impl AuthService for NoOpAuth {
-        fn generate_token(&self, _uid: &UserId) -> Result<GeneratedToken, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        fn validate_token(&self, _token: &str) -> Result<UserId, DomainError> {
-            Err(DomainError::Unauthorized)
-        }
-    }
-
-    struct NoOpHasher;
-    #[async_trait]
-    impl PasswordHasher for NoOpHasher {
-        async fn hash(&self, _plain: &str) -> Result<PasswordHash, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        async fn verify(&self, _plain: &str, _hash: &PasswordHash) -> Result<bool, DomainError> {
-            Ok(false)
-        }
-    }
-
-    fn make_state() -> crate::state::AppState {
-        let store = Arc::new(TestStore::default());
-        crate::state::AppState {
-            users: store.clone(),
-            thoughts: store.clone(),
-            likes: store.clone(),
-            boosts: store.clone(),
-            follows: store.clone(),
-            blocks: store.clone(),
-            tags: store.clone(),
-            api_keys: store.clone(),
-            top_friends: store.clone(),
-            notifications: store.clone(),
-            remote_actors: store.clone(),
-            feed: store.clone(),
-            search: store.clone(),
-            auth: Arc::new(NoOpAuth),
-            hasher: Arc::new(NoOpHasher),
-            events: store.clone(),
-            federation: store.clone(),
-            ap_repo: store.clone(),
-            remote_actor_connections: store.clone(),
-        }
-    }
-
     fn app() -> Router {
         Router::new()
             .route("/notifications", patch(mark_all_read))

crates/presentation/src/handlers/social.rs

@@ -132,68 +132,15 @@ pub async fn get_top_friends_handler(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use async_trait::async_trait;
+    use crate::testing::make_state;
     use axum::{
         body::Body,
         http::Request,
         routing::{delete, post},
         Router,
     };
-    use domain::{
-        errors::DomainError,
-        ports::{AuthService, GeneratedToken, PasswordHasher},
-        testing::TestStore,
-        value_objects::{PasswordHash, UserId},
-    };
-    use std::sync::Arc;
     use tower::ServiceExt;
 
-    struct NoOpAuth;
-    impl AuthService for NoOpAuth {
-        fn generate_token(&self, _uid: &UserId) -> Result<GeneratedToken, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        fn validate_token(&self, _token: &str) -> Result<UserId, DomainError> {
-            Err(DomainError::Unauthorized)
-        }
-    }
-
-    struct NoOpHasher;
-    #[async_trait]
-    impl PasswordHasher for NoOpHasher {
-        async fn hash(&self, _plain: &str) -> Result<PasswordHash, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        async fn verify(&self, _plain: &str, _hash: &PasswordHash) -> Result<bool, DomainError> {
-            Ok(false)
-        }
-    }
-
-    fn make_state() -> crate::state::AppState {
-        let store = Arc::new(TestStore::default());
-        crate::state::AppState {
-            users: store.clone(),
-            thoughts: store.clone(),
-            likes: store.clone(),
-            boosts: store.clone(),
-            follows: store.clone(),
-            blocks: store.clone(),
-            tags: store.clone(),
-            api_keys: store.clone(),
-            top_friends: store.clone(),
-            notifications: store.clone(),
-            remote_actors: store.clone(),
-            feed: store.clone(),
-            search: store.clone(),
-            auth: Arc::new(NoOpAuth),
-            hasher: Arc::new(NoOpHasher),
-            events: store.clone(),
-            federation: store.clone(),
-            ap_repo: store.clone(),
-            remote_actor_connections: store.clone(),
-        }
-    }
-
     fn app() -> Router {
         Router::new()
             .route(

crates/presentation/src/handlers/users.rs

@@ -209,68 +209,15 @@ pub async fn lookup_handler(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use async_trait::async_trait;
+    use crate::testing::make_state;
     use axum::{
         body::Body,
         http::{header, Request},
         routing::get,
         Router,
     };
-    use domain::{
-        errors::DomainError,
-        ports::{AuthService, GeneratedToken, PasswordHasher},
-        testing::TestStore,
-        value_objects::{PasswordHash, UserId},
-    };
-    use std::sync::Arc;
     use tower::ServiceExt;
 
-    struct NoOpAuth;
-    impl AuthService for NoOpAuth {
-        fn generate_token(&self, _uid: &UserId) -> Result<GeneratedToken, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        fn validate_token(&self, _token: &str) -> Result<UserId, DomainError> {
-            Err(DomainError::Unauthorized)
-        }
-    }
-
-    struct NoOpHasher;
-    #[async_trait]
-    impl PasswordHasher for NoOpHasher {
-        async fn hash(&self, _plain: &str) -> Result<PasswordHash, DomainError> {
-            Err(DomainError::Internal("noop".into()))
-        }
-        async fn verify(&self, _plain: &str, _hash: &PasswordHash) -> Result<bool, DomainError> {
-            Ok(false)
-        }
-    }
-
-    fn make_state() -> crate::state::AppState {
-        let store = Arc::new(TestStore::default());
-        crate::state::AppState {
-            users: store.clone(),
-            thoughts: store.clone(),
-            likes: store.clone(),
-            boosts: store.clone(),
-            follows: store.clone(),
-            blocks: store.clone(),
-            tags: store.clone(),
-            api_keys: store.clone(),
-            top_friends: store.clone(),
-            notifications: store.clone(),
-            remote_actors: store.clone(),
-            feed: store.clone(),
-            search: store.clone(),
-            auth: Arc::new(NoOpAuth),
-            hasher: Arc::new(NoOpHasher),
-            events: store.clone(),
-            federation: store.clone(),
-            ap_repo: store.clone(),
-            remote_actor_connections: store.clone(),
-        }
-    }
-
     fn app() -> Router {
         Router::new()
             .route("/users/{username}", get(get_user))

crates/presentation/src/lib.rs

@@ -4,3 +4,5 @@ pub mod handlers;
 pub mod openapi;
 pub mod routes;
 pub mod state;
+#[cfg(test)]
+pub mod testing;

crates/presentation/src/testing.rs

@@ -0,0 +1,55 @@
+use crate::state::AppState;
+use async_trait::async_trait;
+use domain::{
+    errors::DomainError,
+    ports::{AuthService, GeneratedToken, PasswordHasher},
+    testing::TestStore,
+    value_objects::{PasswordHash, UserId},
+};
+use std::sync::Arc;
+
+pub struct NoOpAuth;
+impl AuthService for NoOpAuth {
+    fn generate_token(&self, _uid: &UserId) -> Result<GeneratedToken, DomainError> {
+        Err(DomainError::Internal("noop".into()))
+    }
+    fn validate_token(&self, _token: &str) -> Result<UserId, DomainError> {
+        Err(DomainError::Unauthorized)
+    }
+}
+
+pub struct NoOpHasher;
+#[async_trait]
+impl PasswordHasher for NoOpHasher {
+    async fn hash(&self, _plain: &str) -> Result<PasswordHash, DomainError> {
+        Err(DomainError::Internal("noop".into()))
+    }
+    async fn verify(&self, _plain: &str, _hash: &PasswordHash) -> Result<bool, DomainError> {
+        Ok(false)
+    }
+}
+
+pub fn make_state() -> AppState {
+    let store = Arc::new(TestStore::default());
+    AppState {
+        users: store.clone(),
+        thoughts: store.clone(),
+        likes: store.clone(),
+        boosts: store.clone(),
+        follows: store.clone(),
+        blocks: store.clone(),
+        tags: store.clone(),
+        api_keys: store.clone(),
+        top_friends: store.clone(),
+        notifications: store.clone(),
+        remote_actors: store.clone(),
+        feed: store.clone(),
+        search: store.clone(),
+        auth: Arc::new(NoOpAuth),
+        hasher: Arc::new(NoOpHasher),
+        events: store.clone(),
+        federation: store.clone(),
+        ap_repo: store.clone(),
+        remote_actor_connections: store.clone(),
+    }
+}