fix(nats): explicit consumer config, ack timeouts, unknown-event acking, delivery_count

crates/adapters/event-transport/src/lib.rs

@@ -48,6 +48,7 @@ impl<T: Transport> EventPublisher for EventPublisherAdapter<T> {
 pub struct RawMessage {
     pub subject: String,
     pub payload: Vec<u8>,
+    pub delivery_count: u64,
     pub ack: Box<dyn Fn() + Send + Sync>,
     pub nack: Box<dyn Fn() + Send + Sync>,
 }
@@ -83,19 +84,22 @@ impl<S: MessageSource> EventConsumer for EventConsumerAdapter<S> {
                     let payload = match serde_json::from_slice::<EventPayload>(&msg.payload) {
                         Ok(p) => p,
                         Err(e) => {
-                            tracing::warn!("failed to deserialize event payload: {e}");
+                            tracing::warn!("failed to deserialize event payload — acking to prevent orphan: {e}");
+                            (msg.ack)();
                             return None;
                         }
                     };
                     let event = match DomainEvent::try_from(payload) {
                         Ok(e) => e,
                         Err(e) => {
-                            tracing::warn!("unknown event type: {e}");
+                            tracing::warn!("unknown or malformed event type — acking to prevent orphan: {e}");
+                            (msg.ack)();
                             return None;
                         }
                     };
                     Some(Ok(EventEnvelope {
                         event,
+                        delivery_count: msg.delivery_count,
                         ack: msg.ack,
                         nack: msg.nack,
                     }))
@@ -192,6 +196,7 @@ mod tests {
                 let msg = RawMessage {
                     subject: "thoughts.created".to_string(),
                     payload: self.bytes.clone(),
+                    delivery_count: 1,
                     ack: Box::new(|| {}),
                     nack: Box::new(|| {}),
                 };
@@ -216,6 +221,7 @@ mod tests {
                 let msg = RawMessage {
                     subject: "bad".to_string(),
                     payload: b"not valid json".to_vec(),
+                    delivery_count: 1,
                     ack: Box::new(|| {}),
                     nack: Box::new(|| {}),
                 };