fix: resolve all clippy warnings — redundant closures, dead code, collapsible_if, needless borrow

crates/adapters/activitypub-base/src/activities.rs

@@ -237,14 +237,13 @@ impl Activity for UndoActivity {
 
         match obj_type {
             "Follow" => {
-                if let Some(obj_url) = self.object.get("object").and_then(|o| o.as_str()) {
-                    if let Ok(url) = Url::parse(obj_url) {
-                        if let Some(user_id) = crate::urls::extract_user_id_from_url(&url) {
-                            data.federation_repo
-                                .remove_follower(user_id, self.actor.inner().as_str())
-                                .await?;
-                        }
-                    }
+                if let Some(obj_url) = self.object.get("object").and_then(|o| o.as_str())
+                    && let Ok(url) = Url::parse(obj_url)
+                    && let Some(user_id) = crate::urls::extract_user_id_from_url(&url)
+                {
+                    data.federation_repo
+                        .remove_follower(user_id, self.actor.inner().as_str())
+                        .await?;
                 }
                 data.object_handler
                     .on_actor_removed(self.actor.inner())
@@ -260,14 +259,14 @@ impl Activity for UndoActivity {
                     .and_then(|id| id.as_str())
                     .or_else(|| self.object.get("id").and_then(|id| id.as_str()));
 
-                if let Some(ap_id_str) = ap_id_str {
-                    if let Ok(ap_id) = Url::parse(ap_id_str) {
-                        data.object_handler
-                            .on_delete(&ap_id, self.actor.inner())
-                            .await
-                            .map_err(|e| Error::from(anyhow::anyhow!(e)))?;
-                        tracing::info!(ap_id = %ap_id_str, "undo Add (watchlist remove)");
-                    }
+                if let Some(ap_id_str) = ap_id_str
+                    && let Ok(ap_id) = Url::parse(ap_id_str)
+                {
+                    data.object_handler
+                        .on_delete(&ap_id, self.actor.inner())
+                        .await
+                        .map_err(|e| Error::from(anyhow::anyhow!(e)))?;
+                    tracing::info!(ap_id = %ap_id_str, "undo Add (watchlist remove)");
                 }
             }
             other => {

crates/adapters/activitypub-base/src/data.rs

@@ -14,6 +14,7 @@ pub struct FederationData {
     pub(crate) domain: String,
     pub(crate) allow_registration: bool,
     pub(crate) software_name: String,
+    #[allow(dead_code)]
     pub(crate) event_publisher: Option<Arc<dyn EventPublisher>>,
 }
 

crates/adapters/activitypub-base/src/service.rs

@@ -107,6 +107,7 @@ pub struct ActivityPubService {
 }
 
 impl ActivityPubService {
+    #[allow(clippy::too_many_arguments)]
     pub async fn new(
         repo: Arc<dyn FederationRepository>,
         user_repo: Arc<dyn ApUserRepository>,
@@ -748,7 +749,7 @@ impl ActivityPubService {
             .await
             .map_err(|e| anyhow::anyhow!("{e}"))?;
         // Wrap with @context so Mastodon's JSON-LD processor can resolve field names.
-        let person_json = serde_json::to_value(&WithContext::new_default(person))?;
+        let person_json = serde_json::to_value(WithContext::new_default(person))?;
 
         let update_id = Url::parse(&format!(
             "{}/activities/update/{}",

crates/adapters/activitypub-base/src/urls.rs

@@ -22,6 +22,7 @@ pub fn actor_url(base_url: &str, user_id: uuid::Uuid) -> Url {
 }
 
 /// Extract the username segment from a /users/:username URL.
+#[allow(dead_code)]
 pub fn extract_username_from_url(url: &Url) -> Option<String> {
     url.path()
         .strip_prefix("/users/")