refactor: replace long arg lists with input/config structs and builder

- Thought::new_local → NewThought struct (7 args → 1)
- UserWriter::update_profile → UpdateProfileInput struct (6 args → 2)
- update_profile use case → UpdateProfileInput (8 args → 3)
- ActivityPubService::new → builder pattern (9 args → 5 required + 4 optional setters)
- accept_note → AcceptNoteInput struct (8 args → 1)
- ThoughtNote::new_public → ThoughtNoteInput struct (8 args → 1)

Remove all #[allow(clippy::too_many_arguments)] annotations.

crates/application/src/services/federation_event/tests.rs

@@ -5,7 +5,7 @@ use async_trait::async_trait;
 use domain::{
     errors::DomainError,
     events::DomainEvent,
-    models::thought::{Thought, Visibility},
+    models::thought::{NewThought, Thought, Visibility},
     models::user::User,
     testing::TestStore,
     value_objects::*,
@@ -92,15 +92,15 @@ fn alice() -> User {
 }
 
 fn local_thought(author_id: UserId) -> Thought {
-    Thought::new_local(
-        ThoughtId::new(),
-        author_id,
-        Content::new_local("hello").unwrap(),
-        None,
-        Visibility::Public,
-        None,
-        false,
-    )
+    Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: author_id,
+        content: Content::new_local("hello").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Public,
+        content_warning: None,
+        sensitive: false,
+    })
 }
 
 fn svc(store: &TestStore, spy: Arc<SpyPort>) -> FederationEventService {
@@ -275,15 +275,15 @@ async fn boost_of_remote_thought_announces_remote_ap_id() {
 async fn direct_thought_created_does_not_broadcast() {
     let store = TestStore::default();
     let alice = alice();
-    let thought = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("private").unwrap(),
-        None,
-        Visibility::Direct,
-        None,
-        false,
-    );
+    let thought = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("private").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Direct,
+        content_warning: None,
+        sensitive: false,
+    });
     store.users.lock().unwrap().push(alice.clone());
     store.thoughts.lock().unwrap().push(thought.clone());
 
@@ -304,15 +304,15 @@ async fn direct_thought_created_does_not_broadcast() {
 async fn followers_only_thought_does_not_broadcast_publicly() {
     let store = TestStore::default();
     let alice = alice();
-    let thought = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("for followers").unwrap(),
-        None,
-        Visibility::Followers,
-        None,
-        false,
-    );
+    let thought = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("for followers").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Followers,
+        content_warning: None,
+        sensitive: false,
+    });
     store.users.lock().unwrap().push(alice.clone());
     store.thoughts.lock().unwrap().push(thought.clone());
 

crates/application/src/services/notification_event/tests.rs

@@ -2,7 +2,7 @@ use super::*;
 use domain::{
     models::{
         notification::NotificationKind,
-        thought::{Thought, Visibility},
+        thought::{NewThought, Thought, Visibility},
         user::User,
     },
     testing::TestStore,
@@ -24,15 +24,15 @@ async fn like_creates_notification_for_thought_author() {
     let store = TestStore::default();
     let alice = alice();
     let bob_id = UserId::new();
-    let thought = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("hello").unwrap(),
-        None,
-        Visibility::Public,
-        None,
-        false,
-    );
+    let thought = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("hello").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Public,
+        content_warning: None,
+        sensitive: false,
+    });
     store.thoughts.lock().unwrap().push(thought.clone());
     let svc = NotificationEventService {
         thoughts: Arc::new(store.clone()),
@@ -54,15 +54,15 @@ async fn like_creates_notification_for_thought_author() {
 async fn self_like_creates_no_notification() {
     let store = TestStore::default();
     let alice = alice();
-    let thought = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("hello").unwrap(),
-        None,
-        Visibility::Public,
-        None,
-        false,
-    );
+    let thought = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("hello").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Public,
+        content_warning: None,
+        sensitive: false,
+    });
     store.thoughts.lock().unwrap().push(thought.clone());
     let svc = NotificationEventService {
         thoughts: Arc::new(store.clone()),
@@ -103,15 +103,15 @@ async fn reply_creates_notification_for_original_author() {
     let store = TestStore::default();
     let alice = alice();
     let bob_id = UserId::new();
-    let original = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("original").unwrap(),
-        None,
-        Visibility::Public,
-        None,
-        false,
-    );
+    let original = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("original").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Public,
+        content_warning: None,
+        sensitive: false,
+    });
     store.thoughts.lock().unwrap().push(original.clone());
     let svc = NotificationEventService {
         thoughts: Arc::new(store.clone()),
@@ -133,15 +133,15 @@ async fn reply_creates_notification_for_original_author() {
 async fn self_reply_creates_no_notification() {
     let store = TestStore::default();
     let alice = alice();
-    let original = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("original").unwrap(),
-        None,
-        Visibility::Public,
-        None,
-        false,
-    );
+    let original = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("original").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Public,
+        content_warning: None,
+        sensitive: false,
+    });
     store.thoughts.lock().unwrap().push(original.clone());
     let svc = NotificationEventService {
         thoughts: Arc::new(store.clone()),
@@ -161,15 +161,15 @@ async fn self_reply_creates_no_notification() {
 async fn self_boost_creates_no_notification() {
     let store = TestStore::default();
     let alice = alice();
-    let thought = Thought::new_local(
-        ThoughtId::new(),
-        alice.id.clone(),
-        Content::new_local("hello").unwrap(),
-        None,
-        Visibility::Public,
-        None,
-        false,
-    );
+    let thought = Thought::new_local(NewThought {
+        id: ThoughtId::new(),
+        user_id: alice.id.clone(),
+        content: Content::new_local("hello").unwrap(),
+        in_reply_to_id: None,
+        visibility: Visibility::Public,
+        content_warning: None,
+        sensitive: false,
+    });
     store.thoughts.lock().unwrap().push(thought.clone());
     let svc = NotificationEventService {
         thoughts: Arc::new(store.clone()),