GKaszewski/thoughts
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(domain): from_db_str returns Result — unknown DB values are errors not silent defaults

Browse Source
This commit is contained in:
Gabriel Kaszewski
2026-05-15 13:57:38 +02:00
parent 5a64dd361c
commit f697267828
7 changed files with 75 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
crates/adapters/postgres/src/feed.rs
View File

@@ -106,13 +106,13 @@ fn feed_select(viewer: Option<uuid::Uuid>) -> String {
)
}
fn row_to_entry(r: FeedRow) -> FeedEntry {
fn row_to_entry(r: FeedRow) -> Result<FeedEntry, DomainError> {
let thought = Thought {
id: ThoughtId::from_uuid(r.thought_id),
user_id: UserId::from_uuid(r.t_user_id),
content: Content::new_remote(r.content),
in_reply_to_id: r.in_reply_to_id.map(ThoughtId::from_uuid),
visibility: Visibility::from_db_str(&r.visibility),
visibility: Visibility::from_db_str(&r.visibility)?,
content_warning: r.content_warning,
sensitive: r.sensitive,
local: r.t_local,
@@ -133,7 +133,7 @@ fn row_to_entry(r: FeedRow) -> FeedEntry {
created_at: r.author_created_at,
updated_at: r.author_updated_at,
};
FeedEntry {
Ok(FeedEntry {
thought,
author,
like_count: r.like_count,
@@ -141,7 +141,7 @@ fn row_to_entry(r: FeedRow) -> FeedEntry {
reply_count: r.reply_count,
liked_by_viewer: r.liked_by_viewer,
boosted_by_viewer: r.boosted_by_viewer,
}
})
}
#[async_trait]
@@ -176,7 +176,10 @@ impl FeedRepository for PgFeedRepository {
.into_domain()?;
Ok(Paginated {
items: rows.into_iter().map(row_to_entry).collect(),
items: rows
.into_iter()
.map(row_to_entry)
.collect::<Result<Vec<_>, _>>()?,
total,
page: page.page,
per_page: page.per_page,
@@ -206,7 +209,10 @@ impl FeedRepository for PgFeedRepository {
.into_domain()?;
Ok(Paginated {
items: rows.into_iter().map(row_to_entry).collect(),
items: rows
.into_iter()
.map(row_to_entry)
.collect::<Result<Vec<_>, _>>()?,
total,
page: page.page,
per_page: page.per_page,
@@ -239,7 +245,10 @@ impl FeedRepository for PgFeedRepository {
.into_domain()?;
Ok(Paginated {
items: rows.into_iter().map(row_to_entry).collect(),
items: rows
.into_iter()
.map(row_to_entry)
.collect::<Result<Vec<_>, _>>()?,
total,
page: page.page,
per_page: page.per_page,
@@ -281,7 +290,10 @@ impl FeedRepository for PgFeedRepository {
.into_domain()?;
Ok(Paginated {
items: rows.into_iter().map(row_to_entry).collect(),
items: rows
.into_iter()
.map(row_to_entry)
.collect::<Result<Vec<_>, _>>()?,
total,
page: page.page,
per_page: page.per_page,
@@ -321,7 +333,10 @@ impl FeedRepository for PgFeedRepository {
.into_domain()?;
Ok(Paginated {
items: rows.into_iter().map(row_to_entry).collect(),
items: rows
.into_iter()
.map(row_to_entry)
.collect::<Result<Vec<_>, _>>()?,
total,
page: page.page,
per_page: page.per_page,