fix(domain): from_db_str returns Result — unknown DB values are errors not silent defaults

crates/domain/src/models/social.rs

@@ -35,11 +35,14 @@ impl FollowState {
         }
     }
 
-    pub fn from_db_str(s: &str) -> Self {
+    pub fn from_db_str(s: &str) -> Result<Self, crate::errors::DomainError> {
         match s {
-            "pending" => Self::Pending,
-            "rejected" => Self::Rejected,
-            _ => Self::Accepted,
+            "pending" => Ok(Self::Pending),
+            "accepted" => Ok(Self::Accepted),
+            "rejected" => Ok(Self::Rejected),
+            other => Err(crate::errors::DomainError::Internal(format!(
+                "unknown follow_state: '{other}'"
+            ))),
         }
     }
 }

crates/domain/src/models/thought.rs

@@ -33,12 +33,15 @@ impl Visibility {
         }
     }
 
-    pub fn from_db_str(s: &str) -> Self {
+    pub fn from_db_str(s: &str) -> Result<Self, crate::errors::DomainError> {
         match s {
-            "followers" => Self::Followers,
-            "unlisted" => Self::Unlisted,
-            "direct" => Self::Direct,
-            _ => Self::Public,
+            "public" => Ok(Self::Public),
+            "followers" => Ok(Self::Followers),
+            "unlisted" => Ok(Self::Unlisted),
+            "direct" => Ok(Self::Direct),
+            other => Err(crate::errors::DomainError::Internal(format!(
+                "unknown visibility: '{other}'"
+            ))),
         }
     }
 }