GKaszewski/thoughts
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Use outbox for edit_thought instead of fire-and-forget publish #17

New Issue
Open
opened 2026-07-25 11:18:32 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:18:32 +00:00
Owner
Copy Link

Severity: Medium

crates/application/src/use_cases/thoughts/mod.rs:

  • create_thought uses outbox.append() (reliable, persisted)
  • delete_thought uses outbox.append() (reliable, persisted)
  • edit_thought uses events.publish() directly (fire-and-forget via NATS)

The _events parameter in create_thought is unused (underscore-prefixed), and edit_thought bypasses the outbox entirely. If NATS is down during an edit, the update event is silently lost. All three should use the outbox for consistency.

**Severity: Medium** `crates/application/src/use_cases/thoughts/mod.rs`: - `create_thought` uses `outbox.append()` (reliable, persisted) - `delete_thought` uses `outbox.append()` (reliable, persisted) - `edit_thought` uses `events.publish()` directly (fire-and-forget via NATS) The `_events` parameter in `create_thought` is unused (underscore-prefixed), and `edit_thought` bypasses the outbox entirely. If NATS is down during an edit, the update event is silently lost. All three should use the outbox for consistency.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/thoughts#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?