GKaszewski/thoughts
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Add test gate to deploy workflow #19

New Issue
Open
opened 2026-07-25 11:18:42 +00:00 by GKaszewski · 0 comments
GKaszewski commented 2026-07-25 11:18:42 +00:00
Owner
Copy Link

Severity: Low

The deploy workflow (.gitea/workflows/deploy.yml) is workflow_dispatch only and does not depend on the test/lint workflows. Someone can manually deploy a broken build.

Add needs: [test, lint] or at minimum a check that CI passed on the commit being deployed.

**Severity: Low** The deploy workflow (`.gitea/workflows/deploy.yml`) is `workflow_dispatch` only and does not depend on the test/lint workflows. Someone can manually deploy a broken build. Add `needs: [test, lint]` or at minimum a check that CI passed on the commit being deployed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GKaszewski
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GKaszewski/thoughts#19
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?