code refactor

Reviewed-on: #26

crates/adapters/export/tests/export_adapter_test.rs

@@ -0,0 +1,144 @@
+use domain::{
+    models::{DiaryEntry, ExportFormat, Movie, ReviewEdit},
+    ports::DiaryExporter,
+    testing::{
+        test_movie_with_director, test_movie_with_external_id, test_movie_with_year, test_review,
+    },
+    value_objects::{Comment, ExternalMetadataId, UserId},
+};
+use export::ExportAdapter;
+
+async fn collect_stream(
+    stream: futures::stream::BoxStream<'static, Result<bytes::Bytes, domain::errors::DomainError>>,
+) -> Vec<u8> {
+    use futures::StreamExt;
+    let mut out = Vec::new();
+    futures::pin_mut!(stream);
+    while let Some(chunk) = stream.next().await {
+        out.extend_from_slice(&chunk.unwrap());
+    }
+    out
+}
+
+fn entry_stream(
+    entries: Vec<domain::models::DiaryEntry>,
+) -> futures::stream::BoxStream<
+    'static,
+    Result<domain::models::DiaryEntry, domain::errors::DomainError>,
+> {
+    Box::pin(futures::stream::iter(entries.into_iter().map(Ok)))
+}
+
+fn entry_for(movie: Movie, rating: u8, comment: Option<&str>) -> DiaryEntry {
+    let review = test_review(movie.id(), &UserId::generate(), rating).apply_edit(ReviewEdit {
+        comment: Some(comment.map(|c| Comment::new(c.to_string()).unwrap())),
+        ..Default::default()
+    });
+    DiaryEntry::new(movie, review)
+}
+
+#[tokio::test]
+async fn csv_has_header_and_one_row() {
+    let adapter = ExportAdapter;
+    let entry = entry_for(
+        test_movie_with_director("Inception", 2010, "Christopher Nolan"),
+        5,
+        Some("great"),
+    );
+    let bytes =
+        collect_stream(adapter.stream_entries(entry_stream(vec![entry]), ExportFormat::Csv)).await;
+    let text = String::from_utf8(bytes).unwrap();
+    assert!(text.starts_with(
+        "title,year,director,rating,comment,watched_at,external_metadata_id,spoilers\n"
+    ));
+    assert!(text.contains("Inception"));
+    assert!(text.contains("2010"));
+    assert!(text.contains("Christopher Nolan"));
+    assert!(text.contains("5"));
+    assert!(text.contains("great"));
+    assert!(text.contains("2024-03-15"));
+}
+
+#[tokio::test]
+async fn csv_escapes_commas_in_title() {
+    let adapter = ExportAdapter;
+    let entry = entry_for(test_movie_with_year("Tár, A Film", 2022), 4, None);
+    let bytes =
+        collect_stream(adapter.stream_entries(entry_stream(vec![entry]), ExportFormat::Csv)).await;
+    let text = String::from_utf8(bytes).unwrap();
+    assert!(text.contains("\"Tár, A Film\""));
+}
+
+#[tokio::test]
+async fn json_is_valid_array() {
+    let adapter = ExportAdapter;
+    let entry = entry_for(
+        test_movie_with_director("Dune", 2021, "Denis Villeneuve"),
+        5,
+        None,
+    );
+    let bytes =
+        collect_stream(adapter.stream_entries(entry_stream(vec![entry]), ExportFormat::Json)).await;
+    let arr: Vec<serde_json::Value> = serde_json::from_slice(&bytes).unwrap();
+    assert_eq!(arr.len(), 1);
+    assert_eq!(arr[0]["title"], "Dune");
+    assert_eq!(arr[0]["year"], 2021);
+    assert_eq!(arr[0]["rating"], 5);
+    assert_eq!(arr[0]["comment"], serde_json::Value::Null);
+    assert_eq!(arr[0]["external_metadata_id"], serde_json::Value::Null);
+}
+
+#[tokio::test]
+async fn external_metadata_id_included_when_present() {
+    let adapter = ExportAdapter;
+    let entry = entry_for(
+        test_movie_with_external_id(
+            "Alien",
+            1979,
+            ExternalMetadataId::new("tt0078748".to_string()).unwrap(),
+        ),
+        5,
+        None,
+    );
+    let bytes =
+        collect_stream(adapter.stream_entries(entry_stream(vec![entry]), ExportFormat::Json)).await;
+    let arr: Vec<serde_json::Value> = serde_json::from_slice(&bytes).unwrap();
+    assert_eq!(arr[0]["external_metadata_id"], "tt0078748");
+
+    let bytes = collect_stream(adapter.stream_entries(
+        entry_stream(vec![entry_for(
+            test_movie_with_external_id(
+                "Alien",
+                1979,
+                ExternalMetadataId::new("tt0078748".to_string()).unwrap(),
+            ),
+            5,
+            None,
+        )]),
+        ExportFormat::Csv,
+    ))
+    .await;
+    let text = String::from_utf8(bytes).unwrap();
+    assert!(text.contains("tt0078748"));
+}
+
+#[tokio::test]
+async fn empty_entries_returns_csv_header_only() {
+    let adapter = ExportAdapter;
+    let bytes =
+        collect_stream(adapter.stream_entries(entry_stream(vec![]), ExportFormat::Csv)).await;
+    let text = String::from_utf8(bytes).unwrap();
+    assert_eq!(
+        text,
+        "title,year,director,rating,comment,watched_at,external_metadata_id,spoilers\n"
+    );
+}
+
+#[tokio::test]
+async fn empty_json_is_valid_empty_array() {
+    let adapter = ExportAdapter;
+    let bytes =
+        collect_stream(adapter.stream_entries(entry_stream(vec![]), ExportFormat::Json)).await;
+    let arr: Vec<serde_json::Value> = serde_json::from_slice(&bytes).unwrap();
+    assert!(arr.is_empty());
+}