refactor/tighten-architecture #26

GKaszewski · 2026-10-26T09:24:06Z

GKaszewski commented

2026-10-26 09:24:06 +00:00

No description provided.

GKaszewski added 103 commits 2026-10-26 09:24:08 +00:00

chore: gate test helpers, code style, stricter clippy 18c179e14c

refactor: typed errors in rss/import ports 59238a36d8

refactor: drop postgres backend 933400e1c2

refactor: collapse feature flags to federation+nats 1b7384386a

docs: adr 0012 sqlite only 3a05b83320

docs: fix presentation feature comment, dedupe readme 79cce2a740

test: pin migration ledger f8fe49f739

test: track pre_merge.db fixture 1ece8032ff

refactor: merge sqlite adapter family into one crate 67597ec9a6

refactor: sqlite repositories per aggregate ab4e4c3138

feat: config crate with legacy env names 8bdf55cfe1

fix: config file parse errors not reported as missing DATABASE_URL 1f724bb064

refactor: adapters configured from config crate 04f9c13625

refactor: bootstrap crate, thin server/worker binaries 9bf9342fc0

fix: config empty values unset, drop adapter from_vars a00a5dc655

fix: bootstrap log directives, empty DATABASE_URL test 57c70afead

refactor: merge media-server parsers, move poster sync and event payload b5bfdadcd9

test: classic route and openapi characterization d7bac4aec3

test: seed ready wrapups, federation-off gate target 2875594ed9

refactor: presentation becomes http-axum adapter, absorbs templates a931fb548f

refactor: http-axum split into api/html/federation modules, router.rs, templates per page group 614aec8df9

chore: check-http-adapter-deps guard, README layout 816d39ffd6

refactor: single refusal shape with openapi contract test c8d9138349

refactor: Upload extractor, 429 refusal test, stricter contract test 2ac1d4e0cf

test: shared factories and command builders 51d92e08a7

test: cascading in-memory store 06eec2feae

test: refusing fakes, failure-path tests, shared panic stubs 5256c6e851

test: test app from bootstrap, prune wiring tests 1e6e9ddf6b

test: move domain tests to tests/ a2c713c1fa

Self dev-dep w/ test-helpers for domain::testing. Also moved social blanket-impl + InMemoryStore tests (public API only). No private-item exceptions.

test: move application tests to tests/ 8526b77f18

test_support/test_helpers -> tests/support; watched_at unified w/ domain test_watched_at (2024-03-15).
Kept inline: users::diary_filter tests (feed_sort_to_direction_all_variants, paged_user_filter_builds_correctly) - pub(super) helpers in private module.
Dropped stale never-compiled users/tests/get_users.rs (old execute signature).

test: move sqlite tests to tests/ f6383d6c04

No inline exceptions; migrate via sqlite::migrate, renamed diary/social tests.

test: move activitypub tests to tests/ 5118bf4700

Assert via serialized JSON (fields pub(crate)); normalize_hashtag covered via review tags. No inline exceptions.

test: move sqlite-federation tests to tests/ ec22ac1d75

No inline exceptions.

test: get_users use case fdf4df38af

Fake list_with_stats now returns stored users (was always empty).

test: move small adapter tests to tests/ 74674b157c

event-publisher, export, rss, media-server, object-storage, nats(config).
Kept inline (private fn, no public path): nats src/subject.rs
tests::{review_logged_subject,review_updated_subject,movie_discovered_subject,
consumer_subject_filter_appends_wildcard} - event_to_subject/consumer_subject_filter private.
object-storage build_local_store tests rewritten via StorageConfig::from_config.

test: move image-converter tests to tests/ 760acb1f9f

test: move importer tests to tests/ (via DocumentParser) 52bbb85980

test: move api-types, event-payload tests to tests/ 08a97c9ee9

test: move tui tests to tests/ 5c5a8c3326

Kept inline: tui src/client.rs tests::{api_client_builds_versioned_urls,api_client_update_url} - ApiClient::api/url private.

fake user store: list_with_stats sorted by email 07c8b011d8

test: move http-axum tests to tests/ a1c3f7760d

Drop bootstrap dev-dep. Extractor + api handler + app-context tests (need full AppState via build_deps) -> bootstrap/tests/http_handlers/. forms tests -> http-axum/tests/log_review_form_test.rs.
Federation collection tests now go through public federation::html_routes().
Kept inline (private fns): api/social social_actor_to_dto (4), federation/blocklist_api social_actor_to_blocked_dto (1), html/social social_actor_to_template (1), router slow_down/api_governor (2).

chore: dockerfile manifest guard b76f5996da

docs: update for new crate layout 80072eb463

docs: fix config table, test-location claims 7c6dff7f70

fix: log targets in image defaults and docs cb5ffe2797

refactor: rename application AppConfig to AppSettings 980de9697a

chore: drop unused deps ec2760fd48

refactor: drop postgres leftovers, narrow bootstrap api b7e69b69dc

fix(sqlite): atomic event queue claim d073922308

fix(sqlite): dedup clears old external id before canonical upsert b96f03f86f

docs: adr 0013 accuracy 98ad1a8fe7

test: harden claim race test c31aa033cc

feat: event ids, outbox identity migration 32dfc84697

feat: worker relays outbox to nats c06d3d9207

fix: relay shutdown, claim lease, dead-letter undecodable, dedup window fa8e94817a

feat: processed-event ledger, idempotent dispatch 5681d0c034

fix: per-handler claim lease in ledger, nats max_deliver, pin handler names 53892847f2

fix: defer blocked deliveries, claim owner token 0236a488fa

feat: atomic review writes with events c8a1e8bfe4

feat: atomic goal, watchlist, profile writes 62ad9f4017

fix: honest review update rollback test, goal delete NotFound fake, read before write 2f133afb96

feat: atomic wrapup, movie, integration writes 6c295866a0

Ride writes: WrapUpRequested/Completed (wrapup create/set_complete),
MovieDiscovered (resolve upsert, new+ext id only), PosterSynced (poster
handler upsert), MovieDeleted (delete_movie), WatchEventIngested (save).
Deps drop event_publisher: wrapup, ingest, delete_review, watchlist add,
review logger.

Remaining .publish( sites:
announce-only: users/delete_account UserDeleted, person/get +
get_credits PersonEnrichmentRequested, jobs/enrichment_staleness,
http-axum search, movies/sync_poster + poster_sync_handler +
image-converter backfill + users/update_profile ImageStored (object
storage), activitypub federation_event_bridge (reacting to events).
rides write, deferred: social/execute (see report),
activitypub review_handler MovieEnrichmentRequested (after
save_remote_review).

feat: atomic social local writes, remote review enrichment 9a4d0c1714

SocialCommand methods take events. Local follow ops = one FollowCommand::apply
tx (rows + events). k_ap path (remote, block/unblock): best-effort publish in
CompositeSocialAdapter after k_ap write; not atomic, k_ap owns tx.
save_remote_review takes events, enqueued in same tx via
sqlite::persistence::enqueue_events. Deps drop event_publisher: social
command, ReviewObjectHandler.

Remaining .publish( sites:
announce-only: users/delete_account UserDeleted, person/get + get_credits
PersonEnrichmentRequested, jobs/enrichment_staleness, http-axum search,
ImageStored (sync_poster, poster_sync_handler, image-converter backfill,
update_profile; object storage), federation_event_bridge (handler reaction),
nats relay (transport).
non-atomic by necessity: CompositeSocialAdapter::announce (k_ap-owned write).
Everything else rides its write.

fix: NewRemoteReview param struct, atomic review+orphan movie delete 7f9c252d35

feat: idempotent handlers, deterministic activity ids 4cb2972f63

fix: real AP id tests, exact poster key check, exists port, list_movies fake 818ab893a1

fix: apply dedup window + max_deliver to existing jetstream stream/consumer 2fb577af65

docs: adr 0015 transactional outbox 6ae3f54a36

fix(sqlite): concurrent migrate retries 0908b7046a

fix: preserve consumer config on update, warn not abort; adr accuracy 56f3d1ac1b

nats nak w/ shared retry_backoff, exhausted log; no 'will retry' lie dfa5e1a4db

sqlite ack/nack/defer only if claim still held; use shared backoff fe9f284531

relay: sink failure defers + pauses w/ backoff, no attempt spent d0568d7933

watchlist add: event only if inserted; adr 0015 jetstream/relay accuracy; drop vacuous assert bde8040cc3

feat: user tombstone and retired usernames 31f5d5f337