code refactor
Some checks failed
CI / Check / Test (push) Has been cancelled

Reviewed-on: #26
This commit was merged in pull request #26.
This commit is contained in:
2026-10-26 09:36:23 +00:00
parent 2ce7db12c2
commit 017b58d6fa
804 changed files with 33423 additions and 28955 deletions

View File

@@ -0,0 +1,73 @@
use domain::models::DiaryEntry;
use domain::models::ReviewEdit;
use domain::ports::{FeedChannel, RssFeedRenderer};
use domain::testing::{test_movie_with_year, test_review};
use domain::value_objects::{Comment, UserId};
use rss_adapter::RssAdapter;
fn channel<'a>(title: &'a str) -> FeedChannel<'a> {
FeedChannel {
title,
link_path: "/users/abc",
self_path: "/users/abc/feed.rss",
}
}
fn entry(spoilers: bool) -> DiaryEntry {
let movie = test_movie_with_year("Blade Runner", 1982);
let review = test_review(movie.id(), &UserId::generate(), 4).apply_edit(ReviewEdit {
comment: Some(Some(Comment::new("replicants".into()).unwrap())),
spoilers: Some(spoilers),
..Default::default()
});
DiaryEntry::new(movie, review)
}
#[test]
fn render_feed_uses_provided_title() {
let adapter = RssAdapter::new("http://example.com".into());
let xml = adapter.render_feed(&[], &channel("Custom Title")).unwrap();
assert!(xml.contains("<title>Custom Title</title>"));
}
#[test]
fn render_feed_empty_entries_produces_valid_xml() {
let adapter = RssAdapter::new("http://example.com".into());
let xml = adapter.render_feed(&[], &channel("My Feed")).unwrap();
assert!(xml.starts_with("<?xml") || xml.starts_with("<rss"));
}
#[test]
fn channel_links_are_absolute_with_atom_self() {
let adapter = RssAdapter::new("http://example.com/".into());
let xml = adapter.render_feed(&[], &channel("Feed")).unwrap();
assert!(xml.contains("<link>http://example.com/users/abc</link>"));
assert!(xml.contains(r#"xmlns:atom="http://www.w3.org/2005/Atom""#));
assert!(xml.contains(r#"href="http://example.com/users/abc/feed.rss""#));
assert!(xml.contains(r#"rel="self""#));
assert!(xml.contains("<language>en</language>"));
}
#[test]
fn item_links_to_absolute_movie_page() {
let adapter = RssAdapter::new("http://example.com".into());
let e = entry(false);
let xml = adapter
.render_feed(std::slice::from_ref(&e), &channel("Feed"))
.unwrap();
let expected = format!(
"<link>http://example.com/movies/{}</link>",
e.movie().id().value()
);
assert!(xml.contains(&expected), "{xml}");
}
#[test]
fn spoiler_comment_is_omitted() {
let adapter = RssAdapter::new("http://example.com".into());
let xml = adapter
.render_feed(&[entry(true)], &channel("Feed"))
.unwrap();
assert!(xml.contains("contains spoilers"));
assert!(!xml.contains("replicants"));
}