GKaszewski/movies-diary
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity
477 Commits 1 Branch 0 Tags
c224cc6bd2903b359ff3dfb46f0b1c562752b690
Commit Graph

11 Commits

Author SHA1 Message Date
Gabriel Kaszewski
12da356a40 refactor: fix HIGH+MEDIUM architectural violations from code review 
HIGH: fix watch_medium data-loss bug, standardize error handling on
ApiError, fix dep direction (rss/template-askama no longer dep on
application), extract ImageFetcher port (remove reqwest from app layer),
move event construction from save_review to use case, extract
infra-wiring crate (DbPool/EventBusBackend dedup), deduplicate
presentation helpers (encode_error, export streaming, multipart parsing)

MEDIUM: split LocalApContentQuery god-trait 10→3 methods, dedup movie
resolution orchestration, add RemoteActorDto/PersonDto mappers, move
AppConfig to infra-wiring, fix SocialQueryPort Uuid→UserId, replace
stringly-typed api-types with domain enums, move count_reviews_in_year
to StatsRepository, dedup event publisher cfg blocks, extract
should_enrich, move group_by_month to application, dedup
count_local_posts, add FederationFlags Default, TUI input helper +
ShowError rename + typed auth errors, api-types cleanup
(UserSettingsDto/UserProfileBase/PreviewRowData)

102 files changed, -681 lines net
 2026-07-10 02:08:39 +02:00
Gabriel Kaszewski
9c06fbd33e refactor 2026-06-29 23:54:59 +02:00
Gabriel Kaszewski
cedb13d7a8 fix(domain): typed VOs in MovieEnrichmentRequested and PersonEnrichmentRequested 2026-06-12 01:34:47 +02:00
Gabriel Kaszewski
66bd138927 refactor(person): EnrichPersonDeps + GetPersonDeps, PersonEnrichmentHandler 2026-06-11 22:05:38 +02:00
Gabriel Kaszewski
b09ef4686a fmt 2026-06-11 14:03:05 +02:00
Gabriel Kaszewski
2074a2244e refactor: move person enrichment staleness check to application layer 2026-06-11 14:01:44 +02:00
Gabriel Kaszewski
c05087a6c7 fmt 2026-06-11 13:51:33 +02:00
Gabriel Kaszewski
57c720b22f fix: collapse nested if per clippy 2026-06-11 13:47:32 +02:00
Gabriel Kaszewski
371a3cdc46 app: person enrichment use case + staleness checks 2026-06-11 13:36:43 +02:00
Gabriel Kaszewski
d867a14b28 add 400+ unit tests for domain and application layers
Some checks failed
CI / Check / Test (push) Has been cancelled
Details 
Extract ReviewLogger trait to decouple import/integrations
from diary::log_review (cross-module coupling smell).

Add in-memory fakes for all repository ports, enabling
isolated testing of every use case module without a database.

Coverage: domain+application 22% → 80%, 427 tests.
 2026-06-09 02:07:26 +02:00
Gabriel Kaszewski
dcc9244d4e refactor: group use cases into DDD bounded contexts 
Flat use_cases/ (44 files) + monolithic commands.rs/queries.rs
split into diary/, movies/, watchlist/, import/, auth/, users/,
integrations/, search/, person/, federation/ — each with own
commands.rs, queries.rs, and use case modules.

Inline tests extracted to sibling tests/ dirs.
 2026-06-02 19:49:09 +02:00